GitLab

To allow for future optimization, the RRset pointer classes now
point to the base of the RRset inheritance hierarchy.

(there doesn't seem to be need for updating the python doc)

as suggested in review.  hid the concrete derived class in the implementation.
adjusted tests accordingly.

we should either/both consider revisiting the interface so we avoid the
issue as a result or require higher version of boost.  but for now this
should be okay.

fixing bugs like case-sensitivity or corner cases for empty salts.
provided more detailed tests and documentation.

not directly related but would be helpful for the purpose of the branch.

separate RRsets.  As noted in the previous comment the previous behavior
was okay in practice within the expected restriction of the current
implementation, but as we are probably going to accept more generic forms
of input it would be prudent to fix it at this timing.

this is not absolutely necessary for the purpose of this branch, but
it will help make it less ugly.

shared_ptr is a candidates for the next STL version and Windows has
already adopted it.  This change removes ambiguity between the Boost
and Windows versions of the class.

- DHCPv4 tests now simulate detection of 127.0.0.1 address
- DHCPv4 tests now open sockets on loopback
- Option::getUintX() now uses code from isc::util::getUintX
- Option::getUintX() methods are now documented
- Test for option::getUintX() implemented
- src/lib/dns/benchmarks/Makefile that was added by mistake removed

Some loops changed to use unsigned loop indexes to avoid warning
messages from some compilers.

reviewed on jabber

our debian test system has old botan libs in the library path used for gtest, making it fail with unknown algorithm errors unless botan is specified first

and put them in the correct place