GitLab

To allow for future optimization, the RRset pointer classes now
point to the base of the RRset inheritance hierarchy.

shared_ptr is a candidates for the next STL version and Windows has
already adopted it.  This change removes ambiguity between the Boost
and Windows versions of the class.

Some loops changed to use unsigned loop indexes to avoid warning
messages from some compilers.

Not strictly part of the ticket, but added because the first tests I
did with the existing code returned NSAS_INVALID_RESPONSE messages. This
was a common error to three conditions: the change separates these
out and logs a different message for each one.  It also changes the
severity of two of those conditions (which are caused by the contents
of the returned packet) from ERROR to DEBUG.

(Of course, once the change was made, the original problem could not
be reproduced...
 Please enter the commit message for your changes. Lines starting

And revert the change from jreed-doxygen to io_asio_socket.h.
Opened a ticket for that #1366.

And for check_LTLIBRARIES to noinst_LTLIBRARIES too.

This is so a regular "make" will build the test programs and
libraries too.  So the "make check" will just run the tests (and
not build them).  This is to help with test-driven development.

This reverses some from #1091, plus does the rest too.

Note that doing a "make check" before a "make" does not currently
work due to dependencies depending on each other (e.g. python/isc/log
tests needs datasrc but python/isc/datasrc tests need log_config_update).

and while here also only build when the "make check" target is used;
since we already require --with-gtest maybe this step is not of much
interest.

remove non-existent parameter
fix wrong names

Fix some typos, wrong tags, get rid of bogus tags.
Added some TODOs directly into the docs -- so they will need to be
completed too.

... and correct a couple of IDs missed first time round.

This only needed to be in the Makefile.am for the liblog library,
not everywhere else!

For some reason, libtool is not picking up this library from the
dependency in libutil_unittests.  Adding the library to the link
cures the problem.

Also, move the directory util/io/tests to util/io_tests so that
the utilities code and tests build in the right order.

Also update the test Makefile.am files to include the appropriate libraries.

When logging, the conversion of the parameters to string is done via
boost::lexical_cast.  This uses operator<<(), so if the object has
that function defined for it, there is no need to explicitly call
the object's toText() method when passing it as a logging parameter.

Also renamed the message file extension to ".mes" to conform to other
messages files and updated the associated documentation as well.

... the logical place for it.

The logging source files are now built at run-time instead of being
part of the repository.

In addition, run_unittests.cc has been augmented by some temporary
code to enable message output during testing.  This code is likely
to change or to be moved to a utility directory at some point in
the future.

Note that nsasdef.cc and nsasdef.h are derived from nsasdef.msg and
really should be generated from it during the build process.  For now
though, they are generated and added to the git repository.

... and a test to check that setting the RTT to an absurdly high
value causes no problems.