GitLab

    Merge branch 'trac4481'

The client packet is now uniformly available to all client packet driven
callouts for both v4 and v6:

Added "query4" to lease4_select and lease4_renew
    src/bin/dhcp4/dhcp4_hooks.dox
        Added query4 argument to lease4_select and lease4_renew documentation

    src/bin/dhcp4/tests/hooks_unittest.cc
        Revamped to track both query4 and response4 arguments
        TEST_F(HooksDhcpv4SrvTest, lease4RenewSimple) - modified to verify
        query4 set by lease4_renew callout

    src/lib/dhcpsrv/alloc_engine.cc
        - AllocEngine::createLease4()
        - AllocEngine::reuseExpiredLease4() - modified to add query4 to
        lease4_select callout arguments
        - AllocEngine::renewLease4() - modified to add query4 to lease4_renew
        callout arguments

    src/lib/dhcpsrv/tests/alloc_engine_hooks_unittest.cc
        HookAllocEngine4Test() - modified to track query4 argument
        TEST_F(HookAllocEngine4Test, lease4_select) - modified to verify query4
        callout argument

Added "query6" to pkt6_send and lease6_select
    src/bin/dhcp6/dhcp6_hooks.dox
        Added query6 argument to pkt6_send and lease6_select documentation

    src/bin/dhcp6/dhcp6_srv.cc
        Dhcpv6Srv::processPacket(Pkt6Ptr& query, Pkt6Ptr& rsp) - modified to
        add query6 to the pkt_send callout arguments

    src/bin/dhcp6/tests/hooks_unittest.cc
        Revamped to track both query4 and response4 arguments
        TEST_F(HooksDhcpv6SrvTest, simplePkt6Send) - modified to
        verify query6 set by pkt6_send callout

    src/lib/dhcpsrv/alloc_engine.cc
        - AllocEngine::createLease4()
        - AllocEngine::reuseExpiredLease6() - modified to add query6 to
        lease6_select callout arguments
        callout arguments

    src/lib/dhcpsrv/tests/alloc_engine_hooks_unittest.cc
        HookAllocEngine6Test() - modified to track query6 argument
        TEST_F(HookAllocEngine6Test, lease4_select) - modified to verify
        query6 argument

One compiler was objecting to placing the address of a size_t variable
into a variable declared as "unsigned long*".  Changing the
declaration from "size_t" to "unsigned long" fixes the problem.

 - check for address being :: updated

    HooksManager::loadLibraries() call now requires
    LibraryCollection as parameter

    Merge branch 'trac4492'

src/bin/dhcp4/tests/hooks_unittest.cc
src/bin/dhcp6/tests/hooks_unittest.cc
    Fixed includes, copyright, and removed unnecessary calls to
    IfaceMgr::instance().deleteAllExternalSockets();

src/bin/dhcp4/tests/hooks_unittest.cc
    TEST_F(LoadUnloadDhcpv4SrvTest, unloadLibaries)  - new test that
    verifies Hooks libraries are unloaded by the Dhcpv4Srv destructor

src/bin/dhcp6/tests/hooks_unittest.cc
    TEST_F(LoadUnloadDhcpv6SrvTest, unloadLibaries)  - new test that
    verifies Hooks libraries are unloaded by the Dhcpv4Srv destructor

 Thanks to wpk for reporting this issue.

Presented rate is now the number of ACK/Reply messages,
rather than DO/SA.

The extended test verifies that the stats manager is
still usable after some packets have been collected.

When the perfdhcp performs unordered packet lookup within
a bucket of sent packets, it will remove all timed out
transactions.

This is to eliminate some of the recently found covertity isssues.
Reviewed on jabber.

A call to HooksManager::getHooksManager().unloadLibraries() was added to
the destructors Dhcpv4Srv::~Dhcpv4Srv() and Dhcpv6Srv::~Dhcpv6Srv(). This
ensures hook libraries are unloaded prior to static objects.

 - returnining different values in callout_params_library.cc
 - returned values are now described for getParameter
 - corrected index syntax comment in getParameter
 - added missing include
 - hooks_user.dox updated
 - hooks unit test moved, so it is now next to other hooks tests

- No additional check for HR mode in findReservations
- Additional commentary in the loop collecting host ids.