GitLab

now catch exceptions from reload().

note: I simply removed the last error case.  Such a broken config isn't
installed anyway, so checking after that doesn't seem to make much sense.

Fixed minor conflicts:
	src/bin/auth/datasrc_clients_mgr.h

Since the function is to reload and we provide an object that can
reload, we just get one and call it. It is just to avoid duplicate code.

So now the loading works correctly (at least as the tests say).

Passing it as const RRClass (and making a copy) makes no real sense. It
looks more expected with the reference and might even be slightly
faster.

with some other wording cleanups.

trivial, committing at my discretion.

It is mostly copy of the reload() method. Currently, it does not contain
the initialization of load_action for the zone writer, so if a real zone
writer is returned, it doesn't work (it throws). But the tests for the
unsuccessful cases succeed.

There's also need to do something about the duplicate code between this
method and the reload(). Later on, we'll probably rewrite reload to use
the ZoneWriter (and even later deprecate reload, maybe? Or keep it as
the thin wrapper for convenience?)

with fixing Conflicts to:
	src/bin/auth/auth_srv.cc
	src/bin/auth/auth_srv.h
	src/bin/auth/datasrc_clients_mgr.h
	src/bin/auth/main.cc
	src/bin/auth/tests/auth_srv_unittest.cc
	src/bin/auth/tests/command_unittest.cc

This fix resolves build issues on Fedora 17. Okayed on jabber.

This fix eliminates build failure on Fedora17 and Debian7. Okayed on jabber.

update the test case and log message accordingly.

the users of this method only need the set behavior, and the previous code
actually didn't swap them as expected anyway.

This branch needs the MemoryClient to have its Zonetablesegment. But it
doesn't have one now and it is not the task of this branch to put it in
there. So I added it inside in somewhat ad-hoc manner.

This is hairy and adds bunch of temporary methods. If there's a better
approach, let's use it. But taking this for now to be cleaned up in some
follow-up ticket.

It doesn't produce the expected result (which was obviously expected
in the code). Changed to lexical_cast, which should be enough.

without parameters.

Having constructor with default params values caused build issues on
Mac/clang which complained about not providing constructor's params and ignores
default ones.

This reverts commit e6ba20b0, reversing
changes made to c9ba8373.

They are the reload() tests reused for this purpose. They fail, since
the method is temporary and contains almost no code.

Unlike what the ticket suggests, it takes concrete origin parameter, not
some yet unknown config value, for two reasons:
 * The format of config is not known.
 * Leaking some details about what memory segment or whatever is being
   used for the cache through the interface looks like a bad idea. Even
   leaking the existence of the cache is enough.

This reverts commit 81239246.

This should have gone to a branch, not to master. Reverting it until it
gets reviewed properly.

Unlike what the ticket suggests, it takes concrete origin parameter, not
some yet unknown config value, for two reasons:
 * The format of config is not known.
 * Leaking some details about what memory segment or whatever is being
   used for the cache through the interface looks like a bad idea. Even
   leaking the existence of the cache is enough.