GitLab

This patch has been proposed by Alexis Fidalgo. It was earlier reported
that Kea always appends a dot at the end of the hostname which may cause
some clients to fail on processing this option.

The new tests are implemented using the Dhcp4Client class. It has been
found that the server returns DHCPNAK in response to DHCPDISCOVER which
was wrong. Now, the server doesn't respond to DHCPDISCOVER if it can't
find an address. As a result, a number of tests had to be fixed which
relied on this invalid behavior.

One of the major changes was to eliminate possibility of defining the dead
reservation: neither hostname nor IP address reserved and covering it with
suitable unit tests.

 - (offset - 4) explained better
 - Modified Dhcpv6Srv::unpackOptions()
 - setHWAddrMember() mac_addr renamed (this time for real)
 - Commented out unused variables
 - RelayInfo now uses DEFAULT_ADDRESS6 in ctor
 - LibDHCP::unpackOptions6 and callback now used uniformly
 - Clarified that ERO is Echo Request Option (RFC4994)
 - unpackOptions4 in libdhcp and Dhcp4Srv no longer throw when
   truncated option is received.

The modifications to the staging configuration are performed on the pointer
returned by getCfgOptionDef.