GitLab

discussed on jabber

also renamed IDENTIFIER_PARAM to CFGITEM_IDENTIFIER_PARAM

- rename BindCmdParse to BindCmdParser
- rename 'cmd' in tests to 'cmd_parser' (if used as BindCmdParser)
- cut off long lines according to style guide

removed all word-boundary values except whitespace (so that we no longer have to to magic to replace things around the / character, and other possible characters used in identifiers)

Pulled out the identifier-hints collection (and added tests for those)

This reverts commit 6a9dbeff.

Most builder systems use Python 3.1.

This verbosity feature was added in Python 3.2.

It's shocking how much is not tested here. No surprise the missing
command was not discovered. Still, not adding tests for the others,
they'd probably fail and it would make the ticket a lot bigger.

make the initial if>2 part of the while
also add a space when glueing extraneous arguments together

I had not noticed the -p option, which doesn't really make sense and should perhaps be removed, but that one actually does work with relative paths, so the original 'fix' was bad

Not directly related to this ticket, but master recently create a
private version of library test class this branch already has.

If we ask python to import module.submodule, it gets the first module/
directory with __init__.py in it. This is a problem if our module
(actually bindctl program) has some generated and some ready files.

So this uses the module.submodule only for the not generated ones, and
has module/ directly in path for the generated (we import submodule, not
module.submodule). This is only in the test.

For testing purpose I also renamed bindctl-source.py to bindctl_main.py.
I needed to replace dash with underscore to use it in an import statement,
and _main seemed to better explain what it is than _source, so I also
renamed that part.

this options allows the user to change the directory that stores the user/pass
CSV file.  it's mainly intended for the covenience of tests.

In order for it to distinguish between separate arguments, it should now
remove whitespace in lists and maps (i.e. between [] and {}), unless
data is quoted

actually just the first part of it

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac289@2730 e5f2f494-b856-4b98-b285-d166d9295462

added 'have_specification()' to MultiConfigData class
+tests of course
although bindcmd seems to be lacking much in the test department... (fitted it kinda-sorta into bindctl_test right now)


git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac99@2643 e5f2f494-b856-4b98-b285-d166d9295462

   Command parser only do minimal check. now parameter value can be a sequence of non-space characters, or a string surrounded by quotation marks(these marks can be a part of the value string in escaped form)
   Make error message be more friendly.(if there is some error in parameter's value, the parameter name will be provided)
2. Refactor function login_to_cmdctl() in class BindCmdInterpreter.
   Avoid using Exception to catch all exceptions.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/trac220@2108 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1960 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1646 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1439 e5f2f494-b856-4b98-b285-d166d9295462

1. Refactor the function get_param_name_by_position of class CommandInfo, add add some unittest for it.

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@990 e5f2f494-b856-4b98-b285-d166d9295462

2. Add login idle timeout for cmdctl, default idle time is 1200 seconds.
3. Refactor some code for cmdctl.

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@961 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/parkinglot@609 e5f2f494-b856-4b98-b285-d166d9295462