GitLab

using reorder_message_file.py tool

Added output redirect operator "<<" to Lease class so new unit tests in
libdhcpsrv will compile under gtest 1.5.
Also fixed incorrect index into lease collection for same tests.

Suppressed an unused structure member complaint in dhcpsrv/psql_lease_mgr.cc
This code is going to get a makeover under 3382 and it will be more properly
addressed then.

PgSqlLeaseMgr::openDatabase now sets conn_ to NULL after calling PQfinish.
PgSqlLeaseMgr constructor, moved member inits to the initializer list
Fixed exception text.

The procedure for configuring Postgresql backend in bind10-guide
was updated such that database tables are created and thus owned
by the Kea user rather than the postgres user.

Cleaned up some logging issues and minor cosmetics.

    Changed the SQL statements used to retrieve data to be simple selects
    rather than declared as cursors.  This allows the selects to be executed
    with a single statemen execution, eliminating the need for BEGIN and END
    blocks.

    Other minor clean up.

Initial review and testing revealed build issues, unit test failures,
and memory leaks.  With these changes it should build and pass unit testing.
There are still runtime issues to address.

Changed expire column type in lease tables to be "TIMESTAMP WITH TIME ZONE",
and added methods to convert to and from such fields to LeaseExchange. This
corrects mismatched time conversion to and from database which was causing unit tests to fail.

Added constructors to PgSqlParam to eliminate use of ".value" initializers and
to provide a safe, uniform way to create parameters for binary data. Prior to
this valgrind was reporting invalid reads when vectors were statically cast
to char*.

Removed superflous BOOST_STATIC_ASSERT and corrected values tested in remaining
check.

Removed use of "SET AUTOCOMMIT TO" as it is no longer supported in PostgreSQL.

Altered failure logic in PgSqlLeaseMgr::openDatabase() to release connection
if it is not NULL. This was causing memory leak in unit tests.

Added PQfinish call to createSchema() function to release the connection to fix
memory leaks during unit testing.

Cleaned most cppcheck complaints.

Added use of boolean structs for fdqn unit tests for clarity.
Minor cosmetics.

Added the constant D2ClientConfig::DFT_ALWAYS_INCLUDE_FQDN

Added a method to ValueType<> template, getOptionalParam.
Defined constants for dhcp-ddns default values in D2ClientConfig.
D2ClientConfigParser uses these in conjuction with calls to
ValueType<>getOptionalParam() to ensure all the parameters needed
have values.
Modifed unit tests accordingly.

 - UPDATE_LEASE6 query is now working
 - Added bunch of new unit-tests

Failing to initialize all values causes valgrind errors.