GitLab

 - unknown message log added
 - comments fixed

Changed pack() methods for both DHCP4 and DHCP6 packets to
throw exceptions on failure, rather than return bools.

This change provides a template "CalloutHandle store" for use in the
DHCP servers.  It replaces server-specific methods and adds the ability
to clear the stored pointers.

This function is empty now, so it needs to be implemented.

- callouts called using HooksManager::callCallouts
- removed Dhcp6Srv::getServerHooks() and getHooksManager() declarations.
- updated sendPacket comment (reception->transmission)
- documented getCalloutHandle()
- indentation fixed for getSubnets6()

 - pkt6_receive, subnet6_select, lease6_select, pkt6_send
 - framework updated
 - some unittests implemented

The variable is in larger scope because it is used as a constant, so
it's at the top of the function.

mostly in documentation or in comments

reviewed by muks via jabber

includes output changes for two isc_throw.

reviewed by jelte via jabber.

Changes some log message descriptions and some
function arguments and some output.

The selectSubnet() function offers two ways to find a subnet for a
particular interface: using the name of the interface that the subnet is
configured for; and using the packet source address. Also, the redundant
warning is removed if suitable subnet was not found as this warning is
already issued elsewhere.

Explicit allocation failures cause the return of packet to the client
indicating that the address allocation has been refused.  Also added
was a "catch" for other exceptions - this causes the packet from the
client that generated the exception to be ignored.

The previous commit disabled unused parameter warnings in the DHCP
code  when compiling with clang.  g++ picked up some additional
warnings/errors, and this fix corrects those.