GitLab

Also, included FQDN fields in the MySQL script creating database.

Changes:
 - hwaddr.h - added MAX_HWADDR_LEN
 - hwaddr.cc - modified constructor to throw InvalidParameter
            if input address is too big
 - hwaddr_unittest.cc - added tests for new constructor throws

 - lease_mgr.h - removed HWADDR_MAX
 - mysql_lease_mgr.cc - added logic to set SQL mode to STRICT
 - tests/mysql_lease_mgr_unittest.cc - modified tests that were
    failing on STRICT mode, to expect exceptions.

The include path for MySQL includes is accurately set by mysql_config.

Some slight grammar changes.
Mostly in comments, but some for api docs.
Changes a isc_throw output too.

Reviewed via jabber.

Half-related change, if available, call mysql_library_end() at the end of the unit test run

the mysql lease manager wouldn't close the mysql database immediately if initialization failed at certain points.

This proposed fix is not entirely complete; it would probably be better to either use such a holder class as the member, or to slightly clean it up so that the return value from release() can be given to mysql_ (and therefore use the holder in the construction code instead of mysql_), but I did not want to touch too much existing code at this point.

Also make the hardware address to string function common to both
database modules.

As the address is th eprimary key of the table, there can only ever
be at most one lease in the database with a given address.  Additional
selection by subnet ID is not needed.

cppcheck was complaining about what was effectively:
const int A = 6; const int B = A; std::string array[b];

Changing this to
const int B = 6; std::string array[b];

... works

Including:
* Updates to comments etc.
* Addition of Lease4::operator==() (and associated unit tests)

* Corrections of miscellaneous typos in comments
* Update database version to 1.0
* Handling of truncation while fetching data from the database

Also, included dhcpsrv in the list of directories searched by Doxygen.

Add ability to select IPv4 leases by address and Subnet ID.

Parameters are hard-coded for the moment.

... to ensure that it is always called when a method terminates.