A call to HooksManager::getHooksManager().unloadLibraries() was added to
the destructors Dhcpv4Srv::~Dhcpv4Srv() and Dhcpv6Srv::~Dhcpv6Srv(). This
ensures hook libraries are unloaded prior to static objects.

- No additional check for HR mode in findReservations
- Additional commentary in the loop collecting host ids.

    Moved string/enum conversion functions inside D2ClientConfig

    Changed underscores to hypens in replace-client-name values and changed
    all literal values to lower case.

    Fixed minor wording issues in admin guide and new log messages.

    Added commentary and extra error logging to unit tests

    Added test case for invalid value of replace-client-name

    src/bin/dhcp4/dhcp4_messages.mes
        - Added new log message DHCP4_SUPPLY_HOSTNAME

    src/bin/dhcp4/dhcp4_srv.cc
        - Dhcpv4Srv::processClientName() - pushed lack of host option in the
        client request down into processHostoption()

        - Dhcpv4Srv::processHostnameOption() - modified to support the new name
        replacement modes

    src/bin/dhcp4/tests/fqdn_unittest.cc
        - NameDhcpv4SrvTest:: testReplaceClientNameMode() - new method which
        tests a server's handling of a single client packet for a given
        replace-client-name mode.

        - TEST_F(NameDhcpv4SrvTest, replaceClientNameModeTest) - new test which
        exercises the permutations of client packets and replace-client-name
        modes.

    The D2 client configuration parameter, replace-client-name, was
    changed from a boolean, to an enumerated list of modes:

        "NEVER" - do not alter or supply the client name
        "ALWAYS" - always replace the client name, or supply it if
         not sent by the client
        "WHEN_PRESENT" - replace the client name sent by the client,
         do not supply one otherwise
        "WHEN_NOT_PRESENT" - supply the client name only if one was
        not sent by the client

    src/lib/dhcpsrv/d2_client_cfg.cc
    src/lib/dhcpsrv/d2_client_cfg.h
        Added the D2ClientConfig::ReplaceClientNameMode enumeration.

    src/lib/dhcpsrv/parsers/dhcp_parsers.cc
        - Alter replace-client-name parsing to parse the mode labels.
        - Maps boolean literals true and false to RCM_WHEN_PRESENT and
        RCM_NEVER respectively

    src/bin/dhcp4/dhcp6_srv.cc
    src/bin/dhcp4/dhcp4_srv.cc
    src/lib/dhcpsrv/d2_client_mgr.h
        - Adapted to use the enumeration

    src/bin/dhcp4/tests/config_parser_unittest.cc
    src/bin/dhcp4/tests/fqdn_unittest.cc
    src/bin/dhcp6/tests/config_parser_unittest.cc
    src/bin/dhcp6/tests/fqdn_unittest.cc
    src/lib/dhcpsrv/tests/cfgmgr_unittest.cc
    src/lib/dhcpsrv/tests/d2_client_unittest.cc
    src/lib/dhcpsrv/tests/d2_udp_unittest.cc
    src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
        - Alter existing tests to use the enumeration. Note false was replaced
        with RCM_NEVER and true with RCM_WHEN_PRESENT

src/bin/dhcp4/dhcp4_messages.mes
    - Replaced the word "debug" with "informational" where appropriate

src/bin/dhcp4/dhcp4_srv.cc
    - Changed several lease4_logger messages from DEBUG to INFO
    DHCP4_INIT_REBOOT
    DHCP4_LEASE_ADVERT
    DHCP4_LEASE_ALLOC
    DHCP4_RELEASE
    DHCP4_DECLINE_LEASE

src/bin/dhcp6/dhcp6_messages.mes
    - Replaced the word "debug" with "informational" where appropriate

    - Added two new messages:
    DHCP6_LEASE_RENEW
    DHCP6_PD_LEASE_RENEW

src/bin/dhcp6/dhcp6_srv.cc
    - Changed several lease6_logger messages from DEBUG to INFO
    DHCP6_LEASE_ADVERT
    DHCP6_LEASE_ALLOC
    DHCP6_PD_LEASE_ADVERT
    DHCP6_PD_LEASE_ALLOC
    DHCP6_RELEASE_NA
    DHCP6_RELEASE_PD
    DHCP6_DECLINE_LEASE

    - Dhcpv6Srv::extendIA_NA() - added new log for DHCP6_LEASE_RENEW
    - Dhcpv6Srv::extendIA_PD() - added new log for DHCP6_PD_LEASE_RENEW

Optimization of boost:asio code is now disabled when building with
BOOST_ERROR_CODE_HEADER_ONLY under GCC versions 5.2.0 through 5.3.0.

src/lib/asiolink/asio_wrapper.h
    New file which wraps boost/asio/asio.hpp around compilation
    logic to suppress optimization under GNU 5.2.0 thru 5.3.0.

The remaining changes either removed the inclusion of <asio/asio.hpp> or
replaced it with the inclusion of <<asiolink/asio_wrapper.h>.  Inclusion
file order was also altered to better comply with our coding guidelines.

JINMEI Tatuya authored Nov 01, 2015 and Tomek Mrugalski committed Feb 22, 2016

also folded a too long line.

JINMEI Tatuya authored Nov 01, 2015 and Tomek Mrugalski committed Feb 22, 2016

the new one is named processPacket().  this is a trivial refactoring,
intentionally not making any other editorial cleanups (such as indentation
fixup).

This change triggered a lot of code refactoring for generating the
NameChangeRequests. Long story short is that the functions responsible
for generating NCRs from the lease information have been moved to
the libdhcpsrv where they better fit and where they may be used
by both allocation engine and the servers.