GitLab

update the test case and log message accordingly.

the users of this method only need the set behavior, and the previous code
actually didn't swap them as expected anyway.

they are not expected to be copied, and I actually had a bug due to an
accidental copy.  Making it non copyable will help avoid such bugs.

auth_srv test's clientList tests are now converted to clients manager's test.
("holder" tests).

this will help corner case considerations of it being NULL

A few more checks in test
cleaned up added headers
reordered log message file

from AuthSrv:: (in auth_srv.h) to isc:datasrc:: (in client_list.h), the previous location wasn't really relevant now that it is used elsewhere, and this seemed the most logical location

by a bit ugly hack: we specialize some part of the destructor and make
a local copy of these variables so the tests can inspect them later.

also explicitly reject invalid command ID, which should be internal bug.

mainly for better readability.  no functional change.

on second thought I realized we need to synchronize them because the builder
thread refers to the main thread's class member variables.
shutdown() method is now meaningless so deprecated for now.

we'll use this pattern for other commands.