GitLab

Some of the unit tests had to be modified after this change. This is
because they used to create options which data length did not match the
actual std options' formats.

... as this class is going to be used either for V6 or V4 now.

This reverts commit 3f9c7bb8.

This issue was detected post-merge, and seems to have been introduced
by commit 86ed7ae9 in master.

This has a chance that some log messages get lost (DEBUG messages during startup in case -v is not given but the config has DEBUG set)

this will suppress a cppcheck error:
http://git.bind10.isc.org/~tester/builder//BIND10-cppcheck/20121209143001-FreeBSD8-amd64-GCC/logs/cppcheck.out

okayed on jabber.

by encapsulating the appender in SharedAppenderPtr immediately after the
creation, we can make sure buffer_appender1 won't leak even if the
creation of the second appender fails.

- renamed test class
- added a subclass of BufferAppender to directly test append()
(and re-enabled the relevant test case)
- minor doxy updates

And use those in the case of flushStdout() upon destruction

Since LogBuffer no longer exists, the file name did not match its content anymore

and pull its functionality into BufferAppender
(one unit test temporarily disabled, might be removed in next commit or updated to get around the protected method it uses)

cppcheck was complaining about what was effectively:
const int A = 6; const int B = A; std::string array[b];

Changing this to
const int B = 6; std::string array[b];

... works

This reflects the fact that at the moment, the data is stored in
memory and not in a backing file.

LogBuffers are now members of BufferAppender instances, and the singleton has been removed. LoggerManagerImpl keeps them (if any) around while processing a new specification, and flushes them when done.

- update README
- copy vector of event on flush
- only use very basic functions in case of flush-on-destruct

To prevent accidental outside use, all LogBugger (and BufferAppender) code is in the namespace isc::log::internal now, and the files have been renamed to _impl