GitLab

Addressed a myriad of minor typos and wording issues.

modified:
ChangeLog
doc/examples/kea4/all-keys.json
doc/examples/kea6/all-keys.json
doc/sphinx/arm/dhcp4-srv.rst
doc/sphinx/arm/dhcp6-srv.rst
src/bin/dhcp4/dhcp4_srv.cc
src/bin/dhcp4/tests/config_parser_unittest.cc
src/bin/dhcp4/tests/fqdn_unittest.cc
src/bin/dhcp6/tests/config_parser_unittest.cc
src/bin/dhcp6/tests/d2_unittest.cc
src/bin/dhcp6/tests/fqdn_unittest.cc
src/lib/dhcpsrv/alloc_engine.cc
src/lib/dhcpsrv/alloc_engine.h
src/lib/dhcpsrv/d2_client_cfg.h
src/lib/dhcpsrv/parsers/base_network_parser.cc
src/lib/dhcpsrv/srv_config.h

src/bin/dhcp4/tests/get_config_unittest.cc
src/bin/dhcp6/tests/get_config_unittest.cc
    regenerated tests

src/lib/dhcpsrv/parsers/simple_parser4.cc
    Removed DDNS params from INHERIT_TO_SUBNET4 list

src/lib/dhcpsrv/parsers/simple_parser6.cc
    Removed DDNS params from INHERIT_TO_SUBNET6 list

src/bin/dhcp6/tests/fqdn_unittest.cc
    TEST_F(FqdnDhcpv6SrvTest, ddnsScopeTest)  - new test

src/bin/dhcp6/ctrl_dhcp6_srv.cc
    Removed setting D2ClientCfg fetch function

src/bin/dhcp6/dhcp6_lexer.ll
src/bin/dhcp6/dhcp6_parser.yy
    ddns-send-updates
    ddns-override-no-update
    ddns-override-client-update
    ddns-replace-client-name
    ddns-generated-prefix
    ddns-qualifying-suffix
    - added to DHCP4,SHARED_NETWORK,SUBNET4

    hostname-char-set
    hostname-char-replacement
    - added to SHARED_NETWORK,SUBNET4

src/bin/dhcp6/dhcp6_srv.cc
    Dhcpv6Srv::processClientFqdn()
    Dhcpv6Srv::createNameChangeRequests()
    Dhcpv6Srv::updateReservedFqdn()
    - use cxt.getDdnsParams()

src/bin/dhcp6/json_config_parser.cc
    configureDhcp6Server()
    - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
    - handle new "ddns-" globals

src/bin/dhcp6/tests/config_parser_unittest.cc
src/bin/dhcp6/tests/fqdn_unittest.cc
src/bin/dhcp6/tests/get_config_unittest.cc
    Updated tests

src/bin/dhcp4/ctrl_dhcp4_srv.cc
    Removed setting D2ClientCfg fetch function

src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    ddns-send-updates
    ddns-override-no-update
    ddns-override-client-update
    ddns-replace-client-name
    ddns-generated-prefix
    ddns-qualifying-suffix
        - added to DHCP4,SHARED_NETWORK,SUBNET4

    hostname-char-set
    hostname-char-replacement
        - added to SHARED_NETWORK,SUBNET4

src/bin/dhcp4/dhcp4_srv.cc

    Dhcpv4Srv::processClientFqdnOption()
    Dhcpv4Srv::processHostnameOption()
    Dhcpv4Srv::assignLease()
        Use scoped DdnsParams from context to make decisions, pass
        into D2ClientMgr functions, and supply hostname sanitizer

src/bin/dhcp4/json_config_parser.cc
    configureDhcp4Server()
    - use SrvConfig::moveDdnsParams() to move dhcp-ddns parameters
    - handle new "ddns-" globals

src/bin/dhcp4/tests/config_parser_unittest.cc
src/bin/dhcp4/tests/d2_unittest.cc
src/bin/dhcp4/tests/dhcp4_test_utils.cc
src/bin/dhcp4/tests/fqdn_unittest.cc
src/bin/dhcp4/tests/get_config_unittest.cc
    Updated and new tests

[914-move-to-c-11-thread-library-in-core-library-code] Upgraded thread/mutex code in the core library to C++11

[168-config-manager-clear-does-not-clear-the-d2-client-config-full-clear] Fixed unit tests using previous CfgMgr clear() behavior

    src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
        Cleaned up failure text

    src/lib/testutils/gtest_utils.h
        Replaced array with vector

src/bin/dhcp4/dhcp4_srv.cc
    Dhcpv4Srv::processRequest()
    Dhcpv4Srv::processRelease()
    Dhcpv4Srv::processDecline()
    Dhcpv4Srv::processInform() - now all call sanityCheck()

src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
    TEST_F(Dhcpv4SrvTest, sanityCheckDiscover)
    TEST_F(Dhcpv4SrvTest, sanityCheckRequest)
    TEST_F(Dhcpv4SrvTest, sanityCheckDecline)
    TEST_F(Dhcpv4SrvTest, sanityCheckRelease)
    TEST_F(Dhcpv4SrvTest, sanityCheckInform) - new tests

src/lib/testutils/gtest_utils.h
    New file with handy new test macros:
        EXPECT_THROW_MSG()
        ASSERT_THROW_MSG()

src/lib/testutils/Makefile.am
    Added new file gtest_utils.h

Added a ChangeLog entry

This checks that selected packet statistics is set to 0 before the test.

[755-Kea-DHCP-servers-observations-should-be-reset] implement required changes to dhcp4 and dhcp6 servers

[755-Kea-DHCP-servers-observations-should-be-reset-to-some-initial] changes to way of initial values

[755-Kea-DHCP-servers-observations-should-be-reset-to-some-initial-values-upon-restart-or-reconfiguration] add initialization of all statistisc during set up

src/bin/admin/kea-admin.in
    Fixed printfs

    mysql_can_create() - removed logic to
    skip test based on MySQL version.

src/bin/admin/kea-admin.in
    mysql_can_create() - new function to verify user's ability
    to create functions

    mysql_init()
    mysql_upgrade() - modified to call mysql_can_create

src/bin/admin/tests/mysql_tests.sh.in
    Updated expected column names
    Added check of column names for 8.0 to 8.2 upgrade

src/share/database/scripts/mysql/dhcpdb_create.mysql
    Changed array column to is_array in dhcp4/6_option_def tables

src/share/database/scripts/mysql/dhcpdb_drop.mysql
    Added missing drops for createOptionAuditDHCP4/6

src/share/database/scripts/mysql/upgrade_6.0_to_7.0.sh.in
    Changed array column to is_array in dhcp4/6_option_def tables

src/share/database/scripts/mysql/upgrade_8.1_to_8.2.sh.in
    Added logic to conditionally change column names

Declined leases are expected to have neither hardware address nor client
id.  All others have must have at least one of them.

src/lib/dhcpsrv/csv_lease_file4.cc
    CSVLeaseFile4::append() - throws if a lease has no hardware address,
    no client id and is not in STATE_DECLINED

    CSVLeaseFile4::next(Lease4Ptr& lease) - discards rows if they have
    neither hardware addr nor client id and are not in STATE_DECLINED

src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
src/bin/lfc/tests/lfc_controller_unittests.cc
    Updated tests.