GitLab

- use <xxx.h> instead of <cxxx> (e.g. use stdlib.h instead of cstdlib)
- avoid using variable length array
as for the first point, it didn't make sense that cxxx didn't work and we may
want to look into it further to understand the real cause.  but since this has
been breaking build, and it somehow fixes the issue, I'll apply it for now.

okayed on jabber.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3188 e5f2f494-b856-4b98-b285-d166d9295462

For one, many builtin functions do this (memcpy, read, etc). And, it
would be more correct to use unsigned char * (because of aliasing
rules), but that makes C++ unhappy when passing string literals there.

Got rid of -fno-strict-aliasing in sockcreator tests.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3186 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3176 e5f2f494-b856-4b98-b285-d166d9295462

* Some of the code might be useful in other places, so it is split into
  libraries (isc::util::io and isc::util::unittests).
* Fixing flags in the sockcreator, leading to new warnings, fixing these
  warnings.
* TODO: read_data and write_data were tested implicitly with run(), but
  as they moved out to other library, they should have their own
  testcase.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3163 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3162 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3161 e5f2f494-b856-4b98-b285-d166d9295462

The rest of code seems to have space between if/while and the
parenthesis.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3160 e5f2f494-b856-4b98-b285-d166d9295462

And fixed a test. It seems underlaying bind does not like passing NULL
pointer as address and kills program with sigterm.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3159 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3148 e5f2f494-b856-4b98-b285-d166d9295462

To be able to live without short reads. Needed by tests as well.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3147 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3146 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3145 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3122 e5f2f494-b856-4b98-b285-d166d9295462

Only empty functions, so it compiles at last.

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3121 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/branches/vorner-sockcreator@3120 e5f2f494-b856-4b98-b285-d166d9295462