GitLab

Perfdhcp can be used with option -l to specify the local address to be
used.

However, when this option is used on a secondary address of an
interface, this doesn't work correctly.

The packets are sent with:
- giaddr = adresse specified (correct)
- source ip address = the interface primary IP address

Here is a patch that correctly sets the source IP address before sending
the packet.
This allows to launch multiple perfdhcp processes at the same time,
sharing the same interface but each using a distinct IP address.

 - ChangeLog updated
 - applyDefaultConfiguration() removed
 - couple unit-tests renamed
 - comments added for code that uses TEST_DATA_TOPBUILDDIR
 - copyright years updated
 - one function moved: logger_unittest_support.cc => logger_support.cc

The modifications to the staging configuration are performed on the pointer
returned by getCfgOptionDef.

This change affects many files using the Configuration object and types
derived from it.

Comments have been improved in one file.  The other contains a test
that alters logging, so a test fixture has been added that ressets
the logging back to the default in its destructor.

 - KEA_LOCKFILE_DIR_FROM_BUILD renamed to KEA_LOCKFILE_DIR.
 - KEA_FROM_BUILD_LOCALSTATEDIR, KEA_LOCKFILE_DIR_FROM_BUILD removed
 - It is possible to disable lockfile now

Some unit tests in dhcpsrv altered the logging configuration but
never reset it. That configuration was then used for subsequent
tests and made them overly verbose.

Previously, the logger configuration was applied (to log4cplus) as soon as
it was parsed. We decided in the jabber discussion that the logger
configuration should only be applied if the whole configuration goes
through. So, the logger configuration is now 2-stage: parsing and commit
as for other configuration parameters.