GitLab

not really useful at this point anymore

It isn't actually used by the test, but by not setting any db, the default db would've been created (and not cleaned up, making distcheck fail for leaving files around)

i.e. jinmei's patch, see http://bind10.isc.org/ticket/1207?replyto=15#comment:15

note that this is mostly a way to at least get it working, we need to figure out a more permanent solution related to static linking (or stop supporting it in the first place)

The removal of memory_datasrc.cc in b10_auth_SOURCES was premature; zone loading code is still in auth (but memory_datasrc-specific)

Which is now no longer necessary

instead of fighting the API to get empty zones in, actually change the zone in the database and reload

- RAII InMemoryClient's createInstance
- remove dead code
- added more comments

and store it as a scoped ptr

- fixed a few include statements
- amended a few comments

it is no longer necessary to derive it from InMemoryClient, but it can be directly derived from DataSourceClient

The special case is still there, but it's been moved into the general DataSourceConfig class; this makes later generalization easier.

It also allowed the removal of the specialized createAuthConfigParser (the overloaded version with the 'internal' argument), and the special case therein.

See http://bind10.isc.org/ticket/1207#comment:11

The temporary name with the added P is no longer necessary now the original method has been removed.

Made the getZoneCount() method from inmemory client a general datasource client
call (which throws NotImplemented by default), as this does seem useful in other
 cases as well.

Now the work starts to pay off; removed the temporary pointer variable (getInMemoryClientP() still returns a pointer but now directly retrieved from the container), and any direct reference to isc::datasrc::InMemoryClient is removed from au
th_srv (but not from tests as of yet)

Instead of the direct shared_ptr.

Changes needed:
Moved loading of zones in config into the memory_datasrc implementation; at this moment the general API has no method for this (and it may not be necessary; datasources should handle their own config anyway).
This does have one drawback; through the dynamic loading mechanism we currently lose exception type information. So for now specific exceptions such as MasterLoadError end up as 'general' DataSourceErrors. Tests have been updated to reflect this.

Also, I made config handler slightly more lenient; it has hardcoded defaults and will now accept config parts without "class" or "zones"; using .spec -derived values is impractical here with the current config API, but in this case it shouldn't *really* matter; as IN is hardcoded in several places anyway atm.

(temporarily)
In order to add datasource factory, but keep current code working, store both the shared ptr (for reference counting) and the raw pointer it encapsulates. The latter is then used to call query::process().

not directly related to this branch, but the review comment on this point
for the previous change should actually apply to this.

The run_unittests should be linked only if it is compiled. Confirmed on
jabber this was a mistake.

The old version is a result of copy-paste and is wrong.

The values are deduced from something else, no need to keep them. This
eliminates the ugly initialization with wrong values.

We have camelCase in many places, but variable names are not one of
those.

It is now placed into the getZoneConfig method. This is code cleanup
only, functionality should not be changed.

previous commit had a mangled tab due to a copy-paste error from the original diff

So that the sqlite3_ds.so is found correctly
This has been acked on jabber, and is tentatively waiting full resolution in ticket #1895

Checking various error modes, like unreadable database, wrong or missing
configuration.

It now looks into the configuration and checks if the zone should be
loaded from the sqlite3 data source instead of the text file.

It puts the configuration of the zone (which is loaded from SQLite3
database) and the database at the disposition of the test. Then it asks
it to load the zone and it expects it to load it.

it creates a temporary SQLite3 DB file from a shared template with a specified
stream of zone data.  this will help reduce the number of pre-generated DB
files in the repository (which will be subject to upgrading the schema).

for optional items setting the default doesn't make sense, but we also have
test cases where syntax validation is skipped, so changing it to non-optional
will break existing test cases.  at least for now, it seems to make most sense
to keep it optional and define the default within the parser code.