GitLab

--- log message follows this line ---
[trac698] added a test case "test___del__",
which tests __del__ function in cases that fake_session is still opened and that it has been already closed.

it raises SessionError if the session has been already closed.

in order to distinguish from the other parameter "_closed".

add the missing member variable to the fake class (FakeModuleCCSession)

If the CC Session obejct has been closed, it returns immediately.

--- log message follows this line ---
[trac698] add a new entry

This branch removed the shared pointer that the NSAS used to link
to the resolver.  As a result we now have to make sure that the
resolver stays in existence while the NSAS is active.  This commit
fixes that problem in a unit test.

Conflicts:
	src/lib/resolve/recursive_query.cc

Conflicts:
	ChangeLog
	configure.ac
	src/bin/bind10/tests/bind10_test.py.in

.stop() followed directly by .reset() doesn't work. It seems asio has a
"can run" boolean variable, stop sets it to false, reset to true, so if
they are both called from inside the .run() main loop, it does nothing.

Without this it cannot use privileged port (most commonly 53) while changing
the run time user (-u).  Confirmed the fix, and okayed on jabber.

I won't update changelog for this fix because it's a regression after
the previous release.

Reverted ZoneEntry to the original version and added the destructor
to TestResolver to call all the saved callbacks.  This breaks
internal shared_ptr loops, allowing the NSAS to destoy itself
gracefully, and avoiding memory leaks.

Previously when compiled without NDEBUG set it did, if a check
failed it called assert().  The tests checks for this using
ASSERT_DEATH.  However, ASSERT_DEATH leaks memory and this was
obscuring the valgrind output.  The changes here cause an exception
to be thrown (instead of a call to abort()) in the case of an error
and the unit tests now EXPECT_THROW instead of ASSERT_DEATH.

The ZoneEntry object was creating a callback and keeping a shared
pointer to it, but the callback was also using a shared pointer to
link back to the ZoneEntry.  This change removed the shared pointers
in the callback objects - they now use a "raw" pointer to point back
to the ZoneEntry.