GitLab

skipping review.  build/test okay.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1735 e5f2f494-b856-4b98-b285-d166d9295462

while reviewing actually)
prepend output to stdout with "[bind10]"
replaced tabs with spaces on one line
removed one unneeded \ at the end of a line


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1730 e5f2f494-b856-4b98-b285-d166d9295462

2. Minor fix to the xfrin.

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1729 e5f2f494-b856-4b98-b285-d166d9295462

- remove an unnecessary temporary variable to shorten a method
- use RRClass instead of Query when the former suffices to reduce dependency

build/tests okay, no behavioral change.  skipping explicit review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1728 e5f2f494-b856-4b98-b285-d166d9295462

commented out for now, will open a ticket.  so skipping review this time.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1727 e5f2f494-b856-4b98-b285-d166d9295462

- more consitify
- avoid using C-style cast
- combine two short lines

build/tests okay.  skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1725 e5f2f494-b856-4b98-b285-d166d9295462

- follow coding guidelines
- use anonymous namespace instead of file-static functions
- constify as much as possible.

build and tests are okay (basically no behavioral change), commiting to trunk skipping review.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1724 e5f2f494-b856-4b98-b285-d166d9295462

(I reviewed.)

For Makefile.am, revert my previous change.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1723 e5f2f494-b856-4b98-b285-d166d9295462

corrected test data path handling: it should have checked rbegin(), not rend(), to see if the given path ends with '/'.

I believe this is pretty trivial so I'm committing this to trunk directly.  it compiles and passes tests (in fact without this some tests may not pass, depending on environments).


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1722 e5f2f494-b856-4b98-b285-d166d9295462

(so is included in tarball).
Also sorted a couple entries.

This was not reviewed. But is minor.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1714 e5f2f494-b856-4b98-b285-d166d9295462

applied the same fix as r1709 and r1710.  This will make it possible to run tests in a separate build tree.  (trac ticket #143)

also applied the DRY principle to unittest_util*: remove the local copies and simply referred to the dns/tests versions of these files.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1713 e5f2f494-b856-4b98-b285-d166d9295462

I also sorted them so later it will be easier to recognize changes.
(Sanity checked by jinmei.)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1712 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1710 e5f2f494-b856-4b98-b285-d166d9295462

made test data paths dynamically configurable with the default path of @srcdir@/testdata.  This will allow testdata to be referred to from a non-src build directory.

We can also specify mulitiple directories, which may happen if we generate some data files from spec at build time and run tests under a non-src directory.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1709 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1708 e5f2f494-b856-4b98-b285-d166d9295462

cleanup: construct RRClasses from integer rather than strings when how to construct them doesn't matter.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1707 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1706 e5f2f494-b856-4b98-b285-d166d9295462

cleanup: use relative path to header files from "src/lib", i.e., s/"name.h"/<dns/name.h", etc.  also removed unnecessary header files to be included.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1705 e5f2f494-b856-4b98-b285-d166d9295462

test cases and documentation were also fully provided.

(this changeset includes a minor unrelated cleanup: move the pimpl structure
 inside the MessageRenderer class declaration to clarify the intent)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1704 e5f2f494-b856-4b98-b285-d166d9295462

something else).

Regen man pages.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1703 e5f2f494-b856-4b98-b285-d166d9295462

Regen man version.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1702 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1701 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1700 e5f2f494-b856-4b98-b285-d166d9295462

- constify as much as possible


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1699 e5f2f494-b856-4b98-b285-d166d9295462

(revision of r1690, in response to a comment on trac ticket #140)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1698 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1697 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1696 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1695 e5f2f494-b856-4b98-b285-d166d9295462

 - pass xfr request data length in network byte order, and receive it as such. receiving this as native data (unpack('H')) would be a bit naive because it may assume some padding.
 - avoid cast as a bonus side effect of the first fix
 - make cmsg space handling more portable.  use CMSG_SPACE when possible; otherwise calculate the space using dummy data
 - overall simplied fd_share code: trying to handle multiple FDs is not correct in terms of API, and in any case we don't need that; verify cmsg_level and cmsg_type on reception; avoid unnecessary data initialization; stop naively assume the exact memory allocation of cmsg_data (assuming no padding) - use cmsg_space() so that padding, if any, will be taken intou account
 - catch the error case of recv_fd failure in XfroutSession.handle() explicitly, and raise an exception


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1694 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1693 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1692 e5f2f494-b856-4b98-b285-d166d9295462

- style fixes according to bind10 coding guideline
- constify things
- propset


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1691 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1690 e5f2f494-b856-4b98-b285-d166d9295462

of the boss process with any additional specific variables given
on construction (self.env) of ProcessInfo.


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1689 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1688 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1687 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1686 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1685 e5f2f494-b856-4b98-b285-d166d9295462

cleanup: eliminated the need for isc.auth.sqlite3_ds.AXFRInDB by directly calling sqlite3_ds.load() from the xfrin module.

Other cleanups:
- cosmetic: removed redundant blank lines and white spaces after EOL
- grammar fix in comments
- catch Sqlite3DSError explicitly (but I suspect the exception handling
  in the xfrin module is naive overall, which should be fixed)


git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1684 e5f2f494-b856-4b98-b285-d166d9295462

git-svn-id: svn://bind10.isc.org/svn/bind10/trunk@1683 e5f2f494-b856-4b98-b285-d166d9295462