GitLab

use a simpler select to check for column existence rather than
functions and procedures that may wind up in the database after the upgrade

Changes were cosmetic, no fucntional changes required.

Modified:
doc/sphinx/arm/dhcp4-srv.rst
src/bin/dhcp4/tests/config_parser_unittest.cc
src/lib/cc/simple_parser.h
src/lib/dhcpsrv/alloc_engine.cc
src/lib/dhcpsrv/alloc_engine.h
src/lib/dhcpsrv/client_class_def.cc
src/lib/dhcpsrv/client_class_def.h
src/lib/dhcpsrv/parsers/shared_network_parser.cc
src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
src/lib/dhcpsrv/tests/client_class_def_parser_unittest.cc

Added a ChangeLog entry

doc/examples/kea4/all-keys.json
doc/sphinx/arm/dhcp4-srv.rst
    Updated doc

src/lib/dhcpsrv/alloc_engine.*
    AllocEngine::getValidLft() - revamped to apply use class
    triplet with option 51

src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
    TEST_F(AllocEngine4Test, getValidLft4)  - udpated
    to match new logic

src/lib/dhcpsrv/alloc_engine.*
    AllocEngine::getValidLft(ctx4) - new method which returns
    the appropriate value for valid-leasetime based on the
    context content

    AllocEngine::createLease4
    AllocEngine::updateLease4Information() - call getValidLft()

src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
    TEST_F(AllocEngine4Test, getValidLft4)  - new test

src/bin/dhcp4/tests/config_parser_unittest.cc
    TEST_F(Dhcp4ParserTest, clientClassValidLifetime)
    - new test

src/lib/dhcpsrv/tests/client_class_def_parser_unittest.cc
    TEST_F(ClientClassDefParserTest, validLifetimeTests)
    - improved test

Client class definitions in kea-dhcp4 will now parse
and store valid lifetime triplet (e.g. min-valid-lifetime,
valid-lifetime, and max-valid-lifetime).  Does nothing
with it yet.

src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy b/src/bin/dhcp4/dhcp4_parser.yy
    Added support for valid-lifetime triplet to client class
    definitions

src/lib/cc/simple_parser.*
    SimpleParser::const Triplet<uint32_t>SimpleParser::parseIntTriplet()
    - was formerly dhcp::BaseNetworkParser::parseLifetime()

src/lib/dhcpsrv/client_class_def.*
    ClientClassDef::ClientClassDef
    - added Triplet<uint32_t>valid_  member

src/lib/dhcpsrv/parsers/base_network_parser.*
    Extracted BaseNetworkParser::parseLifetime - relocated
    to cc::SimpleParser

src/lib/dhcpsrv/parsers/client_class_def_parser.cc
    ClientClassDefParser::parse - added call to parseIntTriplet
    to parse valid-lifetime

src/lib/dhcpsrv/parsers/dhcp_parsers.cc
src/lib/dhcpsrv/parsers/shared_network_parser.cc
    Replaced calls parseLifeTime() with parseIntTriplet()

src/lib/dhcpsrv/tests/client_class_def_parser_unittest.cc
    TEST_F(ClientClassDefParserTest, validLifetimeTests) - new test

and introduce MySqlConnectionWithPrimaryKeyTest UTs for Percona to run

used to run any statement that has no placeholder question mark where
you would normally bind variables