Kea issueshttps://gitlab.isc.org/isc-projects/kea/-/issues2019-10-12T09:32:53Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/564Customer request: relax constraints on allowable option types to permit opti...2019-10-12T09:32:53ZMichael McNallyCustomer request: relax constraints on allowable option types to permit option type 0 (and 255?)We have a customer who would like us to relax the constraints on option types which forbid using an option with code 0, which is apparently permissible in ISC DHCP and used by one of their network equipment vendors.
When they try to co...We have a customer who would like us to relax the constraints on option types which forbid using an option with code 0, which is apparently permissible in ISC DHCP and used by one of their network equipment vendors.
When they try to configure such an option in Kea they get:
```
2019-03-28 11:23:01.204 ERROR [kea-dhcp4.dhcp4/3841] DHCP4_PARSER_FAIL failed to create
or run parser for configuration element client-classes: option data does not match option
definition (space: ZTP, code: 0): Can't create V4 option of type 0, V4 options are in
range 1..254 (/etc/kea/kea-dhcp4.conf:144:33)
```Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/633README,AUTHORS, other docs update2019-05-27T17:20:38ZTomek MrugalskiREADME,AUTHORS, other docs updateWe need to update README, AUTHORS and possibly other files in both open source and premium.We need to update README, AUTHORS and possibly other files in both open source and premium.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/436Update contributors guide2019-05-27T16:50:19ZTomek MrugalskiUpdate contributors guideAfter Gitlab migration our contributors guide is outdated. Need to clean it up and probably turn into a separate doc.After Gitlab migration our contributors guide is outdated. Need to clean it up and probably turn into a separate doc.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/618Address doxygen warnings / errors2019-05-27T08:17:43ZWlodzimierz WencelAddress doxygen warnings / errorsit would be cool to address, before release, some doxygen warnings / errors we currently have
https://jenkins.isc.org/job/Kea_doc/1645/warnings16Result/it would be cool to address, before release, some doxygen warnings / errors we currently have
https://jenkins.isc.org/job/Kea_doc/1645/warnings16Result/Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/624Kea build with perfdhcp enabled fails2019-05-23T22:29:01ZGhost UserKea build with perfdhcp enabled fails---
name: Bug report
about: Kea build with perfdhcp enabled fails
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT REPORT IT HERE. Please use https://www.isc.org/community/report-b...---
name: Bug report
about: Kea build with perfdhcp enabled fails
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to security-office(at)isc(dot)org.
**Describe the bug**
Kea build from source with perfdhcp enabled fails in `/kea/src/bin/perfdhcp/test_controll.cc:1016` with error:
```
make[5]: Entering directory '/kea/src/bin/perfdhcp'
CXX test_control.lo
test_control.cc: In member function 'void isc::perfdhcp::TestControl::runWrapped(bool) const':
test_control.cc:1016:24: error: missing sentinel in function call [-Werror=format=]
NULL);
```
**To Reproduce**
`Dockerfile`
```
FROM alpine
ENV LOG4CPLUS_VERSION=REL_2_0_2
ENV KEA_VERSION=600677b8111c1940f774c87d35b5c76efdbe1531
RUN apk add --no-cache --virtual .build-deps \
autoconf \
automake \
git \
libtool \
build-base \
boost-dev \
mysql-dev \
&& \
git clone --branch $LOG4CPLUS_VERSION --depth 1 --recursive https://github.com/log4cplus/log4cplus.git \
&& \
cd /log4cplus && \
./configure && \
make -j 4 && \
make install \
&& \
git clone https://gitlab.isc.org/isc-projects/kea.git /kea \
&& \
cd /kea && git checkout $KEA_VERSION && \
autoreconf --install && \
./configure --enable-static-link --with-mysql --enable-perfdhcp && \
make -j 4 && \
make install \
&& rm -rf /kea /log4cplus && \
apk del .build-deps
```
**Expected behavior**
Build should succeed
**Environment:**
- alpine image: caf27325b298
- Kea git commit: 600677b8111c1940f774c87d35b5c76efdbe1531
- gcc version: 8.3.0
**Describe the solution you'd like**
```diff
diff --git a/src/bin/perfdhcp/test_control.cc b/src/bin/perfdhcp/test_control.cc
index 9ae1e9dd45..edd65900cf 100644
--- a/src/bin/perfdhcp/test_control.cc
+++ b/src/bin/perfdhcp/test_control.cc
@@ -1013,7 +1013,7 @@ TestControl::runWrapped(bool do_stop /*= false */) const {
} else if (pid == 0) {
execlp(options_.getWrapped().c_str(),
do_stop ? "stop" : "start",
- NULL);
+ (void *)NULL);
}
}
}
```Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/627Unsupported object 'Dhcp4' and 'Dhcp6'2019-05-23T18:45:38ZWlodzimierz WencelUnsupported object 'Dhcp4' and 'Dhcp6'So kea is unable to start:
```
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installe...So kea is unable to start:
```
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installed/git/etc/kea/kea.conf
2019-05-23 02:37:52.052 FATAL [kea-ctrl-agent.dctl/1506] DCTL_CONFIG_FILE_LOAD_FAIL Control-agent reason: Configuration parsing failed: Unsupported object 'Dhcp4' in config file /home/wlodek/installed/git/etc/kea/kea.conf
Service failed: Could Not load configuration file: Configuration parsing failed: Unsupported object 'Dhcp4' in config file /home/wlodek/installed/git/etc/kea/kea.conf
````
master branch, same issue with v6, we had issue with forge itself so I can't say when exactly it was introduced I can say that right now - all tests are deadKea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/465Add subnet4-update and subnet6-update commands to subnet-cmds hook [ISC-suppo...2019-04-19T11:25:18ZVicky Riskvicky@isc.orgAdd subnet4-update and subnet6-update commands to subnet-cmds hook [ISC-support #14130]In order to update an existing subnet, you (currently) have to first delete it and then add it.
When making a small change to a large number of subnets, this can create excessive amount of traffic.
Could we please have additional comman...In order to update an existing subnet, you (currently) have to first delete it and then add it.
When making a small change to a large number of subnets, this can create excessive amount of traffic.
Could we please have additional commands to update an existing subnet?
This was part of the original design, but we didn't implement it at the time (likely ran out of time)
https://gitlab.isc.org/isc-projects/kea/wikis/designs/commands#24-subnets-management
S.7. Kea MAY support the #FF0000 subnet4-update command.
S.8. Kea MAY support the #FF0000 subnet6-update command.
From the wiki:
Those two commands allow making changes to an existing subnet: changing prefix, prefix length, T1, T2, preferred lifetime, valid lifetime timers, allowed client classes, subnet specific options, and subnet-id values. It also allows modifying pools.
Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/480Fix shellcheck issues in Kea scripts2019-03-15T23:23:29ZTomek MrugalskiFix shellcheck issues in Kea scripts@ondrej pointed out that shellcheck, a tool that sanitizes shell scripts, reported issues in keactrl.
This task is about addressing those issues in keactrl and checking other user-visible scripts.
The tool is available as on-line servi...@ondrej pointed out that shellcheck, a tool that sanitizes shell scripts, reported issues in keactrl.
This task is about addressing those issues in keactrl and checking other user-visible scripts.
The tool is available as on-line service (https://www.shellcheck.net/), but also as command line tool.
Moved this directly to 1.6, because it's coming from Debian package maintainer, so it's related to an objective of 1.6.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/438Write Performance Guide for Kea2019-03-14T16:12:04ZTomek MrugalskiWrite Performance Guide for KeaSeveral customers are asking about best recommended practices. We published performance numbers, but that's not sufficient as we are a software dev company and our numbers are synthetic. The goal of this is to publish a document that exp...Several customers are asking about best recommended practices. We published performance numbers, but that's not sufficient as we are a software dev company and our numbers are synthetic. The goal of this is to publish a document that explains what parameters and factors affect performance.
@knobee will surely have some suggestions what questions should be answered here.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/403Improve documentation regarding limitations on host cache, radius, and shared...2019-03-14T11:11:27ZBrian ConryImprove documentation regarding limitations on host cache, radius, and shared networksThe documentation is lacking with regard to the limitations that the host cache and/or Radius impose on the use of shared networks.The documentation is lacking with regard to the limitations that the host cache and/or Radius impose on the use of shared networks.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/486No longer use bison is yacc emulation mode.2019-03-11T12:55:19ZFrancis DupontNo longer use bison is yacc emulation mode.The autoconf AC_PROG_YACC used in configure sets the YACC variable to "bison -y" but:
- we do not use any feature of the yacc emulation mode, in particular for output file names.
- we use a lot of bison specific features: this gives a ...The autoconf AC_PROG_YACC used in configure sets the YACC variable to "bison -y" but:
- we do not use any feature of the yacc emulation mode, in particular for output file names.
- we use a lot of bison specific features: this gives a lot of warnings with recent bison versions.
Note an alternative is to disable yacc mode warnings (-Wno-yacc) but even it requires more testing avoid the yacc mode is a far cleaner solution.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/312Move some backend code from radius to host cache.2019-03-08T00:05:39ZFrancis DupontMove some backend code from radius to host cache.It is not a critical issue as the host cache is used only by the radius hook but formally this code in the radius hook belongs to the host cache.It is not a critical issue as the host cache is used only by the radius hook but formally this code in the radius hook belongs to the host cache.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/464Kea DHCPv4 not able to send vendor options if client doesn't send vivso2019-02-19T12:04:48ZTomek MrugalskiKea DHCPv4 not able to send vendor options if client doesn't send vivsoA customer reported a problem that Kea is unable to send back vivso sub-options. Kea sends only the top-level vivso option with correct vendor-id, but is not able to send back any sub-options.
The problem has been investigated and this ...A customer reported a problem that Kea is unable to send back vivso sub-options. Kea sends only the top-level vivso option with correct vendor-id, but is not able to send back any sub-options.
The problem has been investigated and this is caused by the Genexis clients that do not send vivso option itself. That way, the server is not able to figure out what vendor-id to use.
In ideal world, Genexis client would send vivso with enterprise value set to 25167. But they don't and we need to tweak Kea to be able to work around that.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/4681.5.0 sanity checks follow-up: clean README/INSTALL in premium2019-02-19T09:15:08ZTomek Mrugalski1.5.0 sanity checks follow-up: clean README/INSTALL in premium#344 was a nice place to report issues discovered in 1.5.0 sanity checks. Most of them are addressed or have their own issues now, except the problem of README and INSTALL files in premium repository. The [original problem description](h...#344 was a nice place to report issues discovered in 1.5.0 sanity checks. Most of them are addressed or have their own issues now, except the problem of README and INSTALL files in premium repository. The [original problem description](https://gitlab.isc.org/isc-projects/kea/issues/344#note_35992) was:
INSTALL and README files could be improved in hook tarballs:
* README mentions section 14.4 (should be 15.4) or better yet say "15.4 "Available hook libraries". This way people could find it if get the numbering wrong again.
* README mentions section 14.2 (should be 15.2 "Installing hook packages")
* INSTALL mentions 14.2 (should be 15.2)
* INSTALL mentions kea-<packagename>-beta.tar.gz (the "-beta" part should be removed).Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/117configure script doesn't fail when --enable-generate-docs is used and docbook...2019-02-04T15:58:20ZWlodzimierz Wencelconfigure script doesn't fail when --enable-generate-docs is used and docbook-style-xsl is not installedwhen kea is configured with:
`./configure --enable-generate-docs --with-log4cplus=/opt/log4cplus`
but docbook-style-xsl is not installed, configure script finish with success and process of building documentation fail:
```
[jenkins@fedor...when kea is configured with:
`./configure --enable-generate-docs --with-log4cplus=/opt/log4cplus`
but docbook-style-xsl is not installed, configure script finish with success and process of building documentation fail:
```
[jenkins@fedora27-64-2 tools]$ cd ../doc/
[jenkins@fedora27-64-2 doc]$ make
Making all in guide
make[1]: Entering directory '/home/jenkins/workspace/kea-pipeline-multiconf-admin/doc/guide'
/usr/bin/elinks -dump -no-numbering -no-references kea-guide.html > kea-guide.txt
../../tools/system_messages -o kea-messages.xml \
`find ../.. -name "*.mes" -print`
/usr/bin/xsltproc --novalid --xinclude --nonet \
--path ../../doc \
-o kea-messages.html \
--stringparam generate.toc "book toc" \
--stringparam html.stylesheet kea-guide.css \
http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl \
kea-messages.xml
I/O error : Attempt to load network entity http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl
warning: failed to load external entity "http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl"
cannot parse http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl
make[1]: *** [Makefile:644: kea-messages.html] Error 4
make[1]: Leaving directory '/home/jenkins/workspace/kea-pipeline-multiconf-admin/doc/guide'
make: *** [Makefile:532: all-recursive] Error 1
```
configure script should detect missing package and exit with errorKea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/371ld warning message on macOS build2019-01-25T14:05:56ZFrancis Dupontld warning message on macOS buildFrom https://oldkea.isc.org/ticket/5669.
When building on macOS, the message
```
ld: warning: directory not found for option '-L/usr/local/lib64'
```
appears a number of times.
The problem appears to lie in "configure.ac", where "-L$d/...From https://oldkea.isc.org/ticket/5669.
When building on macOS, the message
```
ld: warning: directory not found for option '-L/usr/local/lib64'
```
appears a number of times.
The problem appears to lie in "configure.ac", where "-L$d/lib64" is added to the locations where the log4cplus library may be found. ("d" being the directory tree in which log4cplus was installed). It is suggested that the existence of this directory be checked before adding it to the list.Kea1.6Tomek MrugalskiTomek Mrugalski