Kea issueshttps://gitlab.isc.org/isc-projects/kea/-/issues2019-05-27T18:59:17Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/634compilation error after #584,!3382019-05-27T18:59:17ZWlodzimierz Wencelcompilation error after #584,!338https://jenkins.isc.org/job/kea-master-pairwise/158/execution/node/25/log/
```
make[4]: Leaving directory '/home/jenkins/workspace/kea-master-pairwise/src/bin/lfc'
Making all in keactrl
make[4]: Entering directory '/home/jenkins/workspa...https://jenkins.isc.org/job/kea-master-pairwise/158/execution/node/25/log/
```
make[4]: Leaving directory '/home/jenkins/workspace/kea-master-pairwise/src/bin/lfc'
Making all in keactrl
make[4]: Entering directory '/home/jenkins/workspace/kea-master-pairwise/src/bin/keactrl'
../../../tools/path_replacer.sh \
../../../src/bin/keactrl/kea-dhcp4.conf.pre kea-dhcp4.conf
../../../tools/path_replacer.sh \
../../../src/bin/keactrl/kea-dhcp6.conf.pre kea-dhcp6.conf
../../../tools/path_replacer.sh \
../../../src/bin/keactrl/kea-dhcp-ddns.conf.pre kea-dhcp-ddns.conf
../../../tools/path_replacer.sh \
../../../src/bin/keactrl/kea-ctrl-agent.conf.pre kea-ctrl-agent.conf
make[4]: *** No rule to make target 'kea-netconf.conf.pre', needed by 'kea-netconf.conf'. Stop.
make[4]: *** Waiting for unfinished jobs....
Replacing \@prefix\@ with /home/jenkins/workspace/kea-master-pairwise/kea-bin
```Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/628interface-id is not stored by config-backend2019-05-27T14:30:09ZMichal Nowikowskiinterface-id is not stored by config-backendthe command:
```json
{'arguments': {'remote': {'type': 'mysql'},
'server-tags': ['default'],
'subnets': [{'id': 1,
'interface-id': 'vlan-10',
'pools': ...the command:
```json
{'arguments': {'remote': {'type': 'mysql'},
'server-tags': ['default'],
'subnets': [{'id': 1,
'interface-id': 'vlan-10',
'pools': [{'pool': '2001:db8:1::1-2001:db8:1::100'}],
'shared-network-name': '',
'subnet': '2001:db8:1::/64'}]},
'command': 'remote-subnet6-set',
'service': ['dhcp6']}
```
config-get response does not contain information about interface-id:
```json
...
"subnet6": [
{
"id": 1,
"option-data": [],
"pd-pools": [],
"pools": [
{
"option-data": [],
"pool": "2001:db8:1::1-2001:db8:1::100"
}
],
"relay": {
"ip-addresses": []
},
"reservations": [],
"subnet": "2001:db8:1::/64"
}
]
...
```Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/627Unsupported object 'Dhcp4' and 'Dhcp6'2019-05-23T18:45:38ZWlodzimierz WencelUnsupported object 'Dhcp4' and 'Dhcp6'So kea is unable to start:
```
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installe...So kea is unable to start:
```
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installed/git/etc/kea/kea.conf
2019-05-23 02:37:52.052 FATAL [kea-ctrl-agent.dctl/1506] DCTL_CONFIG_FILE_LOAD_FAIL Control-agent reason: Configuration parsing failed: Unsupported object 'Dhcp4' in config file /home/wlodek/installed/git/etc/kea/kea.conf
Service failed: Could Not load configuration file: Configuration parsing failed: Unsupported object 'Dhcp4' in config file /home/wlodek/installed/git/etc/kea/kea.conf
````
master branch, same issue with v6, we had issue with forge itself so I can't say when exactly it was introduced I can say that right now - all tests are deadKea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/624Kea build with perfdhcp enabled fails2019-05-23T22:29:01ZGhost UserKea build with perfdhcp enabled fails---
name: Bug report
about: Kea build with perfdhcp enabled fails
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT REPORT IT HERE. Please use https://www.isc.org/community/report-b...---
name: Bug report
about: Kea build with perfdhcp enabled fails
---
If you believe your bug report is a security issue (e.g. a packet that can kill the server), DO NOT REPORT IT HERE. Please use https://www.isc.org/community/report-bug/ instead or send mail to security-office(at)isc(dot)org.
**Describe the bug**
Kea build from source with perfdhcp enabled fails in `/kea/src/bin/perfdhcp/test_controll.cc:1016` with error:
```
make[5]: Entering directory '/kea/src/bin/perfdhcp'
CXX test_control.lo
test_control.cc: In member function 'void isc::perfdhcp::TestControl::runWrapped(bool) const':
test_control.cc:1016:24: error: missing sentinel in function call [-Werror=format=]
NULL);
```
**To Reproduce**
`Dockerfile`
```
FROM alpine
ENV LOG4CPLUS_VERSION=REL_2_0_2
ENV KEA_VERSION=600677b8111c1940f774c87d35b5c76efdbe1531
RUN apk add --no-cache --virtual .build-deps \
autoconf \
automake \
git \
libtool \
build-base \
boost-dev \
mysql-dev \
&& \
git clone --branch $LOG4CPLUS_VERSION --depth 1 --recursive https://github.com/log4cplus/log4cplus.git \
&& \
cd /log4cplus && \
./configure && \
make -j 4 && \
make install \
&& \
git clone https://gitlab.isc.org/isc-projects/kea.git /kea \
&& \
cd /kea && git checkout $KEA_VERSION && \
autoreconf --install && \
./configure --enable-static-link --with-mysql --enable-perfdhcp && \
make -j 4 && \
make install \
&& rm -rf /kea /log4cplus && \
apk del .build-deps
```
**Expected behavior**
Build should succeed
**Environment:**
- alpine image: caf27325b298
- Kea git commit: 600677b8111c1940f774c87d35b5c76efdbe1531
- gcc version: 8.3.0
**Describe the solution you'd like**
```diff
diff --git a/src/bin/perfdhcp/test_control.cc b/src/bin/perfdhcp/test_control.cc
index 9ae1e9dd45..edd65900cf 100644
--- a/src/bin/perfdhcp/test_control.cc
+++ b/src/bin/perfdhcp/test_control.cc
@@ -1013,7 +1013,7 @@ TestControl::runWrapped(bool do_stop /*= false */) const {
} else if (pid == 0) {
execlp(options_.getWrapped().c_str(),
do_stop ? "stop" : "start",
- NULL);
+ (void *)NULL);
}
}
}
```Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/620config-backend v6: relay parameter in shared-networks is not taken into accou...2019-05-24T07:55:06ZMichal Nowikowskiconfig-backend v6: relay parameter in shared-networks is not taken into account for msgs sent from indicated relay agentAs stated in title: when relay param is specified in shared-network and packets are sent from indicated relay agent
they are not matched to this network and its subnet.
It works in all other combinations i.e v4/subnet, v4/network and v6...As stated in title: when relay param is specified in shared-network and packets are sent from indicated relay agent
they are not matched to this network and its subnet.
It works in all other combinations i.e v4/subnet, v4/network and v6/subnet.
It only does not work for v6/network.Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/603mysql_cb fails to register DHCPv6 configuration backend for MySQL2019-05-15T11:24:34ZMarcin Siodelskimysql_cb fails to register DHCPv6 configuration backend for MySQLThis is an omission from the previous ticket which implemented MySQL v6 CB. We forgot to call the function to register v6 configuration backend in the `load()` function.
I am adding this to 1.6.0 as this is no brainer that it must be done.This is an omission from the previous ticket which implemented MySQL v6 CB. We forgot to call the function to register v6 configuration backend in the `load()` function.
I am adding this to 1.6.0 as this is no brainer that it must be done.Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/597TeeTest.calculateTimers unittest failing2019-05-15T17:40:08ZWlodzimierz WencelTeeTest.calculateTimers unittest failingsince [#360,!305] was merged there is one unit test that is keep failing.
https://jenkins.isc.org/job/kea-master/348/testReport/junit/(root)/TeeTest/Multi_node_testing_loop___fedora27_32___results___calculateTimers/
it's failing just ...since [#360,!305] was merged there is one unit test that is keep failing.
https://jenkins.isc.org/job/kea-master/348/testReport/junit/(root)/TeeTest/Multi_node_testing_loop___fedora27_32___results___calculateTimers/
it's failing just on fedora 27 32 bit. fedora27-32-2Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/591kea-dhcpv6 lease sanity-checking is flagging PD leases2019-05-10T09:48:34ZThomas Markwalderkea-dhcpv6 lease sanity-checking is flagging PD leasesReported via support issue https://support.isc.org/Ticket/Display.html?id=14522.
Analysis showed that kea-dhcpv6 sanity checking is attempting to map PD leases to subnets by address which a: is not supported b: the admin guide says is...Reported via support issue https://support.isc.org/Ticket/Display.html?id=14522.
Analysis showed that kea-dhcpv6 sanity checking is attempting to map PD leases to subnets by address which a: is not supported b: the admin guide says is not done for PD leases. Testing confirms this as does visual code inspection. The code should either not check PD leases or check them properly. In either case, there are no unit tests to verify PD leases are treated correctly.Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/587radius + host cache do not work2019-05-10T08:04:55ZMichal Nowikowskiradius + host cache do not workrepro steps:
1. bring up Kea with radius and host cache premium hooks
2. send discovery to kea
the packet should be recognized via host cache but is seems that host cache is missing internally in kea:
ERROR [kea-dhcp4.radius-hooks/2675...repro steps:
1. bring up Kea with radius and host cache premium hooks
2. send discovery to kea
the packet should be recognized via host cache but is seems that host cache is missing internally in kea:
ERROR [kea-dhcp4.radius-hooks/26757] RADIUS_ACCESS_NO_HOST_CACHE access is enabled but no host cache was foundKea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/577cb-cmds: setting dhcp4o6-port does not work2019-05-23T20:04:51ZMichal Nowikowskicb-cmds: setting dhcp4o6-port does not workIssued command:
```javascript
{'arguments': {'parameters': [{'name': 'dhcp4o6-port', 'value': 4321}],
'remote': {'type': 'mysql'},
'server-tags': ['default']},
'command': 'remote-global-parameter4-set',
's...Issued command:
```javascript
{'arguments': {'parameters': [{'name': 'dhcp4o6-port', 'value': 4321}],
'remote': {'type': 'mysql'},
'server-tags': ['default']},
'command': 'remote-global-parameter4-set',
'service': ['dhcp4']}
[
{
"result": 0,
"text": "DHCPv4 global parameter successfully set."
}
]
```
Result of `config-get` after `config-reload`:
```javascript
...
"dhcp-queue-control": {
"capacity": 500,
"enable-queue": false,
"queue-type": "kea-ring4"
},
"dhcp4o6-port": 0,
"echo-client-id": true,
"expired-leases-processing": {
"flush-reclaimed-timer-wait-time": 25,
"hold-reclaimed-time": 3600,
...
```Kea1.6Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/issues/574cb-cmds: inconsistent way of handling embedded containers2019-06-13T07:35:07ZMichal Nowikowskicb-cmds: inconsistent way of handling embedded containersIf empty list of pools is passed to remote-subnet4-set then it causes deleting all pools in given subnet.
If empty list of subnets is passed to remote-network4-set then nothing happens, it does not cause deleting subnets in the shared ne...If empty list of pools is passed to remote-subnet4-set then it causes deleting all pools in given subnet.
If empty list of subnets is passed to remote-network4-set then nothing happens, it does not cause deleting subnets in the shared network.
This is inconsistent and unintuitive. Users will have problems with that.
Explaining this in docs is not a fix for this issue.Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/571Segfault when DHCP server using CB terminates (clang only)2019-04-18T19:19:29ZMarcin SiodelskiSegfault when DHCP server using CB terminates (clang only)When running some manual tests of the CB on macOS I noticed that it causes a segfault upon termination. This doesn't impact the operation of the DHCP server. It occurs when the process exits and destructor of the `CfgMgr` is invoked. The...When running some manual tests of the CB on macOS I noticed that it causes a segfault upon termination. This doesn't impact the operation of the DHCP server. It occurs when the process exits and destructor of the `CfgMgr` is invoked. The snippet https://gitlab.isc.org/snippets/840 includes a back trace. This issue only occurs when Kea is compiled with clang.
The direct cause of this issue is that we allocate objects such as subnets, shared networks etc. within the heap that belongs to the dynamically loaded library (hooks library) and then pass them back to the binary (Kea server). As long as the library is loaded the Kea server can safely use those objects. However, when the library is unloaded the memory space dedicated for the library is gone and no longer accessible by the binary. As a result, the binary segfaults when trying to destroy the object.
One of the considered solutions was to make the library clear the configuration when it is being unloaded. I tried that and it indeed prevented the crash. However, we want the configuration to outlive the library. Especially that there is no easy way to clear the configuration that was introduced by the library and preserve all the rest.
The better solution which I tested was to create the static factory functions within Kea, e.g. `Subnet4::create` which would return the shared pointer to the newly created object. The library must call this factory function (rather than create the instance on its own) which will cause the instance to be created by the binary, rather than the library. That way, when the library is unloaded the object is still available.Kea1.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/565Client-Classes break KEA Config-Set API Call?2019-05-21T12:36:55ZGhost UserClient-Classes break KEA Config-Set API Call?---
name: Client-Classes break KEA Config-Set API Call?
about: Config-Set API call
---
**Describe the bug**
We've created a client-class for IP-phones in the KEA configuration. Now that we've started automating with the API we discover...---
name: Client-Classes break KEA Config-Set API Call?
about: Config-Set API call
---
**Describe the bug**
We've created a client-class for IP-phones in the KEA configuration. Now that we've started automating with the API we discovered an issue with the config-set API call, which reports a bad request.
The configuration is live, and KEA accepts it. However, even when we get the config through the API, and try to set it without changing it, it reports a "bad request".
**To Reproduce**
(Part of the) Config that works:
"shared-networks": [ ],
"client-classes": [
{
"name": "Innovaphone"
}
],
"subnet4": [
(Part of the) Config that doesn't work:
"shared-networks": [ ],
"client-classes": [
{
"name": "Innovaphone",
"test": "option[60].hex == '1.3.6.1.4.1.6666'",
"option-def": [
{
"name": "vendor-encapsulated-options",
"code": 43,
"type": "empty",
"encapsulate": "Innovaphone"
}
],
"option-data": [
{
"name": "h323-gatekeeper",
"code": 200,
"space": "Innovaphone",
"data": "10.90.249.1"
},
{
"name": "default-coder",
"code": 203,
"space": "Innovaphone",
"data": "G711A\\,20\\,k4/G711a\\,20\\,k4"
},
{
"name": "language",
"code": 204,
"space": "Innovaphone",
"data": "dut"
},
{
"name": "dialtone-type",
"code": 210,
"space": "Innovaphone",
"data": "0x2C"
},
{
"name": "update-URL",
"code": 215,
"space": "Innovaphone",
"data": "http://10.90.249.1/DRIVE/CF0/update/"
},
{
"name": "vendor-encapsulated-options",
"code": 43
}
]
}
],
"subnet4": [
**Expected behavior**
Being able to set the exact same config through the API that would work on the CLI.
**Environment:**
- Kea version: which release? KEA 1.4
- OS:Ubuntu 16.04 x64
**Contacting you**
gitlab / emailKea1.6Wlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/564Customer request: relax constraints on allowable option types to permit opti...2019-10-12T09:32:53ZMichael McNallyCustomer request: relax constraints on allowable option types to permit option type 0 (and 255?)We have a customer who would like us to relax the constraints on option types which forbid using an option with code 0, which is apparently permissible in ISC DHCP and used by one of their network equipment vendors.
When they try to co...We have a customer who would like us to relax the constraints on option types which forbid using an option with code 0, which is apparently permissible in ISC DHCP and used by one of their network equipment vendors.
When they try to configure such an option in Kea they get:
```
2019-03-28 11:23:01.204 ERROR [kea-dhcp4.dhcp4/3841] DHCP4_PARSER_FAIL failed to create
or run parser for configuration element client-classes: option data does not match option
definition (space: ZTP, code: 0): Can't create V4 option of type 0, V4 options are in
range 1..254 (/etc/kea/kea-dhcp4.conf:144:33)
```Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/561Make kea to build on last macOS / Xcode2019-05-23T09:40:16ZFrancis DupontMake kea to build on last macOS / XcodeI updated macOS, Xcode, all brewed dependencies, libyang/sysrepo. I am trying to make Kea with premium to build with all options on. Unfortunately the last clang (1001.0.46.3) does not accept some features.
This ticket is to fix all iss...I updated macOS, Xcode, all brewed dependencies, libyang/sysrepo. I am trying to make Kea with premium to build with all options on. Unfortunately the last clang (1001.0.46.3) does not accept some features.
This ticket is to fix all issues which block build and make check on macOS (the idea is they should block on some other systems too).Kea1.6Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/557ddns in combination with dhcpv6 did not work as expected2019-05-15T16:02:40ZGhost Userddns in combination with dhcpv6 did not work as expected**Describe the bug**
setup Kea 1.5 for IPv4 and IPv6 and ddns. Works without any problem in with the IPv4 part.
DNS Server is PowerDNS 4.1.8
**To Reproduce**
Steps to reproduce the behavior:
1. Run Kea dhcpv6 and ddns
Part of kea-dhcp6...**Describe the bug**
setup Kea 1.5 for IPv4 and IPv6 and ddns. Works without any problem in with the IPv4 part.
DNS Server is PowerDNS 4.1.8
**To Reproduce**
Steps to reproduce the behavior:
1. Run Kea dhcpv6 and ddns
Part of kea-dhcp6.conf
```
"dhcp-ddns": {
"enable-updates": true,
"generated-prefix": "host",
"qualifying-suffix": "xxxxx.local",
"replace-client-name": "when-not-present",
"override-no-update": true,
"override-client-update": true
},
```
2. Client get IPv6 addresses from the dhcp-server, and now i would expect, it see the relevant records in the DNS-Server, but except one record for the AAAA and the PTR record in addition to the DHCID Record nothing appears. Even there are 10 to 15 other devices get an ip from the dhcp-server.
**Expected behavior**
See the generated records in the DNS-Server
**Environment:**
- Kea version: 1.5
- OS: Alpine-Linux 3.9
- /usr/bin/kea-dhcp-ddns -V
1.5.0
tarball
linked with:
log4cplus 2.0.3
OpenSSL 1.1.1b 26 Feb 2019
**Additional Information**
What i see in the logfile is only remove messages, but no create messages.
```
com-b-alpine kea-dhcp-ddns: INFO [kea-dhcp-ddns.d2-to-dns] DHCP_DDNS_REMOVE_SUCCEEDED DHCP_DDNS Request ID 000201F095FB83A15F88F0A7259900830C3C8137668532382B0CC1A159474D19CDE1AC: successfully removed the DNS mapping addition for this request: Type: 1 (CHG_REMOVE)#012Forward Change: yes#012Reverse Change: yes#012FQDN: [host-2003-xxxx-xxxx-xxxxx--185.ghostdive.local.]#012IP Address: [2003:xxxx:xxxx:xxxx::185]#012DHCID: [000201F095FB83A15F88F0A7259900830C3C8137668532382B0CC1A159474D19CDE1AC]#012Lease Expires On: 20190402151730#012Lease Length: 4000#012
com-b-alpine kea-dhcp-ddns: DEBUG [kea-dhcp-ddns.asiodns] ASIODNS_FETCH_COMPLETED upstream fetch to 10.1.0.10(10053) has now completed
com-b-alpine kea-dhcp-ddns: DEBUG [kea-dhcp-ddns.d2-to-dns] DHCP_DDNS_UPDATE_RESPONSE_RECEIVED Request ID 000201F095FB83A15F88F0A7259900830C3C8137668532382B0CC1A159474D19CDE1AC: to server: 10.1.0.10 port:10053 status: SUCCESS, rcode: NXRRSET
com-b-alpine kea-dhcp-ddns: DEBUG [kea-dhcp-ddns.d2-to-dns] DHCP_DDNS_UPDATE_REQUEST_SENT Request ID 000201F095FB83A15F88F0A7259900830C3C8137668532382B0CC1A159474D19CDE1AC: Reverse Remove to server: 10.1.0.10 port:10053
```Kea1.6Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/555cql-config script does not work2019-04-08T18:29:33ZTomek Mrugalskicql-config script does not workFrom this [jenkins build](https://jenkins.isc.org/job/kea-master-db-backends/86/console):
```
tools/cql_config: 30: tools/cql_config: source: not found
tools/cql_config: 38: [: --print-errors: unexpected operator
tools/cql_config: 71: [...From this [jenkins build](https://jenkins.isc.org/job/kea-master-db-backends/86/console):
```
tools/cql_config: 30: tools/cql_config: source: not found
tools/cql_config: 38: [: --print-errors: unexpected operator
tools/cql_config: 71: [: --print-errors: unexpected operator
tools/cql_config: 75: [: --print-errors: unexpected operator
tools/cql_config: 80: [: --print-errors: unexpected operator
tools/cql_config: 85: [: --print-errors: unexpected operator
tools/cql_config: 93: [: --print-errors: unexpected operator
wrong parameter
run: `tools/cql_config --help` for more help
configure: error: tools/cql_config cassandra failed
```
Seems like replacing `source` with `.` should fix the first problem. No idea about the following ones.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/534keactrl try to stop kea services twice?2020-03-12T15:38:23ZWlodzimierz Wencelkeactrl try to stop kea services twice?It looks like keactrl try to stop kea-dhcp4 and kea-ctrl-agent twice:
1. start:
```
wlodek@debian9-64-2:~ $ sudo /home/wlodek/installed/git/sbin/keactrl start
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlod...It looks like keactrl try to stop kea-dhcp4 and kea-ctrl-agent twice:
1. start:
```
wlodek@debian9-64-2:~ $ sudo /home/wlodek/installed/git/sbin/keactrl start
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installed/git/etc/kea/kea.conf
wlodek@debian9-64-2:~ $ 2019-03-14 03:47:15.082 INFO [kea-ctrl-agent.ctrl-agent/380] CTRL_AGENT_STARTED Kea Control Agent version 1.5.0-git started
```
2. check:
```
wlodek@debian9-64-2:~ $ ps -aux | grep kea
root 372 0.2 1.2 145160 19752 pts/0 S 03:47 0:00 /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
root 380 0.0 0.5 69744 8204 pts/0 S 03:47 0:00 /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installed/git/etc/kea/kea.conf
wlodek 390 0.0 0.0 11108 968 pts/0 S+ 03:47 0:00 grep kea
```
3. stop:
```
wlodek@debian9-64-2:~ $ sudo /home/wlodek/installed/git/sbin/keactrl stop
INFO/keactrl: Stopping kea-dhcp4...
ERROR/keactrl: Stop failed, could not send signal 15 to process , PID 372.\n
INFO/keactrl: kea-dhcp6 isn't running.
INFO/keactrl: kea-dhcp-ddns isn't running.
INFO/keactrl: Stopping kea-ctrl-agent...
ERROR/keactrl: Stop failed, could not send signal 15 to process , PID 380.\n
2019-03-14 03:47:27.591 INFO [kea-ctrl-agent.dctl/380] DCTL_SHUTDOWN Control-agent has shut down, pid: 380, version: 1.5.0-git
INFO/keactrl: kea-netconf isn't running.
```
we don't want to see this `ERROR/keactrl: Stop failed, could not send signal 15 to process , PID 372.\n`
especially when kea was stopped successfully:
```
wlodek@debian9-64-2:~ $ ps -aux | grep kea
wlodek 446 0.0 0.0 11108 948 pts/0 S+ 03:47 0:00 grep kea
```
Looks like this was a build when it was introduced:
https://jenkins.isc.org/job/kea-master-system-tests-v6/120/
so during fight with shell checkKea1.6Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/issues/524using sh and wrong syntax in if statements breaks ubuntu build2019-04-03T18:54:27ZRazvan Becheriuusing sh and wrong syntax in if statements breaks ubuntu buildOn systems with Ubuntu 18.04, using /bin/sh will cause issues in the scripts:
/home/user/work/git/kea-not-working/tools/cql_config: 30: /home/user/work/git/kea-not-working/tools/cql_config: source: not found
/home/user/work/git/kea-not-...On systems with Ubuntu 18.04, using /bin/sh will cause issues in the scripts:
/home/user/work/git/kea-not-working/tools/cql_config: 30: /home/user/work/git/kea-not-working/tools/cql_config: source: not found
/home/user/work/git/kea-not-working/tools/cql_config: 38: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 71: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 75: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 80: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 85: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 93: [: --print-errors: unexpected operator
If '/bin/sh' is replaced with '/bin/bash' the 'source' command will be available, or the 'source' command must be replace with '.' and the /bin/sh can be left as it is.
In /bin/sh and in /bin/bash, the comparison operation is not valid:
if [ "$x" == "value" ]; then
The proper syntax is:
if [ "$x" = "value" ]; then
All scripts using this syntax must be fixed.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/517remote-network4-set doesn't save some parameters2019-04-16T09:58:51ZWlodzimierz Wencelremote-network4-set doesn't save some parametersconfig parameters:
* rebind-timer
* renew-timer
* valid-lifetime
* reservation-mode
are not saved when remote-network4-set is used.
**Scenario**
add network:
```
{
"arguments": {
"remote": {
"type": "mysql"
},
"serv...config parameters:
* rebind-timer
* renew-timer
* valid-lifetime
* reservation-mode
are not saved when remote-network4-set is used.
**Scenario**
add network:
```
{
"arguments": {
"remote": {
"type": "mysql"
},
"server-tags": [
"abc"
],
"shared-networks": [
{
"client-class": "abc",
"interface": "enp0s9",
"name": "net1",
"option-data": [
{
"always-send": true,
"code": 6,
"csv-format": true,
"data": "192.0.2.1"
}
],
"rebind-timer": 200,
"renew-timer": 100,
"reservation-mode": "global",
"subnet4": [
{
"interface": "enp0s9",
"pools": [
{
"pool": "192.8.0.1-192.8.0.1"
}
],
"subnet": "192.8.0.0/24"
}
],
"user-context": "some weird network",
"valid-lifetime": 300
}
]
},
"command": "remote-network4-set"
}
```
response:
```
{
"arguments": {
"shared-networks": [
{
"name": "net1"
}
]
},
"result": 0,
"text": "IPv4 shared network successfully set."
}
```
get network:
```
{
"arguments": {
"remote": {
"type": "mysql"
},
"server-tags": [
"abc"
],
"shared-networks": [
{
"name": "net1"
}
]
},
"command": "remote-network4-get"
}
```
returned configuration:
```
{
"arguments": {
"count": 1,
"shared-networks": [
{
"authoritative": false,
"client-class": "abc",
"interface": "enp0s9",
"match-client-id": true,
"name": "net1",
"option-data": [
{
"always-send": true,
"code": 6,
"csv-format": true,
"data": "192.0.2.1",
"name": "domain-name-servers",
"space": "dhcp4"
}
],
"relay": {
"ip-addresses": []
},
"reservation-mode": "all",
"subnet4": [],
"user-context": "some weird network"
}
]
},
"result": 0,
"text": "IPv4 shared network 'net1' found."
}
```
quick peak into database:
```
mysql> select * from dhcp4_shared_network;
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+----------------------+----------------+
| id | name | client_class | interface | match_client_id | modification_ts | rebind_timer | relay | renew_timer | require_client_classes | reservation_mode | user_context | valid_lifetime |
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+----------------------+----------------+
| 1 | net1 | abc | enp0s9 | 1 | 2019-03-01 05:31:28 | NULL | NULL | NULL | [ ] | 3 | "some weird network" | NULL |
+----+------+--------------+-----------+-----------------+---------------------+--------------+-------+-------------+------------------------+------------------+----------------------+----------------+
1 row in set (0.00 sec)
```
...and values are indeed missing. Related: isc-projects/kea#508Kea1.6Marcin SiodelskiMarcin Siodelski