Kea issueshttps://gitlab.isc.org/isc-projects/kea/-/issues2019-04-08T18:29:33Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/555cql-config script does not work2019-04-08T18:29:33ZTomek Mrugalskicql-config script does not workFrom this [jenkins build](https://jenkins.isc.org/job/kea-master-db-backends/86/console):
```
tools/cql_config: 30: tools/cql_config: source: not found
tools/cql_config: 38: [: --print-errors: unexpected operator
tools/cql_config: 71: [...From this [jenkins build](https://jenkins.isc.org/job/kea-master-db-backends/86/console):
```
tools/cql_config: 30: tools/cql_config: source: not found
tools/cql_config: 38: [: --print-errors: unexpected operator
tools/cql_config: 71: [: --print-errors: unexpected operator
tools/cql_config: 75: [: --print-errors: unexpected operator
tools/cql_config: 80: [: --print-errors: unexpected operator
tools/cql_config: 85: [: --print-errors: unexpected operator
tools/cql_config: 93: [: --print-errors: unexpected operator
wrong parameter
run: `tools/cql_config --help` for more help
configure: error: tools/cql_config cassandra failed
```
Seems like replacing `source` with `.` should fix the first problem. No idea about the following ones.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/534keactrl try to stop kea services twice?2020-03-12T15:38:23ZWlodzimierz Wencelkeactrl try to stop kea services twice?It looks like keactrl try to stop kea-dhcp4 and kea-ctrl-agent twice:
1. start:
```
wlodek@debian9-64-2:~ $ sudo /home/wlodek/installed/git/sbin/keactrl start
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlod...It looks like keactrl try to stop kea-dhcp4 and kea-ctrl-agent twice:
1. start:
```
wlodek@debian9-64-2:~ $ sudo /home/wlodek/installed/git/sbin/keactrl start
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
INFO/keactrl: Starting /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installed/git/etc/kea/kea.conf
wlodek@debian9-64-2:~ $ 2019-03-14 03:47:15.082 INFO [kea-ctrl-agent.ctrl-agent/380] CTRL_AGENT_STARTED Kea Control Agent version 1.5.0-git started
```
2. check:
```
wlodek@debian9-64-2:~ $ ps -aux | grep kea
root 372 0.2 1.2 145160 19752 pts/0 S 03:47 0:00 /home/wlodek/installed/git/sbin/kea-dhcp4 -c /home/wlodek/installed/git/etc/kea/kea.conf
root 380 0.0 0.5 69744 8204 pts/0 S 03:47 0:00 /home/wlodek/installed/git/sbin/kea-ctrl-agent -c /home/wlodek/installed/git/etc/kea/kea.conf
wlodek 390 0.0 0.0 11108 968 pts/0 S+ 03:47 0:00 grep kea
```
3. stop:
```
wlodek@debian9-64-2:~ $ sudo /home/wlodek/installed/git/sbin/keactrl stop
INFO/keactrl: Stopping kea-dhcp4...
ERROR/keactrl: Stop failed, could not send signal 15 to process , PID 372.\n
INFO/keactrl: kea-dhcp6 isn't running.
INFO/keactrl: kea-dhcp-ddns isn't running.
INFO/keactrl: Stopping kea-ctrl-agent...
ERROR/keactrl: Stop failed, could not send signal 15 to process , PID 380.\n
2019-03-14 03:47:27.591 INFO [kea-ctrl-agent.dctl/380] DCTL_SHUTDOWN Control-agent has shut down, pid: 380, version: 1.5.0-git
INFO/keactrl: kea-netconf isn't running.
```
we don't want to see this `ERROR/keactrl: Stop failed, could not send signal 15 to process , PID 372.\n`
especially when kea was stopped successfully:
```
wlodek@debian9-64-2:~ $ ps -aux | grep kea
wlodek 446 0.0 0.0 11108 948 pts/0 S+ 03:47 0:00 grep kea
```
Looks like this was a build when it was introduced:
https://jenkins.isc.org/job/kea-master-system-tests-v6/120/
so during fight with shell checkKea1.6Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/issues/524using sh and wrong syntax in if statements breaks ubuntu build2019-04-03T18:54:27ZRazvan Becheriuusing sh and wrong syntax in if statements breaks ubuntu buildOn systems with Ubuntu 18.04, using /bin/sh will cause issues in the scripts:
/home/user/work/git/kea-not-working/tools/cql_config: 30: /home/user/work/git/kea-not-working/tools/cql_config: source: not found
/home/user/work/git/kea-not-...On systems with Ubuntu 18.04, using /bin/sh will cause issues in the scripts:
/home/user/work/git/kea-not-working/tools/cql_config: 30: /home/user/work/git/kea-not-working/tools/cql_config: source: not found
/home/user/work/git/kea-not-working/tools/cql_config: 38: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 71: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 75: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 80: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 85: [: --print-errors: unexpected operator
/home/user/work/git/kea-not-working/tools/cql_config: 93: [: --print-errors: unexpected operator
If '/bin/sh' is replaced with '/bin/bash' the 'source' command will be available, or the 'source' command must be replace with '.' and the /bin/sh can be left as it is.
In /bin/sh and in /bin/bash, the comparison operation is not valid:
if [ "$x" == "value" ]; then
The proper syntax is:
if [ "$x" = "value" ]; then
All scripts using this syntax must be fixed.Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/480Fix shellcheck issues in Kea scripts2019-03-15T23:23:29ZTomek MrugalskiFix shellcheck issues in Kea scripts@ondrej pointed out that shellcheck, a tool that sanitizes shell scripts, reported issues in keactrl.
This task is about addressing those issues in keactrl and checking other user-visible scripts.
The tool is available as on-line servi...@ondrej pointed out that shellcheck, a tool that sanitizes shell scripts, reported issues in keactrl.
This task is about addressing those issues in keactrl and checking other user-visible scripts.
The tool is available as on-line service (https://www.shellcheck.net/), but also as command line tool.
Moved this directly to 1.6, because it's coming from Debian package maintainer, so it's related to an objective of 1.6.Kea1.6Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/471Hammer build tool should be internal2019-03-06T14:28:15ZTomek MrugalskiHammer build tool should be internalWe discussed this on 2019-02-07 call and the overall consensus was make it internal. It's not really hidden, just we don't want to distribute it in a tarball.
1. Need to tweak makefiles.
1. Need to remove the user's guide section (but t...We discussed this on 2019-02-07 call and the overall consensus was make it internal. It's not really hidden, just we don't want to distribute it in a tarball.
1. Need to tweak makefiles.
1. Need to remove the user's guide section (but the content was useful, perhaps turn this into a text printed out when calling ./hammer.py --tutorial or something similar)Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/431Write a script that cleans up config backend DB2019-04-10T11:35:45ZTomek MrugalskiWrite a script that cleans up config backend DB@marcin and @tomek discussed a concept of wiping database. This may address several issues:
- system tests need to discard all data from a DB after a CB test.
- after schema was extended, every unit-test creates and then tears down the ...@marcin and @tomek discussed a concept of wiping database. This may address several issues:
- system tests need to discard all data from a DB after a CB test.
- after schema was extended, every unit-test creates and then tears down the schema. With many (around 40) tables, this is very slow process. We should have an option (possibly even enabled by default) to wipe data from the tables rather then tear them down and recreate every time. (TRUNCATE TABLE is supposedly faster than DELETE FROM, but has some constraints and can't be used everywhere).Kea1.6https://gitlab.isc.org/isc-projects/kea/-/issues/372a tool for preparing build environment, building and unittesting Kea2019-01-31T13:57:09ZMichal Nowikowskia tool for preparing build environment, building and unittesting KeaHere's Michał's description:
The aim of this tool is in vanilla environment setting up Kea build dependencies and performing a build and unit tests.
The build can be executed in 3 environments: local system, VirtualBox and LXC.
I wa...Here's Michał's description:
The aim of this tool is in vanilla environment setting up Kea build dependencies and performing a build and unit tests.
The build can be executed in 3 environments: local system, VirtualBox and LXC.
I wanted to solved a problem of dealing with rather complicated set of deps that we have and also with configuring and building procedure. Currently the tool is able to execute a build on all supported systems in one command line invocation which I think is pretty nice for new comers or people who deal with particular systems not that often.
The target users of the tools are Kea developers and CI system on Jenkins.
Kea1.6Michal NowikowskiMichal Nowikowskihttps://gitlab.isc.org/isc-projects/kea/-/issues/214add colors to services states in keactrl2019-05-14T15:18:10ZMichal Nowikowskiadd colors to services states in keactrlKea1.6Michal NowikowskiMichal Nowikowski