Kea issueshttps://gitlab.isc.org/isc-projects/kea/-/issues2019-12-13T17:51:31Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/1034get_config_unittest.cc.skel missing in tarball2019-12-13T17:51:31ZTomek Mrugalskiget_config_unittest.cc.skel missing in tarballThe src/bin/dhcp{4,6}/tests/get_config_unittest.cc.skel files are not included in the tarball.
See https://gitlab.isc.org/isc-projects/kea/issues/977#note_86280The src/bin/dhcp{4,6}/tests/get_config_unittest.cc.skel files are not included in the tarball.
See https://gitlab.isc.org/isc-projects/kea/issues/977#note_86280kea1.7.3https://gitlab.isc.org/isc-projects/kea/-/issues/1004Compilation failure with gtest and --with-werror2019-11-29T19:06:51ZTomek MrugalskiCompilation failure with gtest and --with-werrorThere are two compilation warnings in src/lib/dhcpsrv that, together with werror enabled, cause the compilation to fail.
1. ```host_mgr_unittest.cc:508:1: error: ‘void {anonymous}::HostMgrTest::testGetAllbyHostnameSubnet6(isc::dhcp::Bas...There are two compilation warnings in src/lib/dhcpsrv that, together with werror enabled, cause the compilation to fail.
1. ```host_mgr_unittest.cc:508:1: error: ‘void {anonymous}::HostMgrTest::testGetAllbyHostnameSubnet6(isc::dhcp::BaseHostDataSource&, isc::dhcp::BaseHostDataSource&)’ defined but not used```
2. ```lease_mgr_unittest.cc:147:60: error: unused parameter ‘hostname’ [-Werror=unused-parameter]
virtual Lease4Collection getLeases4(const std::string& hostname) const``` (repeated for both v4 and v6)kea1.7.3Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/1003libdns,dhcp4,dhcp6 tests using macros deprecated in gtest 1.102019-12-07T09:26:54ZTomek Mrugalskilibdns,dhcp4,dhcp6 tests using macros deprecated in gtest 1.10There are some tests in libdns that use TYPED_TEST_CASE macros. Those are deprecated in gtest 1.10. This prevents builds with gtest 1.10 and --with-werror.There are some tests in libdns that use TYPED_TEST_CASE macros. Those are deprecated in gtest 1.10. This prevents builds with gtest 1.10 and --with-werror.kea1.7.3Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/1002gtest 1.10 version is not recognized2019-11-18T18:22:48ZTomek Mrugalskigtest 1.10 version is not recognizedWith configuring with --with-gtest-source=.../gtest-1.10/googletest the version reported is `googletest` instead of `1.10`.With configuring with --with-gtest-source=.../gtest-1.10/googletest the version reported is `googletest` instead of `1.10`.kea1.7.3https://gitlab.isc.org/isc-projects/kea/-/issues/954Support of google tests release 1.10.02019-12-12T11:23:25ZFrancis DupontSupport of google tests release 1.10.0kea1.7.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/206googletest version is not detected properly.2019-12-12T11:23:25ZTomek Mrugalskigoogletest version is not detected properly.When doing this on Mac OS 10.12.6:
```
autoreconf -i && ./configure --with-gtest-source=/Users/thomson/devel/gtest-1.8.0
```
I get the following (note the version is not detected as 1.8.0, but rather as "googletest")
```
Google Test:
...When doing this on Mac OS 10.12.6:
```
autoreconf -i && ./configure --with-gtest-source=/Users/thomson/devel/gtest-1.8.0
```
I get the following (note the version is not detected as 1.8.0, but rather as "googletest")
```
Google Test:
GTEST_VERSION: googletest
GTEST_INCLUDES: -I/Users/thomson/devel/gtest-1.8.0/googletest -I/Users/thomson/devel/gtest-1.8.0/googletest/include
GTEST_LDFLAGS:
GTEST_LDADD: $(top_builddir)/ext/gtest/libgtest.a
GTEST_SOURCE: /Users/thomson/devel/gtest-1.8.0/googletest
```kea1.7.3Tomek MrugalskiTomek Mrugalski