Kea issueshttps://gitlab.isc.org/isc-projects/kea/-/issues2018-12-12T23:14:46Zhttps://gitlab.isc.org/isc-projects/kea/-/issues/203sysrepo/netconf documentation improvements2018-12-12T23:14:46ZWlodzimierz Wencelsysrepo/netconf documentation improvementsSome of yang models have to be installed by hand and some of them are installed automatically as dependencies of those manually installed. So it would be nice that users guide would list every model that have to be installed by hand. I t...Some of yang models have to be installed by hand and some of them are installed automatically as dependencies of those manually installed. So it would be nice that users guide would list every model that have to be installed by hand. I think those models are: ietf-dhcpv6-server.yang
kea-dhcp4-server.yang
kea-dhcp6-server.yang
kea-dhcp-ddns.yang
kea-ctrl-agent.yang
ietf-inet-types.yang
ietf-yang-types.yang
for testing:
keatest-module.yang
Also docs is missing simple example how to start kea using sysrepocfg, it says ```Such changes can be done using sysrepocfg tool or remotely using any NETCONF client. For details, please see Sysrepo documentation``` and I really don't like the fact we are sending user to different documentation instead of having couple lines like:
```
sudo sysrepocfg -l 4 -d startup -f xml -i startup-4.xml kea-dhcp4-server
sudo sysrepocfg -l 4 -d running -f xml -i twopools-4.xml kea-dhcp4-server
```
with couple sentences explaining what "running" and "startup" datastores really are.Kea1.5-finalhttps://gitlab.isc.org/isc-projects/kea/-/issues/351keactrl + netconf should be documented2018-12-13T18:54:26ZTomek Mrugalskikeactrl + netconf should be documentedMarcin reported that keactrl's support for netconf is not documented. It should be.Marcin reported that keactrl's support for netconf is not documented. It should be.Kea1.5-finalhttps://gitlab.isc.org/isc-projects/kea/-/issues/3461.5.0 final sanity checks2018-12-12T16:08:57ZWlodzimierz Wencel1.5.0 final sanity checksGuys, please put your comments after sanity checks here :) if nothing will be release stopper wi will move it to 1.6.0Guys, please put your comments after sanity checks here :) if nothing will be release stopper wi will move it to 1.6.0Kea1.5-finalWlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/339doxygen errors2018-12-11T19:53:51ZWlodzimierz Wenceldoxygen errorswe have some doxygen errors https://jenkins.isc.org/job/Kea_doc/1479/warnings17Result/
fix before final?we have some doxygen errors https://jenkins.isc.org/job/Kea_doc/1479/warnings17Result/
fix before final?Kea1.5-finalFrancis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/338Bump up library version numbers for Kea 1.5.0 final release2018-12-11T19:53:40ZMarcin SiodelskiBump up library version numbers for Kea 1.5.0 final releaseThis is our usual work prior to the release to bump up library version numbers, install new headers and bump up hooks framework version.This is our usual work prior to the release to bump up library version numbers, install new headers and bump up hooks framework version.Kea1.5-finalMarcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/337lease_cmds incorrectly parses lease expiration time provided in the lease-add...2018-12-11T19:20:21ZMarcin Siodelskilease_cmds incorrectly parses lease expiration time provided in the lease-add commandleaseX-add commands allow for specifying a lease expiration time, which can be greater than 0xFFFFFFFF. However the code casts it to uint32_t value which causes an error claiming that the provided value is out of range.leaseX-add commands allow for specifying a lease expiration time, which can be greater than 0xFFFFFFFF. However the code casts it to uint32_t value which causes an error claiming that the provided value is out of range.Kea1.5-finalhttps://gitlab.isc.org/isc-projects/kea/-/issues/327Split transmission and reception control buffers2018-12-11T18:35:13ZFrancis DupontSplit transmission and reception control buffers!135 modifies the dhcp library code splitting the transmission and reception control buffers so it is possible to send and receive in parallel. This fix is correct because in the current code the control buffer is shared. Note these cont...!135 modifies the dhcp library code splitting the transmission and reception control buffers so it is possible to send and receive in parallel. This fix is correct because in the current code the control buffer is shared. Note these control buffers are in inet and inet6 packet filters. There is also an unused one in the interface manager.
This issue takes the dhcp library of !135 (after review, comment fix and unused removal).Kea1.5-finalFrancis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/309Remove all static kea versions from docs that refer to the "newest" release2018-12-06T15:27:52ZWlodzimierz WencelRemove all static kea versions from docs that refer to the "newest" releaseWe have some places in docs when kea version is static number, and it has to be updated during each release.
Replace all those with ```%keaversion;``` and add
```
<!DOCTYPE book [
<!ENTITY % keaversion SYSTEM "version.ent">
%keaversion;...We have some places in docs when kea version is static number, and it has to be updated during each release.
Replace all those with ```%keaversion;``` and add
```
<!DOCTYPE book [
<!ENTITY % keaversion SYSTEM "version.ent">
%keaversion;
]>
```
to xml file to fix this issue.Kea1.5-finalWlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/302remove src/bin/netconf/configs2018-12-11T17:08:43ZFrancis Dupontremove src/bin/netconf/configsThis directory contains only obsolete or available at a better place information.
I put it in 1.5final. If someone disagrees please explain why and close the issue.This directory contains only obsolete or available at a better place information.
I put it in 1.5final. If someone disagrees please explain why and close the issue.Kea1.5-finalFrancis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/299Remove kea-yang repo on github2018-12-06T11:17:27ZTomek MrugalskiRemove kea-yang repo on githubWe used to have this repo: https://github.com/isc-projects/kea-yang
If there's anything of value there, we should move it to a branch in gitlab.
After that the repo should be removed. It is confusing for external users.We used to have this repo: https://github.com/isc-projects/kea-yang
If there's anything of value there, we should move it to a branch in gitlab.
After that the repo should be removed. It is confusing for external users.Kea1.5-finalTomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/298sanity check comments after 1.5.0-beta22018-12-13T16:12:52ZWlodzimierz Wencelsanity check comments after 1.5.0-beta2Write your comments here - so it could be resolved before final. Post on jabber/mail if something is release blocking.Write your comments here - so it could be resolved before final. Post on jabber/mail if something is release blocking.Kea1.5-finalhttps://gitlab.isc.org/isc-projects/kea/-/issues/297Old text about multiple classes guards2018-12-11T11:12:59ZFrancis DupontOld text about multiple classes guardsFor instance from the guide:
If a subnet is associated with some classes, only the clients belonging to any of these classes can use this subnet. If there are no classes specified for a subnet, any client connected to a given shared net...For instance from the guide:
If a subnet is associated with some classes, only the clients belonging to any of these classes can use this subnet. If there are no classes specified for a subnet, any client connected to a given shared network can use this subnet.Kea1.5-finalFrancis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/issues/291Check support of sysrepo 0.7.72018-12-13T16:12:50ZFrancis DupontCheck support of sysrepo 0.7.7Clearly for 1.5 final. No problem is expected. The question to update installation docs is open.Clearly for 1.5 final. No problem is expected. The question to update installation docs is open.Kea1.5-finalhttps://gitlab.isc.org/isc-projects/kea/-/issues/289CQL upgrade script not working on ubuntu 18.042018-12-13T15:42:40ZTomek MrugalskiCQL upgrade script not working on ubuntu 18.04When trying to run unit-tests for !138 (compiled with --with-cql), I've encountered this unrelated issue:
```
cd src/bin/admin
make check
START TEST cql.unused_subnet_id_test
Processing /home/thomson/devel/kea-premium/src/share/databas...When trying to run unit-tests for !138 (compiled with --with-cql), I've encountered this unrelated issue:
```
cd src/bin/admin
make check
START TEST cql.unused_subnet_id_test
Processing /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_1.0_to_2.0.sh file...
Schema upgraded to 2.0
Lease DB version reported before upgrade: 2.0
Processing /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_1.0_to_2.0.sh file...
This script upgrades 1.0 to 2.0. Reported version is 2.0. Skipping upgrade.
Processing /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh file...
Exporting host_reservation data to /home/thomson/devel/kea-premium/src/share/database/scripts/cql/cql_export.csv ...
Using 7 child processes
Starting copy of keatest.host_reservations with columns [id, host_ipv4_subnet_id, host_ipv6_subnet_id, option_subnet_id].
Processed: 5 rows; Rate: 39 rows/s; Avg. rate: 39 rows/s
5 rows exported to 1 files in 0.136 seconds.
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 191: /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: let: not found
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 217: /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: let: not found
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 217: /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: let: not found
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 217: /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: let: not found
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 217: /home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: let: not found
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 75: [: /home/thomson/devel/kea-p: unexpected operator
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 80: [: /home/thomson/devel/kea-p: unexpected operator
Data Migration FAILURE! Line# 0, too few values, wrong or corrupt file
/home/thomson/devel/kea-premium/src/share/database/scripts/cql/upgrade_2.0_to_3.0.sh: 105: exit: Illegal number: -1
Lease DB version reported after upgrade: 3.0
Exporting host_reservation data to /home/thomson/devel/kea-premium/src/bin/admin/tests/data/cql.subnet_id_test.csv ...
Assertion failure: 0 != 1, for val1=0, val2=1
export file does not match reference file, expected exit code 0, actual 1
FAILED cql.unused_subnet_id_test
```
this is on ubuntu 18.04. Note the /bin/sh is coming from dash package, it is not a bash script.Kea1.5-finalTomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/288RFC8415 released update users guide accordingly2018-12-06T16:03:59ZWlodzimierz WencelRFC8415 released update users guide accordinglyUsers guide mention some of RFCs (e.g. 3315 3633) that are obsolete by new RFC 8415. We need this updated.Users guide mention some of RFCs (e.g. 3315 3633) that are obsolete by new RFC 8415. We need this updated.Kea1.5-finalMarcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/kea/-/issues/286Update "Building Requirements" and "Configure Before the Build" with info abo...2018-12-04T20:49:53ZWlodzimierz WencelUpdate "Building Requirements" and "Configure Before the Build" with info about radius and netconfradius and netconf needs additional 3rd party dependencies, update kea guide section accordingly.radius and netconf needs additional 3rd party dependencies, update kea guide section accordingly.Kea1.5-finalWlodzimierz WencelWlodzimierz Wencelhttps://gitlab.isc.org/isc-projects/kea/-/issues/284need dhcp6 example for netconf2018-12-11T20:43:43ZTomek Mrugalskineed dhcp6 example for netconfThe examples in doc/examples/netconf need some cleanup:
- there should be simple-dhcp6.json that demonstrates how to use DHCPv6
- the simple.json should be removed (it is anything but simple: defines all servers, including those that ar...The examples in doc/examples/netconf need some cleanup:
- there should be simple-dhcp6.json that demonstrates how to use DHCPv6
- the simple.json should be removed (it is anything but simple: defines all servers, including those that are not supported - D2 and CA), also defines hooksKea1.5-finalTomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/issues/278Add documention on developing your own packet queue implementation to develop...2018-12-10T20:24:14ZThomas MarkwalderAdd documention on developing your own packet queue implementation to developer's guideDeveloper's guide needs a section that discusses PacketQueue derivations and how to register/unregister them via hook library.Developer's guide needs a section that discusses PacketQueue derivations and how to register/unregister them via hook library.Kea1.5-finalThomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/277Finalize whether Congestion Handling is enabled or disabled by default.2018-12-10T16:20:58ZThomas MarkwalderFinalize whether Congestion Handling is enabled or disabled by default.Based on Beta2 results, we need to decide whether Congestion Handling is enabled or disabled by default.Based on Beta2 results, we need to decide whether Congestion Handling is enabled or disabled by default.Kea1.5-finalThomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/issues/271Trouble building 1.5.0beta1 kea-netconf plugin2018-12-12T23:13:30ZGhost UserTrouble building 1.5.0beta1 kea-netconf pluginDuplicated from my post on the isc forum...
Hi,
I’ve been trying to build this to test Sysrepo integration, and the build fails as follows:
make[2]: Entering directory ‘/root/kea-1.5.0-beta1/src/bin/netconf’
CXX control_socket.lo
CXX ...Duplicated from my post on the isc forum...
Hi,
I’ve been trying to build this to test Sysrepo integration, and the build fails as follows:
make[2]: Entering directory ‘/root/kea-1.5.0-beta1/src/bin/netconf’
CXX control_socket.lo
CXX http_control_socket.lo
CXX stdout_control_socket.lo
CXX unix_control_socket.lo
CXX netconf.lo
In file included from netconf.cc:12:0:
…/…/…/src/bin/netconf/netconf.h:17:10: fatal error: sysrepo-cpp/Session.h: No such file or directory
#include <sysrepo-cpp/Session.h>
^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
The referenced Session.h is not part of the Kea source. I’m also unable to find the file in the source for sysrepo, netopeer2 or any of the other dependencies.
Any help on how to build greatly appreciated.
Thanks,
IanKea1.5-final