dhcp_ddns::NameChangeSender send queue operations are not thread-safe
While working on a DDNS-related ticket it occurred to me that send queue operations in dhcp_ddns::NameChangeSender, which Kea-dhcpX servers use to talk to D2, are not thread-safe. NameChangeSender::send_queue_ is a std::deque<> instance. Each packet thread would be pushing NCRs onto the queue while the main thread is popping them off the front.
In the meantime, DDNS and MT, likely do not play well together.
Edited by Thomas Markwalder