Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Kea
Kea
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 415
    • Issues 415
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 67
    • Merge Requests 67
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • KeaKea
  • Issues
  • #1316

Closed
Open
Opened Jul 03, 2020 by Francis Dupont@fdupontDeveloper

switch to an unordered map for LabeledValueSet

Currently a private map keyed by unsigned int is used and no iterating method is defined so it is safe and perhaps faster to use an unordered map i.e. a hash table instead a balanced binary search tree.

LabeledValueSet is used in state models which are themselves used to handle HTTP and JSON input.

Note an alternative is to get rid of the LabeledValueSet and to use directly an unordered map in StateSet as I am not happy with the StateSet::getState() method performance which is called in the runModel loop.

Or moved for LabeledValueSet to a template taking a shared pointer to LabeledValue derived object type parameter and of course LabelValuePtr for default.

Edited Jul 03, 2020 by Francis Dupont
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Outstanding
Milestone
Outstanding
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/kea#1316