Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Kea
Kea
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 415
    • Issues 415
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 67
    • Merge Requests 67
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • KeaKea
  • Issues
  • #1353

Closed
Open
Opened Jul 29, 2020 by Francis Dupont@fdupontDeveloper

Guarded subnets must stay allowed

Just after the host reservation lookup the query classes can be cleared and evaluated again with the host reservation classes. During this it is possible to have a selected subnet with a guard (client-class) which finished to not be allowed (i.e. the guard client class is no longer in the query classes). The whole code assumes the selected subnet is allowed so it can lead to very incorrect behavior.

The fix is easy: just unconditionally add again the guard class (the class add method puts its argument once in the classes: if it is already in them the method does nothing).

Or alternatively make all possible branches to handle this case: the selected subnet is no longer allowed so can be used only in a shared network and a new "start" subnet must be found.

Edited Aug 03, 2020 by Francis Dupont
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Kea1.9-backlog
Milestone
Kea1.9-backlog
Assign milestone
Time tracking
None
Due date
None
Reference: isc-projects/kea#1353