Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 575
    • Issues 575
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • KeaKea
  • Issues
  • #143
Closed
Open
Issue created Sep 27, 2018 by Tomek Mrugalski@tomek🛰Owner

PgSQL backend may terminate immediately when connection is lost

The code in pgsql_connection.cc may call exit() under certain conditions. There are couple areas for improvement here:

  1. this was perhaps acceptable behavior when we didn't have any connection failure handling routines, but wasn't that improved in 1.3?

  2. calling exit() explicitly is not acceptable. If we really want to shut down, we should go through a graceful shutdown (unload hooks, close connections, let HA partner know we're going down, etc.)

  3. if somehow there are good justifications why 1 and 2 can be ignored, at the very least we need to print out an error and explain why we are terminating.

On a related note, MySQL also does have DB connection lost handling code and it doesn't call exit.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking