Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 519
    • Issues 519
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 55
    • Merge requests 55
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • KeaKea
  • Issues
  • #174

Closed
Open
Created Oct 17, 2018 by Francis Dupont@fdupontDeveloper

Warning for unused trace levels

Some compilers and static analyzers emit this kind of warnings:

In file included from eval_log.cc:11:0:
../../../src/lib/eval/eval_log.h:22:11: warning: 'isc::dhcp::EVAL_DBG_TRACE' defined but not used [-Wunused-variable]
 const int EVAL_DBG_TRACE = isc::log::DBGLVL_TRACE_BASIC;
           ^

A simple solution should be to make them extern for the declaration and move the definition to the xxx_log.cc as it is done for MessageIDs.

I'd like to get an opinion from QA people as they are impacted by this. BTW if adopted it should be a good item for a final milestone.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking