missing references in option code points
There is inconsistency in comments for DHCPv4 and DHCPv6 Option codes - enum DHCPOptionType
in dhcp4.h
and enum DHCPv6OptionType
in dhcp6.h
respectively.
In comments, there are references to RFCs for each Option. Some references are missing and some are not up to date.
For instance the DHCPv4 option 146 DHO_RDNSS_SELECT has no comment giving its source (RFC 6731) and the last source does not apply (option 145 DHO_FORCERENEW_NONCE_CAPABLE RFC 5859).
BTW sources are available in the IANA option code directory [https://www.iana.org/assignments/bootp-dhcp-parameters/bootp-dhcp-parameters.xhtml#options]
Even it is in the code (vs doc directory) it is clearly a documentation issue.
Edited by Piotrek Zadroga