Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 560
    • Issues 560
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 65
    • Merge requests 65
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • KeaKea
  • Issues
  • #2002
Closed
Open
Issue created Jul 29, 2021 by Tomek Mrugalski@tomek🛰Owner

LQ tests too strict (off by 1 failure)

On one case lease query premium tests failed with the following error:

08:16:19  [ RUN      ] LeaseQueryImpl6ProcessTest.queryByClientIdActiveLeases
08:16:19  ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:1585: Failure
08:16:19  Expected equality of these values:
08:16:19    100
08:16:19    cltt_opt->getValue()
08:16:19      Which is: 101
08:16:19  ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:401: Failure
08:16:19  Expected equality of these values:
08:16:19    lease->valid_lft_ - elapsed
08:16:19      Which is: 3500
08:16:19    iaaddr_opt->getValid()
08:16:19      Which is: 3499
08:16:19  ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:402: Failure
08:16:19  Expected equality of these values:
08:16:19    lease->preferred_lft_ - elapsed
08:16:19      Which is: 3500
08:16:19    iaaddr_opt->getPreferred()
08:16:19      Which is: 3499
08:16:19  ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:417: Failure
08:16:19  Expected equality of these values:
08:16:19    lease->valid_lft_ - elapsed
08:16:19      Which is: 3400
08:16:19    iaprefix_opt->getValid()
08:16:19      Which is: 3399
08:16:19  ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:418: Failure
08:16:19  Expected equality of these values:
08:16:19    lease->preferred_lft_ - elapsed
08:16:19      Which is: 3400
08:16:19    iaprefix_opt->getPreferred()
08:16:19      Which is: 3399
08:16:19  [  FAILED  ] LeaseQueryImpl6ProcessTest.queryByClientIdActiveLeases (1 ms)

Details: jenkins

This looks like a timing error that, depending on when exactly the code get run, the values may be off by 1.

Edited Jul 29, 2021 by Tomek Mrugalski
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking