LQ tests too strict (off by 1 failure)
On one case lease query premium tests failed with the following error:
08:16:19 [ RUN ] LeaseQueryImpl6ProcessTest.queryByClientIdActiveLeases
08:16:19 ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:1585: Failure
08:16:19 Expected equality of these values:
08:16:19 100
08:16:19 cltt_opt->getValue()
08:16:19 Which is: 101
08:16:19 ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:401: Failure
08:16:19 Expected equality of these values:
08:16:19 lease->valid_lft_ - elapsed
08:16:19 Which is: 3500
08:16:19 iaaddr_opt->getValid()
08:16:19 Which is: 3499
08:16:19 ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:402: Failure
08:16:19 Expected equality of these values:
08:16:19 lease->preferred_lft_ - elapsed
08:16:19 Which is: 3500
08:16:19 iaaddr_opt->getPreferred()
08:16:19 Which is: 3499
08:16:19 ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:417: Failure
08:16:19 Expected equality of these values:
08:16:19 lease->valid_lft_ - elapsed
08:16:19 Which is: 3400
08:16:19 iaprefix_opt->getValid()
08:16:19 Which is: 3399
08:16:19 ../../../../../../../../premium/src/hooks/dhcp/lease_query/tests/lease_query_impl6_unittest.cc:418: Failure
08:16:19 Expected equality of these values:
08:16:19 lease->preferred_lft_ - elapsed
08:16:19 Which is: 3400
08:16:19 iaprefix_opt->getPreferred()
08:16:19 Which is: 3399
08:16:19 [ FAILED ] LeaseQueryImpl6ProcessTest.queryByClientIdActiveLeases (1 ms)
Details: jenkins
This looks like a timing error that, depending on when exactly the code get run, the values may be off by 1.