Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 560
    • Issues 560
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 69
    • Merge requests 69
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source ProjectsISC Open Source Projects
  • KeaKea
  • Issues
  • #2020
Closed
Open
Issue created Aug 05, 2021 by Michael McNally@McNally

Is there a problem with argument ordering in HOOKS_CALLOUT_ERROR and HOOKS_CALLOUT_EXCEPTION?

Shawn R. writes, on Support #18870:

The arguments to the error messages for HOOKS_CALLOUT_ERROR and HOOKS_CALLOUT_EXCEPTION are in the wrong order. The first two argument (index and hook point) provided by the code (callout_manager.cc:call_callouts() are swapped compared to the messages.

You may want to change the order in the message to make them consistent with HOOKS_CALLOUT_CALLED.

I presume a determination will be fairly easy to reach on the option-ordering issue (though it may be sticky to fix depending on how many are already using the current ordering.) But he came across this while in the process of troubleshooting a customer issue for his employers. Since that comprises a separate issue, I have broken it out into a separate ticket, #2021 (closed).

Edited Aug 05, 2021 by Michael McNally
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking