Change or remove misleading DHCP4_NCR_CREATE log message
The DNCHP4_NCR_CREATE log statement, emitted by kea-dhcp4, such as this one:
2022-02-07 14:37:52.489 DEBUG DHCP4_NCR_CREATE [hwtype=1 ...], cid=[...], tid=0x6296db4e: DDNS updates enabled, therefore sending name change requests
is misleading. The text needs to be updated. It actually only means that we are calling the function, Dhcpv4Srv::createNameChangeRequests(), which MAY create NCRs. It does not accurately reflect whether or not updates are enabled or that we are in fact creating them. It used to mean this but unfortunately the it was not updated appropriately when the behavior was modified.
The afore-mentioned function will only create NCR(s) the following criteria is true:
Updates are enabled - This means that both "dhcp-ddns" level "enable-updates" AND "ddns-send-udpates" (which can be set scoped down to the subnet level) are true.
There is no pre-existing lease OR ddns-update-on-renew is true OR there is an existing lease but the FQDN data has changed
It should probably be removed as we will emit DHCPSRV_QUEUE_NCR messages at the same debug level when we actually create NCRs to send to D2.
I labeled this as customer because it is contributing to confusion on a support issue.