keactrl should better handle disabled services
This is a follow-up coming form #186 (closed) review.
There's a section in keactrl.conf that has flags for each daemon:
# Start DHCPv4 server? dhcp4=yes # Start DHCPv6 server? dhcp6=yes # Start DHCP DDNS server? dhcp_ddns=no # Start Control Agent? ctrl_agent=yes # Start Netconf? netconf=no
When a service is set to false, there's no way to start it using keactrl. For example:
root@billabong:/opt186# sbin/keactrl start -s netconf root@billabong:/opt186# sbin/keactrl stop -s netconf INFO/keactrl: kea-netconf isn't running.
Note the start command. It quits silently without starting the netconf service.
IMHO the flags should govern whether the service is started when ALL services are started (keactrl start). There should always be a way to start the service manually.
If you strongly disagree with this, at the very least keactrl should print out why it didn't even try to start the service.