Update CONTRIBUTING.md with instructions that allow code review and merging from external MR
Whenever there is an external contribution, we are required to create another MR with the changes from the original MR. This could be avoided, and the entire code review could take place in the original MR if the contributor follows some steps which could be detailed in CONTRIBUTING.md:
-
Give ISC access to the forked project. This is required to see pipeline status and to merge code.
From the sidebar on the project page, go to
Manage->Members->Invite a group:-
Select a group to invite:ISC Open Source Projects -
Select a role:Developer - Click
Invite.
-
-
Configure Danger. From the sidebar on the project page, go to
Settings->Access Tokens->Add new token:-
Token name:danger -
Select a role:Developer -
Select scopes:[api] - Click
Create project access token. - Copy the token's value.
Then, go to
Settings->CI/CD->Variables->Add variable: -
Visibility:Masked -
Key:DANGER_GITLAB_API_TOKEN -
Value: copied token value - Click
Add variable.
-