Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 501
    • Issues 501
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 53
    • Merge requests 53
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • KeaKea
  • Issues
  • #535
Closed
Open
Created Mar 14, 2019 by Wlodzimierz Wencel@wlodekMaintainer

checks of t1-percent and t2-percent values in config backend not sufficient

our Use's Guide:

t1-percent - the percentage of the valid lease time to use for T1. It is expressed as a real number between 0.0 and 1.0 and must be less than t2-percent. The default value is 0.50 per RFC 2131.
t2-percent - the percentage of the valid lease time to use for T2. It is expressed as a real number between 0.0 and 1.0 and must be greater than t1-percent. The default value is .875 per RFC 2131.

I was able to save into database t2-percent smaller than t1-percent - after sending config-reload command kea accepted such values as correct (haven't try to send traffic)

  1. command set:
{
  "arguments": {
    "remote": {
      "type": "mysql"
    },
    "server-tags": [
      "abc"
    ],
    "shared-networks": [
      {
        "calculate-tee-times": true,
        "interface": "enp0s9",
        "name": "net1",
        "subnet4": [
          {
            "interface": "enp0s9",
            "subnet": "192.8.0.0/24"
          }
        ],
        "t1-percent": 0.5,
        "t2-percent": 0.1
      }
    ]
  },
  "command": "remote-network4-set"
}
  1. response:
{
  "arguments": {
    "shared-networks": [
      {
        "name": "net1"
      }
    ]
  },
  "result": 0,
  "text": "IPv4 shared network successfully set."
}
  1. config-reload
  2. config-get:
      "shared-networks": [
        {
          "calculate-tee-times": true,
          "interface": "enp0s9",
          "name": "net1",
          "option-data": [],
          "relay": {
            "ip-addresses": []
          },
          "subnet4": [
            {
              "4o6-interface": "",
              "4o6-interface-id": "",
              "4o6-subnet": "",
              "id": 3,
              "interface": "enp0s9",
              "option-data": [],
              "pools": [],
              "relay": {
                "ip-addresses": []
              },
              "reservations": [],
              "subnet": "192.8.0.0/24"
            }
          ],
          "t1-percent": 0.5,
          "t2-percent": 0.1
        }
      ],
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking