Address remaing invocations of assert() in our code base

I attached a list of assert() invocations in our code (excluding any that might be unit tests)

asserts.txt

We need to decide what we want to do with these. #730 will introduce a replacement macro, isc_assert_throw, which is an alternative.