Kea merge requestshttps://gitlab.isc.org/isc-projects/kea/-/merge_requests2022-01-12T14:19:34Zhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1541Resolve "error in build-in help of configure script"2022-01-12T14:19:34ZFrancis DupontResolve "error in build-in help of configure script"Closes #2218Closes #2218kea2.1.2Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1540Resolve "ARM shows "option-data-list" field instead of "option-data" for rese...2022-01-14T14:04:10ZFrancis DupontResolve "ARM shows "option-data-list" field instead of "option-data" for reservation-add"Closes #2233Closes #2233kea2.1.2Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1539Resolve "95-pg-cb-v4-1-basic-implemetation-with-queries2022-01-18T18:19:11ZThomas MarkwalderResolve "95-pg-cb-v4-1-basic-implemetation-with-queriesContributes to #95
Creates initial DHCPV4 code base and SQL queries.Contributes to #95
Creates initial DHCPV4 code base and SQL queries.kea2.1.2Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1538OBSOLETE "postgresql CB missing some columns"2022-01-07T20:41:59ZThomas MarkwalderOBSOLETE "postgresql CB missing some columns"Closes #2244Closes #2244kea2.1.2Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1537Resolve "19485-kea-premium contribution"2022-01-10T15:04:49ZRazvan BecheriuResolve "19485-kea-premium contribution"Closes #2208Closes #2208kea2.1.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1535Resolve "DHCPv6 request dropped with rfc7217 link-local addresses and too lon...2022-01-10T08:54:21ZRazvan BecheriuResolve "DHCPv6 request dropped with rfc7217 link-local addresses and too long flex-id"Closes #2201Closes #2201kea2.1.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1534Draft: Resolve "Prepare subnet selection speedup: patrica trees"2022-01-18T16:22:57ZFrancis DupontDraft: Resolve "Prepare subnet selection speedup: patrica trees"Closes #2256Closes #2256kea2.1.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1533Draft: Resolve "Prepare subnet selection speedup: auxiliary tables"2022-01-11T22:30:08ZFrancis DupontDraft: Resolve "Prepare subnet selection speedup: auxiliary tables"Closes #2255Closes #2255kea2.1.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1532Resolve "Prepare subnet selection speedup: simplified collections"2022-01-18T16:35:33ZFrancis DupontResolve "Prepare subnet selection speedup: simplified collections"Closes #2254Closes #2254kea2.1.2Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1530kea-admin lease-upload pgsql2022-01-23T21:49:19ZAndrei Pavelandrei@isc.orgkea-admin lease-upload pgsqlPart of #2039.Part of #2039.kea2.1.2https://gitlab.isc.org/isc-projects/kea/-/merge_requests/1529kea-admin lease-upload mysql2022-01-21T16:27:19ZAndrei Pavelandrei@isc.orgkea-admin lease-upload mysqlPart of #2039.
`upload` seems like the best antonym to `dump` that shows direction.
* [x] a2aa65f7fc kea-admin lease-upload mysql
* This approach tries to do as little work as possible in shell and offload everything as quickly as po...Part of #2039.
`upload` seems like the best antonym to `dump` that shows direction.
* [x] a2aa65f7fc kea-admin lease-upload mysql
* This approach tries to do as little work as possible in shell and offload everything as quickly as possible to SQL. Since there is no procedure can accept any input at least not without quotes around it, the only thing kea-admin does is put quotes around values of columns that are varchars or around values that need to be further processed in SQL.
* This approach does not assume a fixed position of columns in the CSV file, but searches for it every time when it needs to. It only needs to do that when stringifying for the reason above. I don't necessarily want it this way so I can put static columns in there if the reviewer wants. If performance is an issue, you should know that not the ability to dynamically search for columns is not a great burden, but rather the stringification/quoting itself, or the fact that we're not doing batch lease upload, but rather one at a time. I haven't considered batch SQL very much, because I'm not familiar with how portable it is across MySQL versions and how much of a speedup it would bring.
* `dump_type` -> `dhcp_version` because now it's also upload type not only dump type
* [x] f6a9a0955a kea-admin lease-upload mysql tests
* removed some `tmp_file` references that weren't used anymore
* [x] 2fb4f192a9 document kea-admin lease-upload
* [x] 5378a40679 add ChangeLog entrykea2.1.2Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1528kea-admin lease-dump pgsql2022-01-18T19:21:31ZAndrei Pavelandrei@isc.orgkea-admin lease-dump pgsqlCloses #2038.
* [x] 2321e4e27f [#2038] kea-admin lease-dump pgsql outputs a memfile-ready CSV
* [x] 8bf454365e [#2038] kea-admin lease-dump pgsql tests
* Since `*sql.*dump_test.reference.csv` files need to be the same now i.e. in memf...Closes #2038.
* [x] 2321e4e27f [#2038] kea-admin lease-dump pgsql outputs a memfile-ready CSV
* [x] 8bf454365e [#2038] kea-admin lease-dump pgsql tests
* Since `*sql.*dump_test.reference.csv` files need to be the same now i.e. in memfile format, I've fused MySQL and PostgreSQL versions into a single set of files.
* Moved away from the `SELECT timestampz` method because it modified the reference CSV file and this is both inelegant and more difficult to do with the common CSV explained above.
* [x] 1b8d1df349 [#2038] allow passing of extra parameters to *sql_execute* in admin-utils.sh while keeping credentials
* In one test, `--field-separator=','` is passed to `pgsql_execute` instead of manually transforming postgres's `|` separators into commas, so that the test is as close to what kea-admin does as possible. Passing extra parameters was not possible before because you would have to choose between passing no parameters or providing your own user and password. Since I did not have the user and password in the test file, I thought hardcoding `keatest` would be a hack so I did this change instead which allows you to pass any parameter to `pgsql_execute` while still keeping credentials. I then changed the MySQL functions for consistency. A quick search will show that there are no other uses of any `*sql_execute*` call with parameters so that's why I consider this change to be safe and in the spirit of dead code cleanup. It must have had historic use. If you do not feel comfortable with this change, we can very well revert it and do the separator change manually.kea2.1.2Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1526Resolve "d2srv.dox missing from tarball"2022-01-03T10:22:14ZRazvan BecheriuResolve "d2srv.dox missing from tarball"Closes #2241Closes #2241kea2.1.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1523Resolve "Documentation cleanup about EOL Kea versions"2021-12-15T19:15:10ZSuzanne GoldlustResolve "Documentation cleanup about EOL Kea versions"Closes #2142Closes #2142kea2.1.2Suzanne GoldlustSuzanne Goldlusthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1519Resolve "add hwtype and hwaddr_source columns to memfile"2022-01-09T10:16:32ZAndrei Pavelandrei@isc.orgResolve "add hwtype and hwaddr_source columns to memfile"Closes #2236.
* [x] 8e452b18448ce0bed3e8e2ae7d3971d8d6bec284 add hwtype,hwaddr_source to v6 memfile
* [x] 7afe151186319668ce31f153863be78fac2ce8d3 adapt existing tests to the two columns
* [x] a75e20521bb476000311777c396118d98d5cb1c5 ...Closes #2236.
* [x] 8e452b18448ce0bed3e8e2ae7d3971d8d6bec284 add hwtype,hwaddr_source to v6 memfile
* [x] 7afe151186319668ce31f153863be78fac2ce8d3 adapt existing tests to the two columns
* [x] a75e20521bb476000311777c396118d98d5cb1c5 split memfile versions into v4 or v6 because they have diverged some time ago and log messages were being contradictory for v6:
```
WARN DHCPSRV_MEMFILE_NEEDS_UPGRADING version of lease file: /tmp/kea-dhcp6.csv schema is earlier than version 4.0
WARN DHCPSRV_MEMFILE_CONVERTING_LEASE_FILES running LFC now to convert lease files to the current schema: 2.1
```
* [x] e659243eb44f0ee6552b0ab1ddbea8c750a5a5f7 add tests to check that the versions from the two messages match
* [x] 26f85a67cf182fdefddacf5f94f49bbe476d7878 add a changelog entry
* [x] 717e64d0ec464a583fd97ee61f146c40c5f6a010 add unit tests for complex user contexts - user contexts with two or more entries are not correctly loaded from memfile, see unit test for details; i did not proceed with a fix because it is complex work and deserves its own issue; opened #2257kea2.1.2Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1511Resolve "Support RFC4361 for dual stack DDNS"2021-11-29T18:35:24ZThomas MarkwalderResolve "Support RFC4361 for dual stack DDNS"Closes #1934
Adds support for DUIDs embedded within DHCPv4 Client IDs. Uses patch supplied by John Dickinson.Closes #1934
Adds support for DUIDs embedded within DHCPv4 Client IDs. Uses patch supplied by John Dickinson.kea2.1.2Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1510Resolve "CA: store credentials in file"2022-01-21T18:29:43ZFrancis DupontResolve "CA: store credentials in file"Closes #2006Closes #2006kea2.1.2Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1509Resolve "Correct Kea ARM auth option code is 11, not 10."2022-01-20T16:06:01ZTomek MrugalskiResolve "Correct Kea ARM auth option code is 11, not 10."Closes #2207Closes #2207kea2.1.2Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1507Resolve "CI job to detect that dhcpdb_create scripts and upgrade scripts are ...2022-01-21T12:30:20ZAndrei Pavelandrei@isc.orgResolve "CI job to detect that dhcpdb_create scripts and upgrade scripts are in sync"Closes #2205.
Multiple ways to run the script. When run without parameters, the logic is:
1. Look at all the changed files in src/share/database/scripts.
1. If it is a dhcpdb_create script.
1. Then compare it with the latest upgrade ...Closes #2205.
Multiple ways to run the script. When run without parameters, the logic is:
1. Look at all the changed files in src/share/database/scripts.
1. If it is a dhcpdb_create script.
1. Then compare it with the latest upgrade script, but only the common sections.
1. If it is an upgrade script.
1. Then compare it with dhcpdb_create, but only the common sections.
The common sections are decided based on the python difflib's library.
Please ask me to regenerate the CI image before you review. It needs python3 installed as you may have noticed in the CI results.
Disclaimers:
* line numbers cannot be easily shown because of how python difflib works
* you might be tempted to test by adding something to the end of a `dhcpdb_create` script. This will not work because that is outside of the common sections. Add to a common section instead.kea2.1.2Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1503Draft: fix formatting tools on premium or other repos2022-07-04T15:37:56ZAndrei Pavelandrei@isc.orgDraft: fix formatting tools on premium or other reposPart of #2200.Part of #2200.kea2.1.2