Kea merge requestshttps://gitlab.isc.org/isc-projects/kea/-/merge_requests2020-01-29T19:39:04Zhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/653Resolve "make alloc engine and address allocation thread safe"2020-01-29T19:39:04ZRazvan BecheriuResolve "make alloc engine and address allocation thread safe"Closes #890Closes #890kea1.7.5Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1318Resolve "make check in src/bin/admin deletes repo"2021-07-05T08:56:20ZAndrei Pavelandrei@isc.orgResolve "make check in src/bin/admin deletes repo"Closes #1961Closes #1961kea1.9.10Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/932Resolve "Make Dhcp[46]SrvD2Test.forceUDPSendFailure to display the reason why...2020-09-08T14:58:00ZFrancis DupontResolve "Make Dhcp[46]SrvD2Test.forceUDPSendFailure to display the reason why startD2 failed"Closes #1357Closes #1357kea1.9.0Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/233Resolve "make distcheck fails on fedora 29 (automake 1.16)"2019-03-13T13:23:31ZFrancis DupontResolve "make distcheck fails on fedora 29 (automake 1.16)"Part of #441Part of #441Kea1.6Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1551Resolve "Make forensic log timestamp configurable"2022-01-21T16:55:00ZRazvan BecheriuResolve "Make forensic log timestamp configurable"Closes #2208Closes #2208kea2.1.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1268Resolve "make gtests, shell tests, python tests run sequentially (not concurr...2021-07-05T12:56:49ZAndrei Pavelandrei@isc.orgResolve "make gtests, shell tests, python tests run sequentially (not concurrently)"Closes #1642
This change is mostly to not force `make distcheck -j 1` and to allow `make distcheck -j 2` for faster Jenkins testing.
Managed to do it without splitting into separate directories. All that needs to be done is to add the ...Closes #1642
This change is mostly to not force `make distcheck -j 1` and to allow `make distcheck -j 2` for faster Jenkins testing.
Managed to do it without splitting into separate directories. All that needs to be done is to add the scripts to `TESTS` and to `check_SCRIPTS`. Both were missing.
https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html
> If the special variable TESTS is defined, its value is taken to be a list of programs or scripts to run in order to do the testing.
https://www.gnu.org/software/automake/manual/html_node/Scripts.html
> Scripts that need not be installed can be listed in noinst_SCRIPTS, and among them, those which are needed only by ‘make check’ should go in check_SCRIPTS.
Apart from that, I felt like these `Makefile.am`s could use more ordering. Here is the logic that I used:
* some have `SUBDIRS = .`, some don't. For consistency, I added it everywhere. It shouldn't make a real diference.
* ordered automake statements in the order that you would normally call upon them as an autotools user:
* EXTRA_DIST - `make distdir`
* TESTS_ENVIRONMENT - `make check` (needed when called with valgrind I think)
* SHTESTS + check_SCRIPTS + TESTS - `make check`
* DISTCLEANFILES - `make clean`
* noinst_SCRIPTS - `make install`
* and then for gtest (C++ tests):
* PROGRAMTESTS - `make check` with gtest enabled
* DISTCLEANFILES - `make clean` with gtest enabled
* noinst_SCRIPTS - `make install` with gtest enabled
The shell and python tests are now considered proper automake tests instead of some random strings that we run alongside `make check`. You'll see in the libraries that contain shell tests or python tests that instead of `1 test passed` you get `All 2 tests passed` refering to C++ tests (1) and shell/python tests (2). Not sure on what implications this will have, but I'm thinking it can only be good.
Apart from that, some tests now failed because they some variables different paths in `make distcheck` versus `make check`. In one instance, these variables pointed to the installation directory which was empty, and is most of the time so. So to avoid this error, I replaced a conditional assignment of KEA_*_DIR to always point to builddir. This seems to have solved the issue.
distcheck run in jenkins on this branch: https://jenkins.aws.isc.org/view/Kea-manual/job/kea-manual/job/distcheck/22/kea1.9.10Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1747Resolve "Make hammer able to build 2.0.3 packages on RHEL 8"2022-07-25T15:07:56ZAndrei Pavelandrei@isc.orgResolve "Make hammer able to build 2.0.3 packages on RHEL 8"Closes #2506Closes #2506kea2.0.3Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1353Resolve "make install doesn't work with netconf enabled"2021-07-30T17:22:22ZAndrei Pavelandrei@isc.orgResolve "make install doesn't work with netconf enabled"Closes #2008Closes #2008kea1.9.10Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1582Resolve "Make Kea compatible with OpenSSL 3.0"2022-06-24T15:49:13ZFrancis DupontResolve "Make Kea compatible with OpenSSL 3.0"Closes #1614Closes #1614kea2.1.7Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/298Resolve "Make kea to build on last macOS / Xcode"2019-05-23T09:40:16ZFrancis DupontResolve "Make kea to build on last macOS / Xcode"Closes #561Closes #561Kea1.6Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1789Resolve "Make Kea use its own image for Danger in CI"2022-09-26T13:31:41ZAndrei Pavelandrei@isc.orgResolve "Make Kea use its own image for Danger in CI"Closes #2559.
* [x] Gitlab CI: leave danger step to the default Kea CI imageCloses #2559.
* [x] Gitlab CI: leave danger step to the default Kea CI imageAndrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/591Resolve "make libdhcp++ thread safe"2020-01-17T12:18:11ZRazvan BecheriuResolve "make libdhcp++ thread safe"Closes #889Closes #889kea1.7.4Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/842Resolve "Make LibraryHandle::getParameters() public"2020-07-13T13:19:45ZFrancis DupontResolve "Make LibraryHandle::getParameters() public"Closes #1182Closes #1182kea1.7.10Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/571Resolve "make memfile thread safe"2020-01-23T13:47:54ZFrancis DupontResolve "make memfile thread safe"Closes #894Closes #894kea1.7.2Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1470Resolve "Make Parser slightly more noob-friendly"2021-12-17T15:35:25ZAndrei Pavelandrei@isc.orgResolve "Make Parser slightly more noob-friendly"Closes #2084
The pattern for this implementation is well isolated, it only adds on top of the current parser implementation. For every parent element that has `COMMA` used in one of his children, add a recursive parser entry that ends i...Closes #2084
The pattern for this implementation is well isolated, it only adds on top of the current parser implementation. For every parent element that has `COMMA` used in one of his children, add a recursive parser entry that ends in COMMA. It usually looks like this:
```
element: element
| element COMMA element_param
| element COMMA // <-- the added line
;
```kea2.1.2Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/220Resolve "Make perfdhcp build optional."2019-02-05T22:19:12ZFrancis DupontResolve "Make perfdhcp build optional."Closes #340Closes #340Kea1.6Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/592Resolve "make stats mgr thread safe"2020-02-06T16:22:38ZRazvan BecheriuResolve "make stats mgr thread safe"Closes #891Closes #891kea1.7.2Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/785Resolve "make the HA hook multi-threading safe"2020-05-21T16:12:18ZFrancis DupontResolve "make the HA hook multi-threading safe"Closes #1219Closes #1219kea1.7.8Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/775Resolve "make the HA hook multi-threading safe"2020-05-18T17:45:50ZRazvan BecheriuResolve "make the HA hook multi-threading safe"Closes #1219Closes #1219kea1.7.8Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/762Resolve "make the HA hook multi-threading safe"2020-05-18T14:21:46ZFrancis DupontResolve "make the HA hook multi-threading safe"Part of #1219Part of #1219kea1.7.8Francis DupontFrancis Dupont