Kea merge requestshttps://gitlab.isc.org/isc-projects/kea/-/merge_requests2022-10-06T13:04:45Zhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1794Draft: Obsolete: the more aggresive approach with bulk retrieval and automati...2022-10-06T13:04:45ZAndrei Pavelandrei@isc.orgDraft: Obsolete: the more aggresive approach with bulk retrieval and automatic translatorsObsolete. Part of #2311.Obsolete. Part of #2311.kea2.3.2Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1791Draft: Resolve "kea-dhcp6 does not log client classes"2022-10-26T12:56:58ZAndrei Pavelandrei@isc.orgDraft: Resolve "kea-dhcp6 does not log client classes"Closes #2564.Closes #2564.kea2.3.2https://gitlab.isc.org/isc-projects/kea/-/merge_requests/1854fix test reference files to match comments2022-11-26T18:58:15ZAndrei Pavelandrei@isc.orgfix test reference files to match commentsCloses #2651. Should fix `CtrlAgentGetCfgTest.simple` and `NetconfGetCfgTest.simple`.
```
get_config_unittest.cc:290
Value of: isEquivalent(unparsed, jsonj)
Actual: false
Expected: true
```
https://jenkins.aws.isc.org/job/kea-dev/job...Closes #2651. Should fix `CtrlAgentGetCfgTest.simple` and `NetconfGetCfgTest.simple`.
```
get_config_unittest.cc:290
Value of: isEquivalent(unparsed, jsonj)
Actual: false
Expected: true
```
https://jenkins.aws.isc.org/job/kea-dev/job/ut-extended/921/#showFailuresLinkkea2.3.3https://gitlab.isc.org/isc-projects/kea/-/merge_requests/1852Changes for Kea 2.3.3 release2022-11-26T07:30:56ZAndrei Pavelandrei@isc.orgChanges for Kea 2.3.3 releaseCloses #2651Closes #2651kea2.3.3Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1851Resolve "bump library versions for 2.3.3 release"2022-11-25T21:31:56ZAndrei Pavelandrei@isc.orgResolve "bump library versions for 2.3.3 release"Closes #2650.Closes #2650.kea2.3.3Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1850fix portable compilation issue2022-11-22T13:21:10ZAndrei Pavelandrei@isc.orgfix portable compilation issueCloses #2348 yet again.
On some systems, unit test fail to build with:
```
allocation_state_unittest.cc:35:5: required from here
/usr/src/googletest/googletest/include/gtest/gtest.h:1392:11: error: no match for ‘operator==’ (operand ...Closes #2348 yet again.
On some systems, unit test fail to build with:
```
allocation_state_unittest.cc:35:5: required from here
/usr/src/googletest/googletest/include/gtest/gtest.h:1392:11: error: no match for ‘operator==’ (operand types are ‘const boost::date_time::special_values’ and ‘const boost::posix_time::ptime’)
if (lhs == rhs) {
~~~~^~~~~~
```
Latest job with error: https://jenkins.aws.isc.org/job/kea-dev/job/ut-extended/912/
Job on this branch: https://jenkins.aws.isc.org/view/Kea-manual/job/kea-manual/job/ut-extended/167/kea2.3.3Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1848Resolve "Extend lease_query config syntax."2022-12-06T22:28:38ZFrancis DupontResolve "Extend lease_query config syntax."Close #2645Close #2645kea2.3.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1847Resolve ""prefix-len" for the "pd-pools" list is not checked correctly at sta...2023-01-17T08:52:35ZRazvan BecheriuResolve ""prefix-len" for the "pd-pools" list is not checked correctly at startup, but is caught by "config-get""Closes #2612Closes #2612kea2.3.3Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1846Resolve "Move LeaseQueryImpl6::getLinks() and supporting function(s) to CfgS...2022-11-21T19:22:05ZFrancis DupontResolve "Move LeaseQueryImpl6::getLinks() and supporting function(s) to CfgSubnet6"Part of #2643Part of #2643kea2.3.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1845Resolve "Create multi-threaded manager on top of TcpListener"2022-11-17T16:56:40ZFrancis DupontResolve "Create multi-threaded manager on top of TcpListener"Closes #2635Closes #2635kea2.3.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1844Resolve "lease6-update and v6 BLQ tables in memfile"2022-11-23T09:58:37ZFrancis DupontResolve "lease6-update and v6 BLQ tables in memfile"Closes #2600Closes #2600kea2.3.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1843Draft: Resolve "Kea should honor PD length hints if possible"2023-01-10T10:16:45ZDan TheisenDraft: Resolve "Kea should honor PD length hints if possible"Closes #1958Closes #1958kea2.3.3https://gitlab.isc.org/isc-projects/kea/-/merge_requests/1842Resolve "Create multi-threaded manager on top of TcpListener"2022-11-16T19:00:27ZThomas MarkwalderResolve "Create multi-threaded manager on top of TcpListener"Closes #2635Closes #2635kea2.3.3Thomas MarkwalderThomas Markwalderhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1841Resolve "DHCPv6 "remote-id" without IAID"2022-11-25T13:26:33ZRazvan BecheriuResolve "DHCPv6 "remote-id" without IAID"Closes #2472Closes #2472kea2.3.3Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1840Resolve "Lease query uses the link address only to identify a link"2022-11-10T21:24:27ZFrancis DupontResolve "Lease query uses the link address only to identify a link"Closes #2630Closes #2630kea2.3.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1839Resolve "sprintf is still used in Kea code"2022-11-09T17:16:48ZFrancis DupontResolve "sprintf is still used in Kea code"Closes #2625Closes #2625kea2.3.3Francis DupontFrancis Duponthttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1838Resolve "Refactor NETCONF code after migrating to sysrepo2"2022-11-25T21:00:22ZAndrei Pavelandrei@isc.orgResolve "Refactor NETCONF code after migrating to sysrepo2"Closes #2601.
* [x] 3d0f2198d9216436044fd8fa6ac84290afdb67a8 renames in NETCONF code
* s_val -> data_node or value
* SysrepoError -> NetconfError
* sysrepo_error.h -> netconf_error.h
* TranslatorBasic::delItem() -> Tran...Closes #2601.
* [x] 3d0f2198d9216436044fd8fa6ac84290afdb67a8 renames in NETCONF code
* s_val -> data_node or value
* SysrepoError -> NetconfError
* sysrepo_error.h -> netconf_error.h
* TranslatorBasic::delItem() -> TranslatorBasic::deleteItem()
* TranslatorBasic::value() -> TranslatorBasic::translate()
* [x] 3b8f6af5b783f769c70745b6e2a1b0ac9add0990 aliases for service_pair.{first,second}
* [x] 9745ff398bf4d1dc40a8406698131fd8139c7c7e decode64 and encode64 are now methods in TranslatorBasic
* [x] 875746504d431eca2628f9cb75cd75a5f326eab1 EXPECT_NO_THROW -> EXPECT_NO_THROW_LOG
* [x] f5d8296022ff4fa4e676f61205c98b8a3b8be5ab EXPECT_THROW -> EXPECT_THROW_MSG
* [x] 6a86369c0fa5cae5beeaaad8b7cd95661332de38 remove empty constructors and destructors
* [x] 83270676dcdcf2e9d52e5dfbb446210e1b961448 typedef -> using
* [x] 9134e77769c45940eaea0c13dcbe2b1cbaa1c8cd use std smart pointers where possible
* [x] 272b48f23ddbfae3721a89b5bcaa3e60eac1b208 renames in NETCONF code
* subscribeConfig -> subscribeToDataChanges
And mainly to appease doxygen:
* translate(DataNode, string) -> translateFromYang(DataNode, string)
* translate(ElementPtr, LeafBaseType) -> translateToYang(ElementPtr, LeafBaseType)
* get*(xpath) -> get*FromAbsoluteXpath(xpath)
* [x] 8c267d3e1f639be201d434a4b9774baf38a54ff7 clean up header includes and makefiles in NETCONF code
* [x] 3c06dd57f7b19665a393c16f5ba86c473d20fcb9 make NETCONF_SUBSCRIBE_NOTIFICATIONS_FAILED a warning
* [x] 0f6cd39f09ef9bde5422805dcb6c0246d5212c29 use checkAnd{Get,Set} where possible
* [x] 3e2fd8cf21cec35919e3408ef1b17d97067f6157 update the YANG modules with three extra nodes
* extended-info-checks
* ignore-rai-link-selection
* template-test
* [x] 20a54731dd665b22168d5e3408a7893e3c2462f2 remove std:: prefix from .cc files
* [x] c7545640b594545320c11267152f68f0327171fb rename TranslatorBasic to Translator
* [x] 9c9ffcd2e897987075013b3c7eb5a6e265657f58 make Translator aware of all leaf base types
Also add leafrefs and the empty leaf to the keatest-module.
And add tests for those, and also unions, dec64, int64, uint64.
* [x] 7803d398f9cfaa800ddc0953a82ce52d130bcddc remove schema node checking from translator
* [x] 39623a7b6d2c03023f5aa095a4dc6f914be390e8 add Translator::checkAndSet
* [x] 97d60fbbb39cc26f7b80733e07e27078553a7388 remove std:: prefix from .cc files
* [x] 1d032343158d6cfed21d5f09f47dfedfd8715f7a fix doxygen and add override final
* [x] 0089b93387f9d1ad2ce802d76786fcfb586bcde0 update YANG developer guide
* [x] 843118070ec2ec03e5782350aa0a4048db468f05 fix typos in NETCONF code
* [x] 007879b112cf2595cd1684d4aae6e0849d975a2b remove the use of const_pointer_cast in NETCONF code
If the casted element is mutated after the fact,
there may be undefined behavior.
* [x] 63f6df8bbc7ecf04b95ffe46af646455008d0d21 add ChangeLog entry
#huge-sorrykea2.3.3Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1837Resolve "create documentation for template-classes"2022-11-18T11:14:56ZRazvan BecheriuResolve "create documentation for template-classes"Closes #2606Closes #2606kea2.3.3Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1835Resolve "update hooks_unittests in v4 and v6 to address #2548 review comments"2022-11-25T21:05:26ZRazvan BecheriuResolve "update hooks_unittests in v4 and v6 to address #2548 review comments"Closes #2619Closes #2619kea2.3.3Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/kea/-/merge_requests/1834Resolve "Limits on built-in classes are being ignored"2022-11-17T12:09:15ZRazvan BecheriuResolve "Limits on built-in classes are being ignored"Closes #2615Closes #2615kea2.3.3Razvan BecheriuRazvan Becheriu