Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Kea Kea
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 501
    • Issues 501
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 53
    • Merge requests 53
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • ISC Open Source Projects
  • KeaKea
  • Merge requests
  • !1498

Allow 0 length OpaqueDataTuple to be pack()ed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrei Pavel requested to merge fix-opaque-data-pack into master Nov 19, 2021
  • Overview 1
  • Commits 2
  • Changes 3

Closes #2021 (closed).

A customer was attempting to modify an Option 124 packet with zero length Opaque Data. While unpack() currently supports decoding zero length OpaqueDataTuples from the wire format, pack() seemed to have an explicit check to prevent the encoding of zero length OpaqueDataTuples. This seems like an oversight considering that some clients seem to send zero length Opaque Data.

The check has been removed from pack(), and tests have been updated to reflect this requirement.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-opaque-data-pack