... | ... | @@ -25,7 +25,7 @@ git branch -u origin/master master |
|
|
git pull
|
|
|
```
|
|
|
|
|
|
If you set up a new repository:
|
|
|
If seting up a new repository:
|
|
|
```
|
|
|
git clone git@gitlab.isc.org:isc-projects/kea.git
|
|
|
cd kea
|
... | ... | @@ -61,7 +61,7 @@ When migrating stuff between repos, DO NOT copy files over. Use cherry-pick inst |
|
|
|
|
|
- Commit your changes, push it on that branch.
|
|
|
|
|
|
- Once you are done, do the following: unassign yourself from the issue and MR, remove "doing" label, add "review" label. This indicates the MR is ready for a review.
|
|
|
- Once you are done, do the following: unassign yourself from the issue and MR, remove "doing" label, add "review" label. The doing and review labels should be put on both the issue and the MR. This indicates the MR is ready for a review. This looks like a duplication of work, but it serves different purposes. The issues are tracked using a board (see [this 1.5 board](https://gitlab.isc.org/isc-projects/kea/boards?scope=all&utf8=%E2%9C%93&state=opened&milestone_title=Kea1.5) for example). Once you assign a label to an issue it is shown in the appropriate column. Now, the review label on MR indicates that particular one is ready for review. The illusion of duplication disappears when there are multiple MRs assigned to a single issue.
|
|
|
|
|
|
# Reviewing an issue
|
|
|
|
... | ... | |