... | ... | @@ -61,11 +61,11 @@ When migrating stuff between repos, DO NOT copy files over. Use cherry-pick inst |
|
|
|
|
|
- Commit your changes, push it on that branch.
|
|
|
|
|
|
- Once you are done, do the following: unassign yourself from the issue and merge request, remove "doing" label, add "review" label. Open the pull request, edit it and click on "remove WIP status".
|
|
|
- Once you are done, do the following: unassign yourself from the issue and merge request, remove "doing" label, add "review" label. Open the merge request, edit it and click on "remove WIP status".
|
|
|
|
|
|
# Reviewing an issue
|
|
|
|
|
|
- as a reviewer: go to Issues->Board page. Look for an issue in review state that has no assignee. Assign to yourself. Review. Put some snarky comments. Add some more comments. Once you're done, reassign back to the reviewer.
|
|
|
- as a reviewer: go to Issues->Board page. Look for an issue in review state that has no assignee. Assign to yourself. Review. Put some snarky comments. Add some more comments. Once you're done, reassign back to the developer.
|
|
|
|
|
|
- as a developer: look for issues that are assigned to you. Do your best with addressing the comments. Push your improvements to the branch. Once done reassign back to the reviewer. Do not merge until the reviewer says the code is ready.
|
|
|
|
... | ... | @@ -127,4 +127,3 @@ To set that your local branch should trac a remote branch, use: |
|
|
```
|
|
|
git branch -u remote_repo/remote_branch local_branch
|
|
|
``` |
|
|
|