Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Kea
Kea
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 235
    • Issues 235
    • List
    • Board
    • Labels
    • Milestones
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • ISC Open Source Projects
  • KeaKea
  • Issues
  • #328

Closed
Open
Opened Dec 10, 2018 by Francis Dupont@fdupont
  • Report abuse
  • New issue
Report abuse New issue

Using a model which is installed but unknown.

This issue is about the third case in this method called with the model for a managed server entry:

bool
NetconfAgent::checkModule(const string& module_name) const {
    if (module_name.empty()) {
	return (true);
    }
    auto module = modules_.find(module_name);
    if (module == modules_.end()) {
        LOG_ERROR(netconf_logger, NETCONF_MODULE_MISSING_ERR)
            .arg(module_name);
        return (false);
    }
    auto modrev = YANG_REVISIONS.find(module_name);
    if (modrev == YANG_REVISIONS.end()) {
        // Can't check revision?!                                               
        // It can happen only with a module which is not in                     
        // YANG_REVISIONS but installed so likely on purpose.                   
        return (true);
    }
    if (modrev->second != module->second) {
        LOG_ERROR(netconf_logger, NETCONF_MODULE_REVISION_ERR)
            .arg(module_name)
            .arg(modrev->second)
            .arg(module->second);
	return (false);
    }
    return (true);
}

Tomek requested a warning, I added the comment after Can't check revision?! and answered:

No warning. In fact it means the module is installed but is not in yang revisions so either it is on purpose and the check was simply disabled, or it is a real error and the translator will raise a better error.

I am creating an issue in the case a better option could be found.

Assignee
Assign to
Kea1.x
Milestone
Kea1.x
Assign milestone
Time tracking
None
Due date
No due date
2
Labels
comments needed netconf
Assign labels
  • View project labels
Reference: isc-projects/kea#328