GitLab

The change made in the ARM per review comments.

modified:   webui/src/app/dashboard/dashboard.component.html

    modified:   webui/src/app/dashboard/dashboard.component.ts

Added a ChangeLog.md and added a few missing blank lines

webui/src/app/dashboard/dashboard.component.ts
    Added  daemonRpsTooltip(daemon, interval)

webui/src/app/dashboard/dashboard.component.html
    Add call to tool tip invocation of daemonRpsTooltip()

The error message captured during an attempt top tail log file is now
displayed in a separate error box.

renamed:    ../migrations/26_add_rps_intervals.go -> ../migrations/27_add_rps_intervals.go
modified:   migrations_test.go

    modified:   statspuller.go

NewStatsPuller() now always creates an RpsWorker instance.

backend/server/apps/kea/rps.go
    Renamed RpsPuller to RpsWorker, no longer contains a PeriodicPuller
    deleted the following functions:
    Shutdown()
    pullStats()
    getStatsFromApp()

backend/server/apps/kea/rps_test.go
    Reworked tests
    Removed those which primarily only exercized pullStats()/
    getSTatsFromApp()

Addressed all comments except those relevant to removing RpsPuller.pullStats() and
RpsPuller.getStatsFromApp()

backend/server/apps/kea/statspuller.go
    getStatsFromApp() - added call to RpsPuller.AgeOffRpsIntervals()

backend/server/apps/kea/rps_test.go
    TestRpsPullerEmptyOrInvalidResponses() - updated to
    expect response handlers to return an error

Refactored RpsPuller so it can either run it's own PeriodicPuller
or be driven by another puller issuing DHCP4 and DHCP6 commands

Works end to end now. Renamed lps15*/lps24* with rps1/rps2

modified:
    api/dhcp-defs.yaml
    backend/server/apps/kea/rps.go
    backend/server/apps/kea/rps_test.go
    backend/server/database/model/app_test.go
    backend/server/database/model/daemon.go
    backend/server/database/model/daemon_test.go
    backend/server/database/model/rps_interval.go
    backend/server/database/model/rps_interval_test.go
    backend/server/restservice/machines.go
    webui/src/app/dashboard/dashboard.component.html

server now instantiates RpsPuller
removed not null from rps_interval value and duration columns
cleaned up command response logic
added more unit tests

backend/server/apps/kea/rps.go
    Cleanup
    Added call to AgeOffRpsInterval()

backend/server/database/model/rps_interval.go
    GetTotalRpsOverInterval() - new func to get RPS totals for all daemons
    AgeOffRpsInterval() - new func for aging off entries

backend/server/database/model/rps_interval_test.go
    TestRpsIntervalBasics() - added tests AgeOffRpsInterval()
    TestRpsIntervalTotals() - new test

Interrim commit that adds the initial pieces to pull
and store RPS data from Kea.

backend/server/apps/kea/rps.go
backend/server/apps/kea/rps_test.go

backend/server/database/migrations/26_add_rps_intervals.go
backend/server/database/model/rps_interval.go
backend/server/database/model/rps_interval_test.go