stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2024-03-28T10:17:29Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1350Make RADIUS-related sytem tests compatible with Kea 2.52024-03-28T10:17:29ZSlawek FigielMake RADIUS-related sytem tests compatible with Kea 2.5Upgrading Kea in system tests to the 2.5 version caused a system test failure that involved RADIUS. Kea team is working on RADIUS changes which apparently has changed in 2.5.
It blocks us from upgrading Kea in system tests and writing t...Upgrading Kea in system tests to the 2.5 version caused a system test failure that involved RADIUS. Kea team is working on RADIUS changes which apparently has changed in 2.5.
It blocks us from upgrading Kea in system tests and writing the system tests for the hub-and-spoke feature.https://gitlab.isc.org/isc-projects/stork/-/issues/1349HA panel should use Stork-style machine naming2024-03-28T10:07:06ZSlawek FigielHA panel should use Stork-style machine namingPlease use the machine name in the application identifier. It should be: `kea@agent-kea-ha1` and `kea@agent-kea-ha3` instead of `Kea@127.0.0.1`. We usually use this convention in Stork.
Current:
![image](/uploads/7e083489c97d5ff8d60d4...Please use the machine name in the application identifier. It should be: `kea@agent-kea-ha1` and `kea@agent-kea-ha3` instead of `Kea@127.0.0.1`. We usually use this convention in Stork.
Current:
![image](/uploads/7e083489c97d5ff8d60d469699eb380a/image.png)
After #1274 merge:
![image](/uploads/7a22035e53f32a1544235987e84cad8f/image.png)https://gitlab.isc.org/isc-projects/stork/-/issues/1336Stork-Server is confused by multiple Kea DHCP versions installed2024-03-26T11:25:44ZCarsten StrotmannStork-Server is confused by multiple Kea DHCP versions installed---
name: Bug report
about: Create a report to help us improve
---
**Describe the bug**
Stork-Server (or Stork-Agent) is confused by multiple Kea-DHCP versions installed on the same machine and displays inconsistent version number.
On...---
name: Bug report
about: Create a report to help us improve
---
**Describe the bug**
Stork-Server (or Stork-Agent) is confused by multiple Kea-DHCP versions installed on the same machine and displays inconsistent version number.
On my (testing) system, I have the OS delivered Kea-DHCP (version 2.4.1 from Fedora 39) as well as a Kea-DHCP version (2.5.6 installed from source). The Version 2.4.1 is "in path" (/usr/bin:/usr/sbin) but not running, whereas 2.5.6 is not "in path" (/opt/kea/sbin), but "is" running.
Stork does display both versions numbers:
![Stork-Kea-Version-Number02.png](/uploads/9b5291671228bdb67c5c6c799278fe59/Stork-Kea-Version-Number02.png)
![Stork-Kea-Version-Number01.png](/uploads/ad42cf27202a4f5a91463da2ef91a88b/Stork-Kea-Version-Number01.png)
**To Reproduce** Steps to reproduce the behavior:
1. two different versions of Kea DHCP, Stork Agent and Stork Server
2. check the Kea Version numbers in the Stork Web-UI
**Expected behavior**
Show the running Kea-DHCP version number all the time.https://gitlab.isc.org/isc-projects/stork/-/issues/1335Not possible to run DHCPv6 only and collect stats with Prometheus2024-03-25T17:24:07ZRinse KloekNot possible to run DHCPv6 only and collect stats with Prometheus - Kea version: 2.4.1
- Stork: which version? 1.15.0
- OS: Debian 11
I have an issue with the prometheus exporter. I had enabled DHCPv4/DHCPv6/D2 in my kea-ctrl-agent as well as installed the KEA DHCPv4 server. However this server on... - Kea version: 2.4.1
- Stork: which version? 1.15.0
- OS: Debian 11
I have an issue with the prometheus exporter. I had enabled DHCPv4/DHCPv6/D2 in my kea-ctrl-agent as well as installed the KEA DHCPv4 server. However this server only serves DHCPv6 request. If I remove the DHCPv6/D2 entries in the Kea-ctrl-agent.conf and deinstall KEA DHCPv4 server, I am not able to see my DHCPv6 PD stats (kea_dhcp6_pd_assigned_total) anymore.
I get this error message in the log on the server
stork-agent[929757]: time="2024-03-19 11:54:23" level="error" msg="Problem parsing DHCPv4 labels from Kea: problem with content of DHCP labels response from Kea: forwarding socket is not configured for the server type dhcp4\nisc.org/stork/agent.(*SubnetList).UnmarshalJSON\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:82\nencoding/json.(*decodeState).array\n\t/builds/isc-projects/stork/tools/golang/go/src/encoding/json/decode.go:507\nencoding/json.(*decodeState).value\n\t/builds/isc-projects/stork/tools/golang/go/src/encoding/json/decode.go:364\nencoding/json.(*decodeState).unmarshal\n\t/builds/isc-projects/stork/tools/golang/go/src/encoding/json/decode.go:181\nencoding/json.Unmarshal\n\t/builds/isc-projects/stork/tools/golang/go/src/encoding/json/decode.go:108\nisc.org/stork/agent.(*lazySubnetNameLookup).fetchAndCacheNames\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:274\nisc.org/stork/agent.(*lazySubnetNameLookup).getName\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:291\nisc.org/stork/agent.(*lazySubnetNameLookup).getNameOrDefault\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:303\nisc.org/stork/agent.(*PromKeaExporter).setDaemonStats\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:772\nisc.org/stork/agent.(*PromKeaExporter).collectStats\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:877\nisc.org/stork/agent.(*PromKeaExporter).statsCollectorLoop\n\t/builds/isc-projects/stork/backend/agent/promkeaexporter.go:724\nruntime.goexit\n\t/builds/isc-projects/stork/tools/golang/go/src/runtime/asm_amd64.s:1650" file=" promkeaexporter.go:276 "
`
After installing the KEA DHCPv4 server again and reeneabling the KEA DHCPv4 server in kea-ctrl-agent these log message don't appear anymore and the Prometheus stats collection works again.
Is it possible to remove the DHCPv4 server and keep the stats working for DHCPv6
regads,
Rinsehttps://gitlab.isc.org/isc-projects/stork/-/issues/1329Event-driven HA status monitoring2024-03-26T14:55:35ZMarcin SiodelskiEvent-driven HA status monitoringCurrently we poll every 10s for the current HA state. I'd like to suggest that we move to an event-based monitoring where the changes will be signaled by the server to the subscribers over SSE. This should reduce the amount of processing...Currently we poll every 10s for the current HA state. I'd like to suggest that we move to an event-based monitoring where the changes will be signaled by the server to the subscribers over SSE. This should reduce the amount of processing in the browser and should cause an immediate reaction to the HA state changes.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1326Stork does not display leases statistics2024-03-14T14:07:08ZJohn PapStork does not display leases statistics**Describe the bug**
Stork server not displaying lease statistics. Remote stork agent has already registered. Stork server GUI displays the kea dhcp4 service correctly and I can manually pull statistics via the API from the stork server'...**Describe the bug**
Stork server not displaying lease statistics. Remote stork agent has already registered. Stork server GUI displays the kea dhcp4 service correctly and I can manually pull statistics via the API from the stork server's CLI using curl. Although there are active leases for clients the Web UI displays 0 for assigned IPs on all subnets. Probably a bug in the stat-lease4-get API command.
**To Reproduce**
Steps to reproduce the behavior:
1. Install Kea server 2.0.2, Stork 1.15.0 and run them with the following configs: '...'
2. Configure several subnets.
2. Have 3 VMs act as clients on all subnets and get ip addresses from kea server
3. Clients get IP address but the Stork GUI shows 0 for all lease statistics.
**Expected behavior**
Stork GUI should display the leases statistics for the connected clients.
**Environment:**
- Kea version: 2.0.2
- Stork: 1.15.0
- OS: Ubuntu 22.04 x64
- Kea: Hooks libdhcp_stat_cmds.so, libdhcp_lease_cmds.so
**Additional Information**
Querying the DHCP agent from the stork server using the cli and the management API I figured out that the stat-lease4-get command without arguments returns different results for the same subnet than the stat-lease4-get command having the subnet-id as an argument.
curl -X POST -H "Content-Type: application/json" -d '{ "command": "stat-lease4-get", "service": ["dhcp4"]}' http://192.168.59.21:8000
[ { "arguments": { "result-set": { "columns": [ "subnet-id", "total-addresses", "cumulative-assigned-addresses", "assigned-addresses", "declined-addresses" ], "rows": [ [ 47, 56, 0, 0, 0 ], [ 51, 56, 0, 0, 0 ], [ 66, 41, 0, 0, 0 ] ], "timestamp": "2024-03-08 14:09:09.100431" } }, "result": 0, "text": "stat-lease4-get[all subnets]: 3 rows found" } ]
curl -X POST -H "Content-Type: application/json" -d '{ "command": "stat-lease4-get", "service": ["dhcp4"], "arguments": {"subnet-id" : 66}}' http://192.168.59.21:8000
[ { "arguments": { "result-set": { "columns": [ "subnet-id", "total-addresses", "cumulative-assigned-addresses", "assigned-addresses", "declined-addresses" ], "rows": [ [ 66, 41, 0, 3, 0 ] ], "timestamp": "2024-03-08 14:09:17.884123" } }, "result": 0, "text": "stat-lease4-get[subnet-id=66]: 1 rows found" } ]
The second output above has the correct leases stats for subnet-id 66 while the first output shows 0 leases for subnet-id 66https://gitlab.isc.org/isc-projects/stork/-/issues/1301Length of input for lease6-get-by-duid is not validated2024-03-28T12:24:48ZSlawek FigielLength of input for lease6-get-by-duid is not validatedThe issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/i...The issue was found by @andrei during 1.15 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/1296#note_434113
Searching leases by two-character or four-character words provide warnings.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/084c42bee2b770bbb47bad0d3e83212d/image.png)
This is caused by an error response e.g. `[ { "result": 1, "text": "identifier is too short (2), at least 3 is required" } ]` to the `lease6-get-by-duid` command. This could be avoided by having Stork check this requirement up front and prevent the command from being sent, as it does with other input. As the comment in `lease.go` says
> // Kea does not accept empty DUIDs. Empty DUID in Kea is represented by 1 zero byte (Kea < 2.3.8) or 3 zero bytes (Kea >= 2.3.8).\`
The current situation can be confusing to a user trying to determine why an even number of characters and bytes is more problematic than an odd number of characters which is checked upfront by Stork.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1277Create new subnets using the subnet form2024-01-26T15:05:09ZMarcin SiodelskiCreate new subnets using the subnet formStork UI has a form allowing for updating an existing subnet. We need to create new API calls in the backend to support creating new subnets in the Kea servers. The existing form should be used for specifying the new subnet's configurati...Stork UI has a form allowing for updating an existing subnet. We need to create new API calls in the backend to support creating new subnets in the Kea servers. The existing form should be used for specifying the new subnet's configuration data.1.15Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1274Hub and spoke configuration monitoring2024-03-28T12:21:12ZMarcin SiodelskiHub and spoke configuration monitoringWe have added the hub-and-spoke configuration support in Kea. It means that a HA-enabled server can now have multiple relationships. We need to rework the Stork backend and UI to support it.We have added the hub-and-spoke configuration support in Kea. It means that a HA-enabled server can now have multiple relationships. We need to rework the Stork backend and UI to support it.1.16Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1266Inconsistent IDs2024-01-23T14:18:17ZManuelInconsistent IDsHey everybody,
today I noticed a strange error message in Stork.
Everything is working fine, but looks to me as if this is a logic flaw.
We have multiple kea servers with a private subnet but unique ids.
Why would that be a problem?
...Hey everybody,
today I noticed a strange error message in Stork.
Everything is working fine, but looks to me as if this is a logic flaw.
We have multiple kea servers with a private subnet but unique ids.
Why would that be a problem?
Thanks!
![image](/uploads/9eb80b5bda7df51180e51795217d0474/image.png)outstandingMarcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1237kea-app-tab component improvements2023-12-20T10:12:58ZPiotrek Zadrogakea-app-tab component improvementsWhile working on #915, it occurred to me that there are few things that could be improved in `kea-app-tab` component UI/UX.
1. Overview row - _Daemon Information_ vs _Hooks_ columns proportions
Currently proportions for the columns...While working on #915, it occurred to me that there are few things that could be improved in `kea-app-tab` component UI/UX.
1. Overview row - _Daemon Information_ vs _Hooks_ columns proportions
Currently proportions for the columns are 6:6.
By default it looks like:
![image](/uploads/804a06db7a9ceb88e1115b1a5acbca47/image.png)
Hooks names are not that wide, so the proportions could be changed to 8:4:
![image](/uploads/fd801a896b366e9346f5c1184997383d/image.png)
2. Hooks paths displayed after click on a hook name
After click on a hook name there is a path displayed:
![image](/uploads/1f88238856f291b261309f6781082aeb/image.png)
I hear that intention of it is the possibility to copy the path to the clipboard. The path doesn't look good with broken lines. Instead of `p-inplace` component there could be a tooltip displayed `Click to copy hook path to the clipboard`. Click event would write the hook path to the clipboard. The discussion about this concept was in https://gitlab.isc.org/isc-projects/stork/-/merge_requests/682#note_419854 and following comments.
@slawek had some concerns:
> How is a user supposed to know the full path will be copied to a clipboard on click?
The tooltip will display that information: what is about to happen after click.
And my counter question: how is the user supposed to know that right now when the hook name is clicked, it will be changed to a hook path?
Currently, it probably works for the user like: I can click that? Ok, let's click that and see what happens next...
> Especially, why should the user expect the copied value to be a full path instead of displaying the hook name?
It doesn't look to me as a UX improvement. If you would like to do it this way, you should inform a user what action will be performed.
The tooltip will display that information: what is about to happen after click.
> but how do you indicate the copied value is a full path?
My proposal is to use Clipboard API `writeText` which returns a `Promise`, so successful/failed write to the clipboard can be displayed as a notification.
```ts
navigator.clipboard.writeText("some hook path").then(
() => {
/* clipboard successfully set */
},
() => {
/* clipboard write failed */
},
);
```
3. Hooks list display
When there are more hooks loaded in Kea, and the screen displaying the component is not that wide, there happens this overlapping:
![image](/uploads/af6cafdd850fb1334ff1f1fec9396654/image.png)
This is because one list entry consists of 3 columns in proportions 1:10:1. This could be constructed/styled in a better way to avoid the overlap.1.15Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1208Pool management in the subnet form2023-11-27T08:10:12ZMarcin SiodelskiPool management in the subnet formWe can currently update some DHCP parameters and options for the existing subnet in the subnet form. We now need to extend this capability to also manage pools (add pools, remove pools and update pools). It also includes the pool-specifi...We can currently update some DHCP parameters and options for the existing subnet in the subnet form. We now need to extend this capability to also manage pools (add pools, remove pools and update pools). It also includes the pool-specific DHCP parameters that Kea supports.1.14Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1193CA returns number overflow on ipv6 stats2024-03-22T12:56:27ZSlawek FigielCA returns number overflow on ipv6 statsThe issue was found during [1.13 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408666) by @slawek.
I have observed a weird error in logs:
```
stork-1130-agent-kea6-1 | INFO COMMAND_RECEIVED R...The issue was found during [1.13 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408666) by @slawek.
I have observed a weird error in logs:
```
stork-1130-agent-kea6-1 | INFO COMMAND_RECEIVED Received command 'statistic-get-all'
stork-1130-agent-kea6-1 | INFO CTRL_AGENT_COMMAND_RECEIVED command statistic-get-all received from remote address 127.0.0.1
stork-1130-agent-kea6-1 | INFO COMMAND_RECEIVED Received command 'statistic-get-all'
stork-1130-agent-kea6-1 | time="2023-10-10 12:40:51" level="error" msg="Failed to parse responses from Kea: response result from Kea != 0: 1, text: internal server error: unable to parse server's answer to the forwarded message: Number overflow: 36893488147419103232 in <wire>:0:8422" file=" promkeaexporter.go:850 "
stork-1130-agent-kea6-1 | time="2023-10-10 12:40:51" level="error" msg="Some errors were encountered while collecting stats from Kea: response result from Kea != 0: 1, text: internal server error: unable to parse server's answer to the forwarded message: Number overflow: 36893488147419103232 in <wire>:0:8422\nisc.org/stork/agent.(*GetAllStatisticsResponse).UnmarshalJSON\n\tisc.org/stork/agent/promkeaexporter.go:149\nencoding/json.(*decodeState).array\n\tencoding/json/decode.go:507\nencoding/json.(*decodeState).value\n\tencoding/json/decode.go:364\nencoding/json.(*decodeState).unmarshal\n\tencoding/json/decode.go:181\nencoding/json.Unmarshal\n\tencoding/json/decode.go:108\nisc.org/stork/agent.(*PromKeaExporter).collectStats\n\tisc.org/stork/agent/promkeaexporter.go:847\nisc.org/stork/agent.(*PromKeaExporter).statsCollectorLoop\n\tisc.org/stork/agent/promkeaexporter.go:710\nruntime.goexit\n\truntime/asm_amd64.s:1650" file=" promkeaexporter.go:712 "
```1.16Slawek FigielSlawek Figiel2024-05-29https://gitlab.isc.org/isc-projects/stork/-/issues/1168Kea and CA configs with trailing commas2023-10-17T13:26:04ZSlawek FigielKea and CA configs with trailing commasStork agent rejects parsing the Kea CA configuration files with trailing commas that are handled properly by Kea.
Example:
```json
{
"Control-agent": {
"http-host": "127.0.0.1",
"http-port": 8000,
"control-sockets": {
"dhcp4"...Stork agent rejects parsing the Kea CA configuration files with trailing commas that are handled properly by Kea.
Example:
```json
{
"Control-agent": {
"http-host": "127.0.0.1",
"http-port": 8000,
"control-sockets": {
"dhcp4": {
"socket-type": "unix",
"socket-name": "/run/kea/control_socket_4"
},
},
"loggers": [{
"name": "kea-ctrl-agent",
"output_options": [{
"output": "stdout"
}],
"severity": "INFO"
}]
}
}
```
Fails due to trailing comma after closing bracket of the `dhcp4` object.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1153add pool statistics to prometheus2023-09-12T13:48:16ZRazvan Becheriuadd pool statistics to prometheusnew stats have been added in 2.4.0:
v4:
```
"subnet[1].pool[0].assigned-addresses": [
[
0,
"2023-06-13 20:42:46.836205"
]
],
"subnet[1...new stats have been added in 2.4.0:
v4:
```
"subnet[1].pool[0].assigned-addresses": [
[
0,
"2023-06-13 20:42:46.836205"
]
],
"subnet[1].pool[0].cumulative-assigned-addresses": [
[
0,
"2023-06-13 20:42:46.836137"
]
],
"subnet[1].pool[0].declined-addresses": [
[
0,
"2023-06-13 20:42:46.836213"
]
],
"subnet[1].pool[0].reclaimed-declined-addresses": [
[
0,
"2023-06-13 20:42:46.836225"
]
],
"subnet[1].pool[0].reclaimed-leases": [
[
0,
"2023-06-13 20:42:46.836236"
]
],
"subnet[1].pool[0].total-addresses": [
[
11010049,
"2023-06-13 20:42:46.836128"
]
],
```
v6:
```
"subnet[1].pd-pool[0].assigned-pds": [
[
0,
"2023-06-13 21:28:57.196785"
]
],
"subnet[1].pd-pool[0].cumulative-assigned-pds": [
[
0,
"2023-06-13 21:28:57.196744"
]
],
"subnet[1].pd-pool[0].reclaimed-leases": [
[
0,
"2023-06-13 21:28:57.196789"
]
],
"subnet[1].pd-pool[0].total-pds": [
[
256,
"2023-06-13 21:28:57.196741"
]
],
"subnet[1].pool[0].assigned-nas": [
[
0,
"2023-06-13 21:28:57.196773"
]
],
"subnet[1].pool[0].cumulative-assigned-nas": [
[
0,
"2023-06-13 21:28:57.196739"
]
],
"subnet[1].pool[0].declined-addresses": [
[
0,
"2023-06-13 21:28:57.196775"
]
],
"subnet[1].pool[0].reclaimed-declined-addresses": [
[
0,
"2023-06-13 21:28:57.196779"
]
],
"subnet[1].pool[0].reclaimed-leases": [
[
0,
"2023-06-13 21:28:57.196783"
]
],
"subnet[1].pool[0].total-nas": [
[
281474976710656,
"2023-06-13 21:28:57.196736"
]
],
```
```backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1119Create shared network view in the UI2023-08-01T15:33:51ZMarcin SiodelskiCreate shared network view in the UIWe have to create similar view for the shared network to the subnet view created in #953. It also requires extending our API to pass the shared network-level parameters from the server to the UI.We have to create similar view for the shared network to the subnet view created in #953. It also requires extending our API to pass the shared network-level parameters from the server to the UI.1.12Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1045Not configured control sockets - descriptive hint or config checker2023-07-27T11:53:22ZSlawek FigielNot configured control sockets - descriptive hint or config checkerTwo users (#1041 and #1042) reported the same misconfiguration issue with missing control socket entries in the DHCP daemon configurations last week.
It caused the Kea Control Agent couldn't forward Strok commands to the DHCP daemons.
L...Two users (#1041 and #1042) reported the same misconfiguration issue with missing control socket entries in the DHCP daemon configurations last week.
It caused the Kea Control Agent couldn't forward Strok commands to the DHCP daemons.
Let's do four things:
- [x] Handle the problem on Stork UI and display a descriptive message with a suggested configuration block to add. Currently, there is a generic message about connection issues.
- [x] Add a config review checker for this problem. I don't know if it is possible for the DHCP daemons because we cannot fetch the configuration without control sockets. But we can do it at least for Kea Control Agent.
- [ ] ~~The users probably installed the Kea from the packages available in the operating system repository (Debian?). We should check the default configuration provided by these packages and contact the maintainers if the control socket section is missing by default to change it.~~
- [x] Describe the problem and solution in the Stork troubleshooting docs.1.12Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1038Include JSON comment strings in config-get and display in Stork DHCP -> Subnets2023-05-23T13:16:52Zfue36Include JSON comment strings in config-get and display in Stork DHCP -> Subnetsname: Feature request
about: Include JSON comment strings in config-get and display in Stork DHCP -> Subnets
Kea code allowed the use of comment strings as valid JSON entities. These string is retained through various operations, such a...name: Feature request
about: Include JSON comment strings in config-get and display in Stork DHCP -> Subnets
Kea code allowed the use of comment strings as valid JSON entities. These string is retained through various operations, such as config-get.
https://kea.readthedocs.io/en/latest/arm/config.html#comments-and-user-context
---
**Is your feature request related to a problem? Please describe.**
When hosting many subnets it's difficult for system administrators to monitor / troubleshoot by only having access to subnet ID and subnet IP.
**Describe the solution you'd like**
Pull the comment string from JSON config-get and display in DHCP->Subnets. If the field is blank just display a empty row, or display "No Comment" with a mouse over hint on how to add comment. It would also be nice to display the subnet comment in the dashboard. ;)
Seems like a relatively simple request for developers to pull comment from JSON (if it's not being done already) and display in Stork.backloghttps://gitlab.isc.org/isc-projects/stork/-/issues/1036Include statements with non-JSON extensions in Kea CA config2023-06-02T16:58:27ZSlawek FigielInclude statements with non-JSON extensions in Kea CA configStork supports the `include` statements in the Kea Control Agent configuration, but only if the included file has a `.json` extension. Kea allows any extensions. If the Kea Control Agent configuration contains the `include` statement wit...Stork supports the `include` statements in the Kea Control Agent configuration, but only if the included file has a `.json` extension. Kea allows any extensions. If the Kea Control Agent configuration contains the `include` statement with the non-JSON file, Stork throws an error and rejects the particular Kea.
The problem was reported on our mailing list on 2023-05-11:
> The Stork Agent is not happy when a KEA configuration file has an include statement in it. This is the error I see on the syslog:
>
> ```
> level="error" msg="Invalid Kea Control Agent config" file=" kea.go:215 " error="Cannot parse Kea Control Agent config file: problem parsing Kea configuration: invalid character '<' looking for beginning of object key string: invalid character '<' looking for beginning of object key string"
> ```
> And the configuration file it is trying to read is starting as:
> ```
> {
> "Control-agent": {
> <?include "/mnt/data/etc/kea/local-ctrl-agent.include"?>
> ```
>
> Hmm… KEA accepts the .include extension though, so shouldn’t Stork accept what KEA accepts?1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1035Lease search optimization for many servers environment2023-05-16T13:40:23ZManuelLease search optimization for many servers environmentHello everybody,
I feel the need to talk about leases and search in general.
The way I understand it (by looking at the code, correct me if I am wrong) Stork is always querying all
connected KEA servers to find a lease.
Both in the d...Hello everybody,
I feel the need to talk about leases and search in general.
The way I understand it (by looking at the code, correct me if I am wrong) Stork is always querying all
connected KEA servers to find a lease.
Both in the dedicated lease search as well as in the host view under "IP Reservations".
We have several hundred KEA servers connected to Stork and it takes forever to find a lease.
Shouldn't Stork only search on the related KEA server for the lease and not on all KEA servers?
Thanks!backlog