stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2023-06-05T17:31:34Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1022Cannot log in to UI while Postgres uses "trust" authentication2023-06-05T17:31:34ZSlawek FigielCannot log in to UI while Postgres uses "trust" authenticationThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364608).
I am unable to log in to the Stork UI when Postgres is using `trust` authentication with no pass...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364608).
I am unable to log in to the Stork UI when Postgres is using `trust` authentication with no password.
Suppose that's part of your `pg_hba.conf`:
```
local all postgres peer
# TYPE DATABASE USER ADDRESS METHOD
# "local" is for Unix domain socket connections only
local all stork trust
local all all peer
```
It configures the database to allow user Stork with no password. I can start Stork server with this configuration and an empty (default) password. However, I get an error trying to login to the Stork UI because the session manager is using libpq library (not a `go-pg` library) which in our case is not handling well this authentication method:
```
stork-server[17064]: 2023/04/04 20:44:35 pq: password authentication failed for user "stork"
```
Using the `password` authentication and specifying the password in the `server.env` file works.
BTW, I tried it on Ubuntu 22.04 with Stork installed from the packages.1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1019Sed errors on MacOS2023-05-22T14:26:32ZSlawek FigielSed errors on MacOSThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364568).
When I build and install the agent or a server on mac, I am getting the following `sed` error:
...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364568).
When I build and install the agent or a server on mac, I am getting the following `sed` error:
```
chmod 644 dist/agent/lib/systemd/system/isc-stork-agent.service
/usr/bin/sed -i s/\(ExecStart=\)/\1\/usr\/bin\//g dist/agent/lib/systemd/system/isc-stork-agent.service
sed: 1: "dist/agent/lib/systemd/ ...": extra characters at the end of d command
rake aborted!
Command failed with status (1): [/usr/bin/sed -i s/\(ExecStart=\)/\1\/usr\/...]
/Users/marcin/devel/stork/rakelib/40_dist.rake:98:in `block in <top (required)>'
/Library/Ruby/Gems/2.6.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
Tasks: TOP => install:agent => dist/agent => dist/agent/lib/systemd/system/isc-stork-agent.service
```
The second attempt was successful.1.11Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/1018DB password is not prompted2023-06-06T12:40:54ZSlawek FigielDB password is not promptedThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364567).
I build stork-server on mac and attempted to start it. I am getting the following error:
```
./...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364567).
I build stork-server on mac and attempted to start it. I am getting the following error:
```
./stork-server --rest-static-files-dir=/Users/marcin/devel/stork-build/usr/share/stork/www/ --db-host=/tmp/ --db-user=stork
WARN[2023-04-04 16:30:09] server.go:195 The hook directory: '/var/lib/stork-server/hooks' doesn't exist error="cannot find plugin paths in: /var/lib/stork-server/hooks: cannot list hook directory: /var/lib/stork-server/hooks: open /var/lib/stork-server/hooks: no such file or directory"
INFO[2023-04-04 16:30:09] connection.go:90 Checking connection to database
FATA[2023-04-04 16:30:09] main.go:63 Cannot start the Stork Server: FATAL #28P01 empty password returned by client
unable to connect to the database using provided settings
isc.org/stork/server/database.NewPgDBConn
/Users/marcin/devel/stork-1.10.0/backend/server/database/connection.go:99
isc.org/stork/server/database.NewApplicationDatabaseConn
/Users/marcin/devel/stork-1.10.0/backend/server/database/connection.go:152
isc.org/stork/server.(*StorkServer).Bootstrap
/Users/marcin/devel/stork-1.10.0/backend/server/server.go:202
main.main
/Users/marcin/devel/stork-1.10.0/backend/cmd/stork-server/main.go:61
runtime.main
/Users/marcin/devel/stork-1.10.0/tools/golang/go/src/runtime/proc.go:250
runtime.goexit
/Users/marcin/devel/stork-1.10.0/tools/golang/go/src/runtime/asm_amd64.s:1594
```
Our help says that it is recommended to leave the password blank to be prompted, but I am not prompted.
Oddly enough, I can be prompted when I do this:
```
$ ./stork-server --rest-static-files-dir=/Users/marcin/devel/stork-build/usr/share/stork/www/ --db-host=/tmp/ --db-user=stork --db-password=" "
WARN[2023-04-04 16:33:28] server.go:195 The hook directory: '/var/lib/stork-server/hooks' doesn't exist error="cannot find plugin paths in: /var/lib/stork-server/hooks: cannot list hook directory: /var/lib/stork-server/hooks: open /var/lib/stork-server/hooks: no such file or directory"
INFO[2023-04-04 16:33:28] connection.go:90 Checking connection to database
database password for user stork:
```1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1017Separate Host Reservation DHCP options are not displayed after editing until ...2023-06-02T18:18:23ZSlawek FigielSeparate Host Reservation DHCP options are not displayed after editing until refresh.The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364547).
Separate Host Reservation DHCP options are not displayed after editing until refresh.
Steps to ...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364547).
Separate Host Reservation DHCP options are not displayed after editing until refresh.
Steps to reproduce:
1. Add host reservation with the `Configure individual server values.` switch unchecked. Assign to it any DHCP option.
2. Edit the reservation, enable the above switch, and change the DHCP option value for one server.
3. Open the edited host reservation page.
4. Observe that the single DHCP option panel is displayed.1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1015Format stork-tool help text2023-05-31T17:33:35ZSlawek FigielFormat stork-tool help textThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364521).
The help text for the `stork-tool` is not formatted properly:
```
$ ./stork-tool --help
NAME:
...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364521).
The help text for the `stork-tool` is not formatted properly:
```
$ ./stork-tool --help
NAME:
stork-tool - A tool for managing Stork Server.
The tool operates in three areas:
- Certificate Management - it allows for exporting Stork Server keys, certificates,
and tokens that are used to secure communication between the Stork Server
and Stork Agents;
- Database Creation - it facilitates creating a new database for the Stork Server,
and a user that can access this database with a generated password;
- Database Migration - it allows for performing database schema migrations,
overwriting the db schema version and getting its current value.
USAGE:
stork-tool [global options] command [command options] [arguments...]
```
There is an exceptionally big indentation of the paragraph starting with "The tool operates in...."1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1014Fix misalignment of inline icons after PrimeNG upgrade2023-09-27T07:21:53ZSlawek FigielFix misalignment of inline icons after PrimeNG upgradeThe issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364517).
The checkbox is not aligned with the label inside the "Checker list" panel. The problem occurs o...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364517).
The checkbox is not aligned with the label inside the "Checker list" panel. The problem occurs on the application and "Review Checkers" pages. It may indicate a problem with table CSS styles after the last PrimeNG update.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/99b2c3c10cb1c58e81a6123f5284b7be/image.png)
EDIT: The similar problem occurs for most of the inline icons in the text (icons on the "Review Checkers", button on any machine page, buttons on the machine list).1.13Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/stork/-/issues/1007Go over our database update statements and exclude created_at updates2023-04-18T14:34:57ZMarcin SiodelskiGo over our database update statements and exclude created_at updatesWhen I was working on #996, I realised that our `dbmodel.Update...` calls may be wrongly updating the `created_at` columns. It becomes apparent when you have an instance in the database and, instead of getting it before the update from t...When I was working on #996, I realised that our `dbmodel.Update...` calls may be wrongly updating the `created_at` columns. It becomes apparent when you have an instance in the database and, instead of getting it before the update from the database, you create a sibling instance and attempt to use it in the update. In that case, you typically don't set the `created_at` value and it defaults to nil. As a result, `go-pg` will try to set the nil value which is prohibited due to the `NOT NULL` constraint.
In general, the updates should not modify this timestamp. Therefore, the `created_at` column should be excluded from the update statement, like this:
```golang
result, err := tx.Model(host).WherePK().ExcludeColumn("created_at").Update()
```
I think we're lucky we haven't hit this issue before.1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1005RunHookInspectFile unit test fails on mac2023-05-31T17:33:35ZMarcin SiodelskiRunHookInspectFile unit test fails on macOne of the `stork-tool` unit tests always fails for me on mac:
```
START| RunHookInspectFile
| fatal error: runtime: no plugin module data
| goroutine 43 [running]:
| runtime.throw({0x100943332?, 0x10000f41e?})
| /Us...One of the `stork-tool` unit tests always fails for me on mac:
```
START| RunHookInspectFile
| fatal error: runtime: no plugin module data
| goroutine 43 [running]:
| runtime.throw({0x100943332?, 0x10000f41e?})
| /Users/marcin/devel/stork/tools/golang/go/src/runtime/panic.go:992 +0x71 fp=0xc0002a4fd0 sp=0xc0002a4fa0 pc=0x100038a91
| plugin.lastmoduleinit()
| /Users/marcin/devel/stork/tools/golang/go/src/runtime/plugin.go:20 +0x8d0 fp=0xc0002a50b8 sp=0xc0002a4fd0 pc=0x10006a0f0
| plugin.open({0x7ff7bfeff620, 0x58})
| /Users/marcin/devel/stork/tools/golang/go/src/plugin/plugin_dlopen.go:77 +0x3fb fp=0xc0002a53b0 sp=0xc0002a50b8 pc=0x1004783bb
| plugin.Open(...)
| /Users/marcin/devel/stork/tools/golang/go/src/plugin/plugin.go:32
| isc.org/stork/hooksutil.NewLibraryManager({0x7ff7bfeff620, 0x58})
| /Users/marcin/devel/stork/backend/hooksutil/librarymanager.go:29 +0x4b fp=0xc0002a5438 sp=0xc0002a53b0 pc=0x10047930b
| isc.org/stork/cmd/stork-tool.runHookInspect(0xc00013a888?)
| /Users/marcin/devel/stork/backend/cmd/stork-tool/main.go:231 +0x96 fp=0xc0002a54c8 sp=0xc0002a5438 pc=0x1007ebbd6
| github.com/urfave/cli/v2.(*Command).Run(0xc0001e0500, 0xc0002872c0, {0xc0001e20f0, 0x3, 0x3})
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/command.go:271 +0x1364 fp=0xc0002a5888 sp=0xc0002a54c8 pc=0x1003869c4
| github.com/urfave/cli/v2.(*Command).Run(0xc0001e0780, 0xc000287140, {0xc000286f00, 0x4, 0x4})
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/command.go:264 +0x1249 fp=0xc0002a5c48 sp=0xc0002a5888 pc=0x1003868a9
| github.com/urfave/cli/v2.(*App).RunContext(0xc000000780, {0x100a51cf8?, 0xc000128018}, {0xc000286f00, 0x4, 0x4})
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/app.go:333 +0x1056 fp=0xc0002a5d98 sp=0xc0002a5c48 pc=0x100380756
| github.com/urfave/cli/v2.(*App).Run(...)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/app.go:310
| isc.org/stork/cmd/stork-tool.main()
| /Users/marcin/devel/stork/backend/cmd/stork-tool/main.go:537 +0x9c fp=0xc0002a5e20 sp=0xc0002a5d98 pc=0x1007f0b7c
| isc.org/stork/cmd/stork-tool.TestRunHookInspectFile(0x0)
| /Users/marcin/devel/stork/backend/cmd/stork-tool/main_test.go:239 +0x258 fp=0xc0002a5ea8 sp=0xc0002a5e20 pc=0x1007f3838
| testing.tRunner(0xc000083d40, 0x1009893d0)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1439 +0x214 fp=0xc0002a5fb0 sp=0xc0002a5ea8 pc=0x1001c0dd4
| testing.(*T).Run.func1()
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1486 +0x48 fp=0xc0002a5fe0 sp=0xc0002a5fb0 pc=0x1001c2588
| runtime.goexit()
| /Users/marcin/devel/stork/tools/golang/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc0002a5fe8 sp=0xc0002a5fe0 pc=0x10006f4c1
| created by testing.(*T).Run
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1486 +0x725
| goroutine 1 [chan receive]:
| testing.(*T).Run(0xc00028e000, {0x10093d656, 0x16}, 0x1009893d0)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1487 +0x750
| testing.runTests.func1(0x0?)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1839 +0x9a
| testing.tRunner(0xc00028e000, 0xc00018fba0)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1439 +0x214
| testing.runTests(0xc000260f00?, {0x100e07a20, 0xb, 0xb}, {0x40?, 0x129825798?, 0x100e17200?})
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1837 +0x7e5
| testing.(*M).Run(0xc000260f00)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1719 +0xa72
| main.main()
| _testmain.go:67 +0x2e5
| goroutine 38 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc0003640a0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 58 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260aa0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 60 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260be0, 0x1009893a0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 66 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260820, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 61 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260dc0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 67 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260960, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 83 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260c80, 0x1009893a8?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 68 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000261040, 0xc000053fd0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 69 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260fa0, 0xc000221de0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 71 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000261180, 0x1009893b0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 98 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000364140, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 72 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc0003641e0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 73 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000364320, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
FAIL | isc.org/stork/cmd/stork-tool 1.750s
```1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/997incorrect rndc key match2023-07-26T12:40:15ZPengfei Guincorrect rndc key matchHi,
there is a bug in https://gitlab.isc.org/isc-projects/stork/-/blob/master/backend/agent/bind9.go#L132
the keyword of `key` block is `key`,
```
key "name" {
algorithm "hmac-sha256";
secret "OmItW1lOyLVUEuvv+Fme+Q==";
};
```
...Hi,
there is a bug in https://gitlab.isc.org/isc-projects/stork/-/blob/master/backend/agent/bind9.go#L132
the keyword of `key` block is `key`,
```
key "name" {
algorithm "hmac-sha256";
secret "OmItW1lOyLVUEuvv+Fme+Q==";
};
```
but the regex matches `keys`.1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/980Stork Grafana Links do not honor path from Grafana URL setting2023-03-28T11:58:01ZCarsten StrotmannStork Grafana Links do not honor path from Grafana URL settingStork 1.9.0 from ISC packages
I have Grafana running on the same machine as Stork. Both are behind a NGINX reverse proxy. Stork is available on the root of the webserver:
http://machine.tld/
Grafana is available in a sub/path
http://...Stork 1.9.0 from ISC packages
I have Grafana running on the same machine as Stork. Both are behind a NGINX reverse proxy. Stork is available on the root of the webserver:
http://machine.tld/
Grafana is available in a sub/path
http://machine.tld/grafana/
I have configured the Grafana path in the Stork settings, but Stork generates links that do not point to the Grafana Path:
http://machine.tld/d/hRf18FvWz/?var-subnet=1000&var-instance=stork-demo%3A9547
Result is an empty page from Stork when using such link.1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/972Systemd executable path is not absolute2023-03-30T13:45:14ZJuliano GuidiniSystemd executable path is not absolute**Describe the bug**
Starting isc-stork-server.service generate an error on systemd in a Ubuntu 18.04.6.
```bash
# systemctl start isc-stork-server
Failed to start isc-stork-server.service: Unit isc-stork-server.service is not loaded p...**Describe the bug**
Starting isc-stork-server.service generate an error on systemd in a Ubuntu 18.04.6.
```bash
# systemctl start isc-stork-server
Failed to start isc-stork-server.service: Unit isc-stork-server.service is not loaded properly: Exec format error.
See system logs and 'systemctl status isc-stork-server.service' for details.
# systemctl status isc-stork-server.service
● isc-stork-server.service - ISC Stork Server
Loaded: error (Reason: Exec format error)
Active: inactive (dead)
Docs: man:stork-server(8)
fev 03 11:41:50 host systemd[1]: /lib/systemd/system/isc-stork-server.service:11: Executable path is not absolute: stork-server
```
**To Reproduce**
Steps to reproduce the behavior:
1. Install Stork 1.9.0.230131111251 ( by the book -> curl -1sLf 'https://dl.cloudsmith.io/public/isc/stork/cfg/setup/bash.deb.sh' | sudo bash )
2. apt install isc-stork-server
3. stork-tool db-create --db-name stork --db-user stork --db-host <Postgresql IP>
4. stork-tool db-init --db-host <Postgresql IP> --db-user stork --db-password <password>
5. stork-tool db-up --db-host <Postgresql IP> --db-user stork --db-password <password>
6. Configure /etc/stork/server.env
7. systemctl enable isc-stork-server
8. systemctl start isc-stork-server
**Expected behavior**
Stork server start normally. Like this:
```bash
# systemctl status isc-stork-server
● isc-stork-server.service - ISC Stork Server
Loaded: loaded (/lib/systemd/system/isc-stork-server.service; enabled; vendor preset: enabled)
Active: active (running) since Fri 2023-02-03 11:44:45 -03; 18min ago
Docs: man:stork-server(8)
Main PID: 29201 (stork-server)
Tasks: 9 (limit: 4915)
CGroup: /system.slice/isc-stork-server.service
└─29201 /usr/bin/stork-server
fev 03 12:01:45 host stork-server[29201]: time="2023-02-03 12:01:45" level="info" msg="Completed pulling hosts from Kea daemons" file=" host.go:111 " erred_count="0" skipped_count="0" success_count="0"
fev 03 12:01:45 host stork-server[29201]: time="2023-02-03 12:01:45" level="info" msg="Completed pulling DHCP status from Kea apps: 0/0 succeeded" file=" status.go:256 "
fev 03 12:01:45 host stork-server[29201]: time="2023-02-03 12:01:45" level="info" msg="Completed pulling information from machines: 0/0 succeeded" file=" statepuller.go:73 "
fev 03 12:02:15 host stork-server[29201]: time="2023-02-03 12:02:15" level="info" msg="Completed pulling information from machines: 0/0 succeeded" file=" statepuller.go:73 "
fev 03 12:02:15 host stork-server[29201]: time="2023-02-03 12:02:15" level="info" msg="Completed pulling DHCP status from Kea apps: 0/0 succeeded" file=" status.go:256 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling stats from BIND 9 apps: 0/0 succeeded" file=" statspuller.go:62 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling lease stats from Kea apps: 0/0 succeeded" file=" statspuller.go:71 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling hosts from Kea daemons" file=" host.go:111 " erred_count="0" skipped_count="0" success_count="0"
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling information from machines: 0/0 succeeded" file=" statepuller.go:73 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling DHCP status from Kea apps: 0/0 succeeded" file=" status.go:256 "
```
**Environment:**
- Stork: 1.9.0.230131111251
- OS: Ubuntu 18.04.6 LTS - amd_64
- systemd: 237-3ubuntu10.56
**Additional Information**
I'd tested another server, running Debian 11, and this error is not observed.
- Stork version: 1.9.0.230131111251
- OS: Debian GNU/Linux 11 (bullseye) - amd_64
- systemd: 247.3-7+deb11u1
**Describe the solution you'd like**
Change the Unit ExecStart to :
```
ExecStart=/usr/bin/stork-server
```1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/970The IPv6 subnet bar is always double on the shared network page2023-03-03T12:09:58ZSlawek FigielThe IPv6 subnet bar is always double on the shared network pageThe issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348489).
The delegated prefix bar on the subnet bar is shown even if there are no delegated prefixes. The p...The issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348489).
The delegated prefix bar on the subnet bar is shown even if there are no delegated prefixes. The problem occurs only on the shared network page.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/8fd55425e9dfcd31aeec0e4805d7452a/image.png)1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/960rake demo:up fails to build2023-02-08T16:52:55ZRazvan Becheriurake demo:up fails to buildafter rebasing #117 rake demo:up fails to build/runafter rebasing #117 rake demo:up fails to build/run1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/928Cannot delete machine with config reports2023-02-08T16:52:56ZSlawek FigielCannot delete machine with config reportsI cannot delete a machine with config reports.
```
time="2022-12-29 15:15:43" level="info" msg="HTTP request incoming" file=" middleware.go:79 " method="DELETE" path="/api/machines/5" remote="[::1]:46082"
time="2022-12-29 15:15:...I cannot delete a machine with config reports.
```
time="2022-12-29 15:15:43" level="info" msg="HTTP request incoming" file=" middleware.go:79 " method="DELETE" path="/api/machines/5" remote="[::1]:46082"
time="2022-12-29 15:15:56" level="error" msg="problem deleting machine 5: ERROR #23503 update or delete on table \"daemon\" violates foreign key constraint \"config_report_daemon_id\" on table \"config_report\"" file=" machines.go:687 "
```
The problem occurs on the `agent-kea` and `agent-kea6` demo machines.
After executing the `DELETE FROM config_report;` SQL query, the machine is properly deleted.1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/927Address and PD pools aren't updated2024-01-17T13:03:22ZSlawek FigielAddress and PD pools aren't updatedThe Stork server ignores changes in the address and PD pools.The Stork server ignores changes in the address and PD pools.1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/915The hook list has invalid hook documentation links (Kea 2.0.2, Kea 2.4.0)2023-12-01T15:42:06ZSlawek FigielThe hook list has invalid hook documentation links (Kea 2.0.2, Kea 2.4.0)The issue was reported during 1.8.0 sanity checks by @slawek. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/910#note_334981)
Hook doc buttons have the wrong labels in the links for Kea 2.0.2 (works well for the latest Kea ...The issue was reported during 1.8.0 sanity checks by @slawek. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/910#note_334981)
Hook doc buttons have the wrong labels in the links for Kea 2.0.2 (works well for the latest Kea version).
Expected:
`https://kea.readthedocs.io/en/kea-2.0.2/arm/hooks.html#stat-cmds-supplemental-statistics-commands`
Actual:
`https://kea.readthedocs.io/en/kea-2.0.2/arm/hooks.html#stat-cmds-statistics-commands-for-supplemental-lease-statistics`
![image](https://gitlab.isc.org/isc-projects/stork/uploads/72448a9b77b60ac69937d31b1138705b/image.png)1.14Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/913Man is not installed by packages2022-12-19T10:42:03ZSlawek FigielMan is not installed by packagesThe issue was reported during the 1.8.0 sanity checks by @marcin [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/910#note_335140)
When I installed the packages on Fedora and Ubuntu I expected that I can do:
```
$ man stork-...The issue was reported during the 1.8.0 sanity checks by @marcin [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/910#note_335140)
When I installed the packages on Fedora and Ubuntu I expected that I can do:
```
$ man stork-server
$ man stork-agent
```
to display the manual packages. However, it doesn't work:
```
$ man stork-server
No manual entry for stork-server
```1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/909Unstable test_add_kea_with_many_subnets system test2022-12-19T09:20:22ZSlawek FigielUnstable test_add_kea_with_many_subnets system testThe `test_add_kea_with_many_subnets` system test is unstable because the test execution runs before the loading Kea configuration is finished.The `test_add_kea_with_many_subnets` system test is unstable because the test execution runs before the loading Kea configuration is finished.1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/900Bug: Daemons displayed twice in Services > Machines2023-01-02T12:12:50ZmikygeeBug: Daemons displayed twice in Services > MachinesHello,
On the page Services > Machines the daemons are displayed twice.
![image](/uploads/27d51e92e30d497e796b15d244d5e4de/image.png)
RegardsHello,
On the page Services > Machines the daemons are displayed twice.
![image](/uploads/27d51e92e30d497e796b15d244d5e4de/image.png)
Regards1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/882Communication events should be bound to the machine2023-01-18T10:41:10ZSlawek FigielCommunication events should be bound to the machineThe issue was found during 1.8.0 sanity checks by @slawek. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/875#note_320902).
I have a different set of events on the Dashboard and the machine page. The communication messages ...The issue was found during 1.8.0 sanity checks by @slawek. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/875#note_320902).
I have a different set of events on the Dashboard and the machine page. The communication messages with a warning level are missing on the machine page.
The event viewer presents all messages until I filter by a specific machine. In this case, the communication messages disappear.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/e121b7184e2ca7b39d7e5602496c12b0/image.png) ![image](https://gitlab.isc.org/isc-projects/stork/uploads/947fe6e517cbec24e31f1ed5bcc0ccb2/image.png)
![image](https://gitlab.isc.org/isc-projects/stork/uploads/171f5769f1bb2e0d3bd390cb6759d3fd/image.png) ![image](https://gitlab.isc.org/isc-projects/stork/uploads/12cd5dbf6e0afcc2d66a4dfe0c3ee5ba/image.png)1.9Slawek FigielSlawek Figiel