stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2023-06-02T16:58:27Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1036Include statements with non-JSON extensions in Kea CA config2023-06-02T16:58:27ZSlawek FigielInclude statements with non-JSON extensions in Kea CA configStork supports the `include` statements in the Kea Control Agent configuration, but only if the included file has a `.json` extension. Kea allows any extensions. If the Kea Control Agent configuration contains the `include` statement wit...Stork supports the `include` statements in the Kea Control Agent configuration, but only if the included file has a `.json` extension. Kea allows any extensions. If the Kea Control Agent configuration contains the `include` statement with the non-JSON file, Stork throws an error and rejects the particular Kea.
The problem was reported on our mailing list on 2023-05-11:
> The Stork Agent is not happy when a KEA configuration file has an include statement in it. This is the error I see on the syslog:
>
> ```
> level="error" msg="Invalid Kea Control Agent config" file=" kea.go:215 " error="Cannot parse Kea Control Agent config file: problem parsing Kea configuration: invalid character '<' looking for beginning of object key string: invalid character '<' looking for beginning of object key string"
> ```
> And the configuration file it is trying to read is starting as:
> ```
> {
> "Control-agent": {
> <?include "/mnt/data/etc/kea/local-ctrl-agent.include"?>
> ```
>
> Hmm… KEA accepts the .include extension though, so shouldn’t Stork accept what KEA accepts?1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1031Difficult to monitor BIND with stork-agent2023-06-05T18:17:45ZDarren AnkneyDifficult to monitor BIND with stork-agentStork-agent is not able to make use of the simple rndc.key found in the bind configuration directory. It complains there is no control clause as shown:
```
May 3 14:31:06 dynamic-192-168-20-20 stork-agent[8367]: time="2023-05-03 14:31:...Stork-agent is not able to make use of the simple rndc.key found in the bind configuration directory. It complains there is no control clause as shown:
```
May 3 14:31:06 dynamic-192-168-20-20 stork-agent[8367]: time="2023-05-03 14:31:06" level="info" msg="Found BIND 9 config file in /etc/bind/named.conf based on output of `named -V`." file=" bind9.go:485 "
May 3 14:31:06 dynamic-192-168-20-20 stork-agent[8367]: time="2023-05-03 14:31:06" level="warning" msg="Cannot determine BIND 9 rndc details: cannot determine rndc key" file=" bind9.go:561 "
```
Perhaps this is as intended. However, if you then configure rndc.conf and bind correctly using rndc-confgen, it still does not work as it uses an incorrect format for executing rndc as shown:
```
May 3 14:51:09 dynamic-192-168-20-20 stork-agent[9178]: time="2023-05-03 14:51:09" level="debug" msg="Rndc: [/usr/sbin/rndc -s 127.0.0.1 -p 953 -y hmac-sha256:iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM= status]" file=" bind9.go:125 "
May 3 14:51:09 dynamic-192-168-20-20 stork-agent[9178]: time="2023-05-03 14:51:09" level="error" msg="Failed to forward commands to rndc: exit status 1" file=" agent.go:244 " Address="127.0.0.1" Port="953"
```
The rndc command is being executed like so: `rndc -s 127.0.0.1 -p 953 -y hmac-sha256:iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM= status`
This produces errors if run from the command line as shown:
```
$ rndc -s 127.0.0.1 -p 953 -y hmac-sha256:iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM= status
rndc: no key definition for name hmac-sha256:iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM=
```
Proper syntax is as follows: `rndc -s 127.0.0.1 -p 953 -y rndc-key status`. Relevant configuration shown below:
excerpt of named.conf:
```
key "rndc-key" {
algorithm hmac-sha256;
secret "iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM=";
};
controls {
inet 127.0.0.1 port 953 allow { 127.0.0.1; } keys { "rndc-key"; };
};
```
rndc.conf:
```
# Start of rndc.conf
key "rndc-key" {
algorithm hmac-sha256;
secret "iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM=";
};
options {
default-key "rndc-key";
default-server 127.0.0.1;
default-port 953;
};
# End of rndc.conf
```
Alternatively, the rndc.conf file could be specified on the command line: `rndc -c /etc/bind/rndc.conf status` which would allow you to remove the ip and port specification from the command line as it is in the conf file.
A third option, to obviate the need for the administrator to create an rndc.conf file, would be to look for rndc.key if no rndc.conf or controls clause (in named.conf) was found. An rndc.key file can be specified as follows: `rndc -k /etc/bind/rndc.key status`. If a rndc.key file exists in the directory with named.conf (can be generated with `rndc-confgen -a` if it was removed) and no controls clause exists in named.conf, then named will allow connections locally using the key in that key file. Many administrators use rndc this way, so something to consider.
The only way to get bind monitoring working at the moment is to setup rndc.conf this way:
```
#key "rndc-key" {
key "hmac-sha256:iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM=" {
algorithm hmac-sha256;
secret "iCQvHPqq43AvFK/xRHaKrUiq4GPaFyBpvt/GwKSvKwM=";
};
options {
default-key "rndc-key";
default-server 127.0.0.1;
default-port 953;
};
```
which, I assume, means that if the -y is specified on the command line that rndc is ignoring the options section with the defaults defined.
[RT22012](https://support.isc.org/Ticket/Display.html?id=22012)1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1024As soon as stork-agent is running, stock-server loop-crashes SIGSEGV2023-05-31T17:33:42ZhELLO wORLDAs soon as stork-agent is running, stock-server loop-crashes SIGSEGV---
name: Bug report
---
**Describe the bug**
I have a fresh install of stork-server 1.10 on a VM (Linux xena 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux) using the ubuntu apt method as ...---
name: Bug report
---
**Describe the bug**
I have a fresh install of stork-server 1.10 on a VM (Linux xena 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux) using the ubuntu apt method as described in the documentation.
On two other similar VMs, I install also from apt the stork-agent and set them up so that they can communicates with the stork-server.
As soon as I start the stork-agent service via systemctl (same on either VMs with the agent), the stork-server crashes (`SIGSEGV`) and respawns and crashes again in a loop.
As soon as I stop the stork-agent service, the server stops crashing and behaves normal again.
**To Reproduce**
Steps to reproduce the behavior:
1. Install stork-server 1.10 on a x86_64 linux VM. Install stork-agent 1.10 on another similar x86_64 linux VM.
2. Sync them (either server or agent API Key method)
3. The device with the stork-agent in my network does the following: starting the service
4. stork-server does the following: loop-crashes
**Expected behavior**
The stork-server is not supposed to crash…
**Environment:**
- Stork: 1.10
- OS: Ubuntu 22.04.1 LTS x86_64
**Additional Information**
stork-server config: (default beside DB password)
stork-agent config: default, I do not edit it and use this command to sync it with the server `sudo -u stork-agent stork-agent register -u http://[SERVER_IPV6]:8080`)
stork-server log:
```
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="warning" msg="problem with version-get and kea daemon d2: unable to forward command to the d2 service: No such file or directory. The server is likely to be offline" file=" appkea.go:210 "
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="warning" msg="problem with config-get and kea daemon d2: unable to forward command to the d2 service: No such file or directory. The server is likely to be offline" file=" appkea.go:262 "
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="Event 'added <daemon id=\"13\" name=\"ca\" appId=\"4\" appType=\"kea\"> to <app id=\"4\" name=\"kea@2001:db8:1100:19::1\" type=\"kea\" version=\"2.1.7\">'" file=" eventcenter.go:122 "
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="Event 'added <daemon id=\"14\" name=\"d2\" appId=\"4\" appType=\"kea\"> to <app id=\"4\" name=\"kea@2001:db8:1100:19::1\" type=\"kea\" version=\"2.1.7\">'" file=" eventcenter.go:122 "
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="Event 'added <daemon id=\"15\" name=\"dhcp4\" appId=\"4\" appType=\"kea\"> to <app id=\"4\" name=\"kea@2001:db8:1100:19::1\" type=\"kea\" version=\"2.1.7\">'" file=" eventcenter.go:122 "
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="Event 'added <daemon id=\"16\" name=\"dhcp6\" appId=\"4\" appType=\"kea\"> to <app id=\"4\" name=\"kea@2001:db8:1100:19::1\" type=\"kea\" version=\"2.1.7\">'" file=" eventcenter.go:122 "
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="scheduling a new configuration review" file=" dispatcher.go:511 " daemon_id="13" name="ca" triggers="[config change]"
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="scheduling a new configuration review" file=" dispatcher.go:511 " daemon_id="15" name="dhcp4" triggers="[config change]"
Apr 11 15:45:51 xena stork-server[2917436]: time="2023-04-11 15:45:51" level="info" msg="scheduling a new configuration review" file=" dispatcher.go:511 " daemon_id="16" name="dhcp6" triggers="[config change]"
Apr 11 15:45:51 xena stork-server[2917436]: panic: runtime error: invalid memory address or nil pointer dereference
Apr 11 15:45:51 xena stork-server[2917436]: [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0xec3e1d]
Apr 11 15:45:51 xena stork-server[2917436]: goroutine 182 [running]:
Apr 11 15:45:51 xena stork-server[2917436]: isc.org/stork/server/configreview.findOverlaps.func1(0xc000629a70?, 0xc000c5aa50?)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/backend/server/configreview/keachecker.go:598 +0x9d
Apr 11 15:45:51 xena stork-server[2917436]: sort.insertionSort_func({0xc000c5ac48?, 0xc00082ec00?}, 0x0, 0x4)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/tools/golang/go/src/sort/zsortfunc.go:12 +0xb1
Apr 11 15:45:51 xena stork-server[2917436]: sort.pdqsort_func({0xc000c5ac48?, 0xc00082ec00?}, 0xc000629a70?, 0x0?, 0xc000700b3c?)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/tools/golang/go/src/sort/zsortfunc.go:73 +0x345
Apr 11 15:45:51 xena stork-server[2917436]: sort.Slice({0x11f4f40, 0xc000629a70}, 0x4?)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/tools/golang/go/src/sort/slice.go:23 +0x97
Apr 11 15:45:51 xena stork-server[2917436]: isc.org/stork/server/configreview.findOverlaps({0xc000a67ac0, 0x4, 0xc0002ca422?}, 0xa)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/backend/server/configreview/keachecker.go:589 +0xdc
Apr 11 15:45:51 xena stork-server[2917436]: isc.org/stork/server/configreview.subnetsOverlapping(0xc000a4ea80)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/backend/server/configreview/keachecker.go:525 +0x170
Apr 11 15:45:51 xena stork-server[2917436]: isc.org/stork/server/configreview.(*dispatcherImpl).runForDaemon(0xc0004504d0, 0xc0003f70a0, {0xc00060d310, 0x1, 0x1}, {0xc0003a85e0, 0x4, 0x0?}, 0x0)
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/backend/server/configreview/dispatcher.go:438 +0x31b
Apr 11 15:45:51 xena stork-server[2917436]: created by isc.org/stork/server/configreview.(*dispatcherImpl).beginReview
Apr 11 15:45:51 xena stork-server[2917436]: /builds/isc-projects/stork/backend/server/configreview/dispatcher.go:535 +0x58a
Apr 11 15:45:51 xena systemd[1]: isc-stork-server.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Apr 11 15:45:51 xena systemd[1]: isc-stork-server.service: Failed with result 'exit-code'.
Apr 11 15:45:51 xena systemd[1]: isc-stork-server.service: Consumed 2.175s CPU time.
Apr 11 15:45:51 xena systemd[1]: isc-stork-server.service: Scheduled restart job, restart counter is at 1.
Apr 11 15:45:51 xena systemd[1]: Stopped ISC Stork Server.
Apr 11 15:45:51 xena systemd[1]: isc-stork-server.service: Consumed 2.175s CPU time.
Apr 11 15:45:51 xena systemd[1]: Started ISC Stork Server.
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Checking connection to database" file=" connection.go:90 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Connected to database /var/run/postgresql/.s.PGSQL.5432" file=" connection.go:145 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Database is up-to-date" file=" connection.go:174 " version="51"
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Preparing certs, it may take several minutes" file=" certs.go:191 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Root CA key and cert OK" file=" certs.go:101 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Server key and cert OK" file=" certs.go:180 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Started EventCenter" file=" eventcenter.go:48 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Starting the configuration review dispatcher" file=" dispatcher.go:869 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Starting Apps State puller" file=" periodicexecutor.go:34 "
Apr 11 15:45:51 xena stork-server[2924837]: time="2023-04-11 15:45:51" level="info" msg="Started Apps State puller" file=" periodicexecutor.go:67 "
```
stork-agent log:
```
-- Logs begin at Tue 2023-04-11 08:30:45 CEST, end at Tue 2023-04-11 15:49:29 CEST. --
Apr 11 15:45:17 radius2 systemd[1]: Started ISC Stork Agent.
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="Starting Stork Agent, version 1.10.0, build date 2023-04-04 08:12" file=" main.go:44 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="warning" msg="The hook directory: '/var/lib/stork-agent/hooks' doesn't exist" file=" main.go:54 " error="cannot find plugin paths in: /var/lib/stork-agent/hooks: cannot list hook directory: /var/lib/stork-agent/hooks: open /var/lib/stork-agent/hooks: no such file or directory"
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="The Basic Auth credentials file (/etc/stork/agent-credentials.json) is missing - HTTP authentication is not used" file=" caclient.go:72 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="The Basic Auth credentials file (/etc/stork/agent-credentials.json) is missing - HTTP authentication is not used" file=" caclient.go:72 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="The Basic Auth credentials file (/etc/stork/agent-credentials.json) is missing - HTTP authentication is not used" file=" caclient.go:72 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="Prometheus Kea Exporter listening on 0.0.0.0:9547, stats pulling interval: 10 seconds" file=" promkeaexporter.go:638 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="Started app monitor" file=" monitor.go:100 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="New or updated apps detected:" file=" monitor.go:176 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg=" kea: control: http://127.0.0.1:8000/ (auth key: not found)" file=" monitor.go:188 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="warning" msg="Skipped refreshing viewable log files because config-get returned unsuccessful result" file=" kea.go:68 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="Prometheus BIND 9 Exporter listening on 0.0.0.0:9119, stats pulling interval: 10 seconds" file="prombind9exporter.go:826 "
Apr 11 15:45:17 radius2 stork-agent[23543]: time="2023-04-11 15:45:17" level="info" msg="Started serving Stork Agent" file=" agent.go:445 " address="[::]:8080"
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v4-allocation-fail" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v4-allocation-fail-classes" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v4-allocation-fail-subnet" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v4-allocation-fail-no-pools" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v4-allocation-fail-shared-network" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v6-allocation-fail-no-pools" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: subnet[1].v6-allocation-fail-subnet" file=" promkeaexporter.go:764 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v6-allocation-fail-shared-network" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v6-allocation-fail-subnet" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v6-allocation-fail" file=" promkeaexporter.go:771 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: subnet[1].v6-allocation-fail-no-pools" file=" promkeaexporter.go:764 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: pkt6-confirm-received" file=" promkeaexporter.go:737 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: subnet[1].v6-allocation-fail-classes" file=" promkeaexporter.go:764 "
Apr 11 15:45:27 radius2 stork-agent[23543]: time="2023-04-11 15:45:27" level="warning" msg="Encountered unsupported stat: v6-allocation-fail-classes" file=" promkeaexporter.go:771 "
Apr 11 15:45:51 radius2 stork-agent[23543]: time="2023-04-11 15:45:51" level="info" msg="Loaded server cert: /var/lib/stork-agent/certs/cert.pem and key: /var/lib/stork-agent/certs/key.pem\n" file=" agent.go:104 "
Apr 11 15:45:51 radius2 stork-agent[23543]: time="2023-04-11 15:45:51" level="info" msg="Loaded CA cert: /var/lib/stork-agent/certs/ca.pem\n" file=" agent.go:78 "
Apr 11 15:45:51 radius2 stork-agent[23543]: time="2023-04-11 15:45:51" level="warning" msg="Skipped refreshing viewable log files because config-get returned unsuccessful result" file=" kea.go:68 "
Apr 11 15:46:21 radius2 systemd[1]: Stopping ISC Stork Agent...
Apr 11 15:46:21 radius2 systemd[1]: isc-stork-agent.service: Main process exited, code=killed, status=15/TERM
Apr 11 15:46:21 radius2 systemd[1]: isc-stork-agent.service: Succeeded.
Apr 11 15:46:21 radius2 systemd[1]: Stopped ISC Stork Agent.
```
Thank you for your attention on this matter :smile:1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1022Cannot log in to UI while Postgres uses "trust" authentication2023-06-05T17:31:34ZSlawek FigielCannot log in to UI while Postgres uses "trust" authenticationThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364608).
I am unable to log in to the Stork UI when Postgres is using `trust` authentication with no pass...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364608).
I am unable to log in to the Stork UI when Postgres is using `trust` authentication with no password.
Suppose that's part of your `pg_hba.conf`:
```
local all postgres peer
# TYPE DATABASE USER ADDRESS METHOD
# "local" is for Unix domain socket connections only
local all stork trust
local all all peer
```
It configures the database to allow user Stork with no password. I can start Stork server with this configuration and an empty (default) password. However, I get an error trying to login to the Stork UI because the session manager is using libpq library (not a `go-pg` library) which in our case is not handling well this authentication method:
```
stork-server[17064]: 2023/04/04 20:44:35 pq: password authentication failed for user "stork"
```
Using the `password` authentication and specifying the password in the `server.env` file works.
BTW, I tried it on Ubuntu 22.04 with Stork installed from the packages.1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1020Some Bind9-related events are not shown in the event viewer.2023-05-31T14:37:51ZSlawek FigielSome Bind9-related events are not shown in the event viewer.The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364604).
Some Bind9-related events are not shown in the event viewer.
Event viewer:
![image](https://gi...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364604).
Some Bind9-related events are not shown in the event viewer.
Event viewer:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/a1912d23b4d8d0a44c596eddb0e2d576/image.png)
Machine events:
![image](https://gitlab.isc.org/isc-projects/stork/uploads/b2cf194950ebc9a852226292e64b4781/image.png)1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1019Sed errors on MacOS2023-05-22T14:26:32ZSlawek FigielSed errors on MacOSThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364568).
When I build and install the agent or a server on mac, I am getting the following `sed` error:
...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364568).
When I build and install the agent or a server on mac, I am getting the following `sed` error:
```
chmod 644 dist/agent/lib/systemd/system/isc-stork-agent.service
/usr/bin/sed -i s/\(ExecStart=\)/\1\/usr\/bin\//g dist/agent/lib/systemd/system/isc-stork-agent.service
sed: 1: "dist/agent/lib/systemd/ ...": extra characters at the end of d command
rake aborted!
Command failed with status (1): [/usr/bin/sed -i s/\(ExecStart=\)/\1\/usr\/...]
/Users/marcin/devel/stork/rakelib/40_dist.rake:98:in `block in <top (required)>'
/Library/Ruby/Gems/2.6.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
Tasks: TOP => install:agent => dist/agent => dist/agent/lib/systemd/system/isc-stork-agent.service
```
The second attempt was successful.1.11Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/1018DB password is not prompted2023-06-06T12:40:54ZSlawek FigielDB password is not promptedThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364567).
I build stork-server on mac and attempted to start it. I am getting the following error:
```
./...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364567).
I build stork-server on mac and attempted to start it. I am getting the following error:
```
./stork-server --rest-static-files-dir=/Users/marcin/devel/stork-build/usr/share/stork/www/ --db-host=/tmp/ --db-user=stork
WARN[2023-04-04 16:30:09] server.go:195 The hook directory: '/var/lib/stork-server/hooks' doesn't exist error="cannot find plugin paths in: /var/lib/stork-server/hooks: cannot list hook directory: /var/lib/stork-server/hooks: open /var/lib/stork-server/hooks: no such file or directory"
INFO[2023-04-04 16:30:09] connection.go:90 Checking connection to database
FATA[2023-04-04 16:30:09] main.go:63 Cannot start the Stork Server: FATAL #28P01 empty password returned by client
unable to connect to the database using provided settings
isc.org/stork/server/database.NewPgDBConn
/Users/marcin/devel/stork-1.10.0/backend/server/database/connection.go:99
isc.org/stork/server/database.NewApplicationDatabaseConn
/Users/marcin/devel/stork-1.10.0/backend/server/database/connection.go:152
isc.org/stork/server.(*StorkServer).Bootstrap
/Users/marcin/devel/stork-1.10.0/backend/server/server.go:202
main.main
/Users/marcin/devel/stork-1.10.0/backend/cmd/stork-server/main.go:61
runtime.main
/Users/marcin/devel/stork-1.10.0/tools/golang/go/src/runtime/proc.go:250
runtime.goexit
/Users/marcin/devel/stork-1.10.0/tools/golang/go/src/runtime/asm_amd64.s:1594
```
Our help says that it is recommended to leave the password blank to be prompted, but I am not prompted.
Oddly enough, I can be prompted when I do this:
```
$ ./stork-server --rest-static-files-dir=/Users/marcin/devel/stork-build/usr/share/stork/www/ --db-host=/tmp/ --db-user=stork --db-password=" "
WARN[2023-04-04 16:33:28] server.go:195 The hook directory: '/var/lib/stork-server/hooks' doesn't exist error="cannot find plugin paths in: /var/lib/stork-server/hooks: cannot list hook directory: /var/lib/stork-server/hooks: open /var/lib/stork-server/hooks: no such file or directory"
INFO[2023-04-04 16:33:28] connection.go:90 Checking connection to database
database password for user stork:
```1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1017Separate Host Reservation DHCP options are not displayed after editing until ...2023-06-02T18:18:23ZSlawek FigielSeparate Host Reservation DHCP options are not displayed after editing until refresh.The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364547).
Separate Host Reservation DHCP options are not displayed after editing until refresh.
Steps to ...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364547).
Separate Host Reservation DHCP options are not displayed after editing until refresh.
Steps to reproduce:
1. Add host reservation with the `Configure individual server values.` switch unchecked. Assign to it any DHCP option.
2. Edit the reservation, enable the above switch, and change the DHCP option value for one server.
3. Open the edited host reservation page.
4. Observe that the single DHCP option panel is displayed.1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1016Subnet filtration doesn't work2023-05-16T14:46:01ZSlawek FigielSubnet filtration doesn't workThe issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364530).
The subnet filtration on the subnet page doesn't work.
Steps to reproduce:
1. Open the Subnets...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364530).
The subnet filtration on the subnet page doesn't work.
Steps to reproduce:
1. Open the Subnets page
1. Type `1.15.2` or `3008:` in the filter subnets input
1. Press Enter
1. Observe that nothing happens
![image](https://gitlab.isc.org/isc-projects/stork/uploads/4d44eadcab4d9802f7ef28e7736c0201/image.png) ![image](https://gitlab.isc.org/isc-projects/stork/uploads/77946dd9069dcbf545e0b3a4900e2f8c/image.png)1.11Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1015Format stork-tool help text2023-05-31T17:33:35ZSlawek FigielFormat stork-tool help textThe issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364521).
The help text for the `stork-tool` is not formatted properly:
```
$ ./stork-tool --help
NAME:
...The issue was reported by @marcin during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364521).
The help text for the `stork-tool` is not formatted properly:
```
$ ./stork-tool --help
NAME:
stork-tool - A tool for managing Stork Server.
The tool operates in three areas:
- Certificate Management - it allows for exporting Stork Server keys, certificates,
and tokens that are used to secure communication between the Stork Server
and Stork Agents;
- Database Creation - it facilitates creating a new database for the Stork Server,
and a user that can access this database with a generated password;
- Database Migration - it allows for performing database schema migrations,
overwriting the db schema version and getting its current value.
USAGE:
stork-tool [global options] command [command options] [arguments...]
```
There is an exceptionally big indentation of the paragraph starting with "The tool operates in...."1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1014Fix misalignment of inline icons after PrimeNG upgrade2023-09-27T07:21:53ZSlawek FigielFix misalignment of inline icons after PrimeNG upgradeThe issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364517).
The checkbox is not aligned with the label inside the "Checker list" panel. The problem occurs o...The issue was reported by @slawek during 1.10 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/1009#note_364517).
The checkbox is not aligned with the label inside the "Checker list" panel. The problem occurs on the application and "Review Checkers" pages. It may indicate a problem with table CSS styles after the last PrimeNG update.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/99b2c3c10cb1c58e81a6123f5284b7be/image.png)
EDIT: The similar problem occurs for most of the inline icons in the text (icons on the "Review Checkers", button on any machine page, buttons on the machine list).1.13Razvan BecheriuRazvan Becheriuhttps://gitlab.isc.org/isc-projects/stork/-/issues/1007Go over our database update statements and exclude created_at updates2023-04-18T14:34:57ZMarcin SiodelskiGo over our database update statements and exclude created_at updatesWhen I was working on #996, I realised that our `dbmodel.Update...` calls may be wrongly updating the `created_at` columns. It becomes apparent when you have an instance in the database and, instead of getting it before the update from t...When I was working on #996, I realised that our `dbmodel.Update...` calls may be wrongly updating the `created_at` columns. It becomes apparent when you have an instance in the database and, instead of getting it before the update from the database, you create a sibling instance and attempt to use it in the update. In that case, you typically don't set the `created_at` value and it defaults to nil. As a result, `go-pg` will try to set the nil value which is prohibited due to the `NOT NULL` constraint.
In general, the updates should not modify this timestamp. Therefore, the `created_at` column should be excluded from the update statement, like this:
```golang
result, err := tx.Model(host).WherePK().ExcludeColumn("created_at").Update()
```
I think we're lucky we haven't hit this issue before.1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1005RunHookInspectFile unit test fails on mac2023-05-31T17:33:35ZMarcin SiodelskiRunHookInspectFile unit test fails on macOne of the `stork-tool` unit tests always fails for me on mac:
```
START| RunHookInspectFile
| fatal error: runtime: no plugin module data
| goroutine 43 [running]:
| runtime.throw({0x100943332?, 0x10000f41e?})
| /Us...One of the `stork-tool` unit tests always fails for me on mac:
```
START| RunHookInspectFile
| fatal error: runtime: no plugin module data
| goroutine 43 [running]:
| runtime.throw({0x100943332?, 0x10000f41e?})
| /Users/marcin/devel/stork/tools/golang/go/src/runtime/panic.go:992 +0x71 fp=0xc0002a4fd0 sp=0xc0002a4fa0 pc=0x100038a91
| plugin.lastmoduleinit()
| /Users/marcin/devel/stork/tools/golang/go/src/runtime/plugin.go:20 +0x8d0 fp=0xc0002a50b8 sp=0xc0002a4fd0 pc=0x10006a0f0
| plugin.open({0x7ff7bfeff620, 0x58})
| /Users/marcin/devel/stork/tools/golang/go/src/plugin/plugin_dlopen.go:77 +0x3fb fp=0xc0002a53b0 sp=0xc0002a50b8 pc=0x1004783bb
| plugin.Open(...)
| /Users/marcin/devel/stork/tools/golang/go/src/plugin/plugin.go:32
| isc.org/stork/hooksutil.NewLibraryManager({0x7ff7bfeff620, 0x58})
| /Users/marcin/devel/stork/backend/hooksutil/librarymanager.go:29 +0x4b fp=0xc0002a5438 sp=0xc0002a53b0 pc=0x10047930b
| isc.org/stork/cmd/stork-tool.runHookInspect(0xc00013a888?)
| /Users/marcin/devel/stork/backend/cmd/stork-tool/main.go:231 +0x96 fp=0xc0002a54c8 sp=0xc0002a5438 pc=0x1007ebbd6
| github.com/urfave/cli/v2.(*Command).Run(0xc0001e0500, 0xc0002872c0, {0xc0001e20f0, 0x3, 0x3})
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/command.go:271 +0x1364 fp=0xc0002a5888 sp=0xc0002a54c8 pc=0x1003869c4
| github.com/urfave/cli/v2.(*Command).Run(0xc0001e0780, 0xc000287140, {0xc000286f00, 0x4, 0x4})
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/command.go:264 +0x1249 fp=0xc0002a5c48 sp=0xc0002a5888 pc=0x1003868a9
| github.com/urfave/cli/v2.(*App).RunContext(0xc000000780, {0x100a51cf8?, 0xc000128018}, {0xc000286f00, 0x4, 0x4})
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/app.go:333 +0x1056 fp=0xc0002a5d98 sp=0xc0002a5c48 pc=0x100380756
| github.com/urfave/cli/v2.(*App).Run(...)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/urfave/cli/v2@v2.23.7/app.go:310
| isc.org/stork/cmd/stork-tool.main()
| /Users/marcin/devel/stork/backend/cmd/stork-tool/main.go:537 +0x9c fp=0xc0002a5e20 sp=0xc0002a5d98 pc=0x1007f0b7c
| isc.org/stork/cmd/stork-tool.TestRunHookInspectFile(0x0)
| /Users/marcin/devel/stork/backend/cmd/stork-tool/main_test.go:239 +0x258 fp=0xc0002a5ea8 sp=0xc0002a5e20 pc=0x1007f3838
| testing.tRunner(0xc000083d40, 0x1009893d0)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1439 +0x214 fp=0xc0002a5fb0 sp=0xc0002a5ea8 pc=0x1001c0dd4
| testing.(*T).Run.func1()
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1486 +0x48 fp=0xc0002a5fe0 sp=0xc0002a5fb0 pc=0x1001c2588
| runtime.goexit()
| /Users/marcin/devel/stork/tools/golang/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc0002a5fe8 sp=0xc0002a5fe0 pc=0x10006f4c1
| created by testing.(*T).Run
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1486 +0x725
| goroutine 1 [chan receive]:
| testing.(*T).Run(0xc00028e000, {0x10093d656, 0x16}, 0x1009893d0)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1487 +0x750
| testing.runTests.func1(0x0?)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1839 +0x9a
| testing.tRunner(0xc00028e000, 0xc00018fba0)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1439 +0x214
| testing.runTests(0xc000260f00?, {0x100e07a20, 0xb, 0xb}, {0x40?, 0x129825798?, 0x100e17200?})
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1837 +0x7e5
| testing.(*M).Run(0xc000260f00)
| /Users/marcin/devel/stork/tools/golang/go/src/testing/testing.go:1719 +0xa72
| main.main()
| _testmain.go:67 +0x2e5
| goroutine 38 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc0003640a0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 58 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260aa0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 60 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260be0, 0x1009893a0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 66 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260820, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 61 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260dc0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 67 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260960, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 83 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260c80, 0x1009893a8?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 68 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000261040, 0xc000053fd0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 69 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000260fa0, 0xc000221de0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 71 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000261180, 0x1009893b0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 98 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000364140, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 72 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc0003641e0, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
| goroutine 73 [chan receive]:
| github.com/go-pg/pg/v10/internal/pool.(*ConnPool).reaper(0xc000364320, 0x0?)
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:441 +0xfe
| created by github.com/go-pg/pg/v10/internal/pool.NewConnPool
| /Users/marcin/devel/stork/tools/golang/gopath/pkg/mod/github.com/go-pg/pg/v10@v10.11.0/internal/pool/pool.go:103 +0x386
FAIL | isc.org/stork/cmd/stork-tool 1.750s
```1.11Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/980Stork Grafana Links do not honor path from Grafana URL setting2023-03-28T11:58:01ZCarsten StrotmannStork Grafana Links do not honor path from Grafana URL settingStork 1.9.0 from ISC packages
I have Grafana running on the same machine as Stork. Both are behind a NGINX reverse proxy. Stork is available on the root of the webserver:
http://machine.tld/
Grafana is available in a sub/path
http://...Stork 1.9.0 from ISC packages
I have Grafana running on the same machine as Stork. Both are behind a NGINX reverse proxy. Stork is available on the root of the webserver:
http://machine.tld/
Grafana is available in a sub/path
http://machine.tld/grafana/
I have configured the Grafana path in the Stork settings, but Stork generates links that do not point to the Grafana Path:
http://machine.tld/d/hRf18FvWz/?var-subnet=1000&var-instance=stork-demo%3A9547
Result is an empty page from Stork when using such link.1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/973Excessive errors when certs are inaccessible2023-08-02T09:32:55ZTomek MrugalskiExcessive errors when certs are inaccessibleThe stork agent prints excessive errors (140+ lines), including a total of 6 back traces, full of cryptic error that's useless for average users when TLS certs are inaccessible.
Example output: $1041
Steps to reproduce:
1. files in /v...The stork agent prints excessive errors (140+ lines), including a total of 6 back traces, full of cryptic error that's useless for average users when TLS certs are inaccessible.
Example output: $1041
Steps to reproduce:
1. files in /var/lib/stork-agent/certs/ are owned by `stork-agent` (permissions 600)
2. run `stork-agent` as a different user
Another case to check here is the behavior when the files (or whole dir) are missing.1.12Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/972Systemd executable path is not absolute2023-03-30T13:45:14ZJuliano GuidiniSystemd executable path is not absolute**Describe the bug**
Starting isc-stork-server.service generate an error on systemd in a Ubuntu 18.04.6.
```bash
# systemctl start isc-stork-server
Failed to start isc-stork-server.service: Unit isc-stork-server.service is not loaded p...**Describe the bug**
Starting isc-stork-server.service generate an error on systemd in a Ubuntu 18.04.6.
```bash
# systemctl start isc-stork-server
Failed to start isc-stork-server.service: Unit isc-stork-server.service is not loaded properly: Exec format error.
See system logs and 'systemctl status isc-stork-server.service' for details.
# systemctl status isc-stork-server.service
● isc-stork-server.service - ISC Stork Server
Loaded: error (Reason: Exec format error)
Active: inactive (dead)
Docs: man:stork-server(8)
fev 03 11:41:50 host systemd[1]: /lib/systemd/system/isc-stork-server.service:11: Executable path is not absolute: stork-server
```
**To Reproduce**
Steps to reproduce the behavior:
1. Install Stork 1.9.0.230131111251 ( by the book -> curl -1sLf 'https://dl.cloudsmith.io/public/isc/stork/cfg/setup/bash.deb.sh' | sudo bash )
2. apt install isc-stork-server
3. stork-tool db-create --db-name stork --db-user stork --db-host <Postgresql IP>
4. stork-tool db-init --db-host <Postgresql IP> --db-user stork --db-password <password>
5. stork-tool db-up --db-host <Postgresql IP> --db-user stork --db-password <password>
6. Configure /etc/stork/server.env
7. systemctl enable isc-stork-server
8. systemctl start isc-stork-server
**Expected behavior**
Stork server start normally. Like this:
```bash
# systemctl status isc-stork-server
● isc-stork-server.service - ISC Stork Server
Loaded: loaded (/lib/systemd/system/isc-stork-server.service; enabled; vendor preset: enabled)
Active: active (running) since Fri 2023-02-03 11:44:45 -03; 18min ago
Docs: man:stork-server(8)
Main PID: 29201 (stork-server)
Tasks: 9 (limit: 4915)
CGroup: /system.slice/isc-stork-server.service
└─29201 /usr/bin/stork-server
fev 03 12:01:45 host stork-server[29201]: time="2023-02-03 12:01:45" level="info" msg="Completed pulling hosts from Kea daemons" file=" host.go:111 " erred_count="0" skipped_count="0" success_count="0"
fev 03 12:01:45 host stork-server[29201]: time="2023-02-03 12:01:45" level="info" msg="Completed pulling DHCP status from Kea apps: 0/0 succeeded" file=" status.go:256 "
fev 03 12:01:45 host stork-server[29201]: time="2023-02-03 12:01:45" level="info" msg="Completed pulling information from machines: 0/0 succeeded" file=" statepuller.go:73 "
fev 03 12:02:15 host stork-server[29201]: time="2023-02-03 12:02:15" level="info" msg="Completed pulling information from machines: 0/0 succeeded" file=" statepuller.go:73 "
fev 03 12:02:15 host stork-server[29201]: time="2023-02-03 12:02:15" level="info" msg="Completed pulling DHCP status from Kea apps: 0/0 succeeded" file=" status.go:256 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling stats from BIND 9 apps: 0/0 succeeded" file=" statspuller.go:62 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling lease stats from Kea apps: 0/0 succeeded" file=" statspuller.go:71 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling hosts from Kea daemons" file=" host.go:111 " erred_count="0" skipped_count="0" success_count="0"
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling information from machines: 0/0 succeeded" file=" statepuller.go:73 "
fev 03 12:02:45 host stork-server[29201]: time="2023-02-03 12:02:45" level="info" msg="Completed pulling DHCP status from Kea apps: 0/0 succeeded" file=" status.go:256 "
```
**Environment:**
- Stork: 1.9.0.230131111251
- OS: Ubuntu 18.04.6 LTS - amd_64
- systemd: 237-3ubuntu10.56
**Additional Information**
I'd tested another server, running Debian 11, and this error is not observed.
- Stork version: 1.9.0.230131111251
- OS: Debian GNU/Linux 11 (bullseye) - amd_64
- systemd: 247.3-7+deb11u1
**Describe the solution you'd like**
Change the Unit ExecStart to :
```
ExecStart=/usr/bin/stork-server
```1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/970The IPv6 subnet bar is always double on the shared network page2023-03-03T12:09:58ZSlawek FigielThe IPv6 subnet bar is always double on the shared network pageThe issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348489).
The delegated prefix bar on the subnet bar is shown even if there are no delegated prefixes. The p...The issue was found during 1.9.0 sanity checks by @slawek - [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/962#note_348489).
The delegated prefix bar on the subnet bar is shown even if there are no delegated prefixes. The problem occurs only on the shared network page.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/8fd55425e9dfcd31aeec0e4805d7452a/image.png)1.10Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/960rake demo:up fails to build2023-02-08T16:52:55ZRazvan Becheriurake demo:up fails to buildafter rebasing #117 rake demo:up fails to build/runafter rebasing #117 rake demo:up fails to build/run1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/928Cannot delete machine with config reports2023-02-08T16:52:56ZSlawek FigielCannot delete machine with config reportsI cannot delete a machine with config reports.
```
time="2022-12-29 15:15:43" level="info" msg="HTTP request incoming" file=" middleware.go:79 " method="DELETE" path="/api/machines/5" remote="[::1]:46082"
time="2022-12-29 15:15:...I cannot delete a machine with config reports.
```
time="2022-12-29 15:15:43" level="info" msg="HTTP request incoming" file=" middleware.go:79 " method="DELETE" path="/api/machines/5" remote="[::1]:46082"
time="2022-12-29 15:15:56" level="error" msg="problem deleting machine 5: ERROR #23503 update or delete on table \"daemon\" violates foreign key constraint \"config_report_daemon_id\" on table \"config_report\"" file=" machines.go:687 "
```
The problem occurs on the `agent-kea` and `agent-kea6` demo machines.
After executing the `DELETE FROM config_report;` SQL query, the machine is properly deleted.1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/927Address and PD pools aren't updated2024-01-17T13:03:22ZSlawek FigielAddress and PD pools aren't updatedThe Stork server ignores changes in the address and PD pools.The Stork server ignores changes in the address and PD pools.1.9Slawek FigielSlawek Figiel