stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2023-01-18T10:41:10Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/882Communication events should be bound to the machine2023-01-18T10:41:10ZSlawek FigielCommunication events should be bound to the machineThe issue was found during 1.8.0 sanity checks by @slawek. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/875#note_320902).
I have a different set of events on the Dashboard and the machine page. The communication messages ...The issue was found during 1.8.0 sanity checks by @slawek. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/875#note_320902).
I have a different set of events on the Dashboard and the machine page. The communication messages with a warning level are missing on the machine page.
The event viewer presents all messages until I filter by a specific machine. In this case, the communication messages disappear.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/e121b7184e2ca7b39d7e5602496c12b0/image.png) ![image](https://gitlab.isc.org/isc-projects/stork/uploads/947fe6e517cbec24e31f1ed5bcc0ccb2/image.png)
![image](https://gitlab.isc.org/isc-projects/stork/uploads/171f5769f1bb2e0d3bd390cb6759d3fd/image.png) ![image](https://gitlab.isc.org/isc-projects/stork/uploads/12cd5dbf6e0afcc2d66a4dfe0c3ee5ba/image.png)1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/448HA state disappears on Kea app page2023-02-08T16:52:49ZMarcin SiodelskiHA state disappears on Kea app pageThis is a result of the Stork 0.13.0 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/441#note_174642
@godfryd pointed out that "HA state disappears on Kea app page". Repro:
* add in the demo two kea instances (ha1 and...This is a result of the Stork 0.13.0 sanity checks: https://gitlab.isc.org/isc-projects/stork/-/issues/441#note_174642
@godfryd pointed out that "HA state disappears on Kea app page". Repro:
* add in the demo two kea instances (ha1 and ha2)
* open kea apps page
* open both apps on separate tabs
* stop ha1/dhcp4 service in Stork Env Simulator
* on ha1 tab there should be presented info about connectivity issues
* on ha2 tab HA state may be presented by when tabs are switched between ha1 and ha2 then HA state disappears on ha2 tab (it may reappear after a while when new HA state is retrieved from the server)1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/196Stork server crashed ("inet_family" contains null values)2023-01-17T15:42:35ZTomek MrugalskiStork server crashed ("inet_family" contains null values)I was running the latest master (8486047fbd6cfac836f77dbd57d6e5c53e69b57d) and got the following error:
```
$ docker-compose logs server
WARNING: Some networks were defined but are not used by any service: subnet-04, subnet-03
Attachin...I was running the latest master (8486047fbd6cfac836f77dbd57d6e5c53e69b57d) and got the following error:
```
$ docker-compose logs server
WARNING: Some networks were defined but are not used by any service: subnet-04, subnet-03
Attaching to stork_server_1
server_1 | INFO[2020-03-09 21:50:57] main.go:18 Starting Stork Server, version 0.5.0, build date 2020-03-09 22:41
server_1 | INFO[2020-03-09 21:50:57] agentcomm.go:85 Stopping communication with agents
server_1 | INFO[2020-03-09 21:50:57] agentcomm.go:93 Stopped communication with agents
server_1 | FATA[2020-03-09 21:50:57] main.go:23 unexpected error: ERROR #23502 column "inet_family" contains null values
server_1 | problem with migrating database
server_1 | isc.org/stork/server/database.Migrate
server_1 | /home/thomson/devel/stork/backend/server/database/migrations.go:55
server_1 | isc.org/stork/server/database.MigrateToLatest
server_1 | /home/thomson/devel/stork/backend/server/database/migrations.go:64
server_1 | isc.org/stork/server/database.NewPgDB
server_1 | /home/thomson/devel/stork/backend/server/database/connection.go:57
server_1 | isc.org/stork/server.NewStorkServer
server_1 | /home/thomson/devel/stork/backend/server/server.go:75
server_1 | main.main
server_1 | /home/thomson/devel/stork/backend/cmd/stork-server/main.go:21
server_1 | runtime.main
server_1 | /home/thomson/devel/stork/tools/1.13.5/go/src/runtime/proc.go:203
server_1 | runtime.goexit
server_1 | /home/thomson/devel/stork/tools/1.13.5/go/src/runtime/asm_amd64.s:1357
```
This is something I built with `rake docker_up`.1.9Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/856Server metrics doesn't work2022-10-24T18:53:58ZSlawek FigielServer metrics doesn't workThe issue was found during 1.6.0 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/850#note_312543)
The Grafana reports invalid authorized/unauthorized machine numbers.
![image](https://gitlab.isc.org/isc-proje...The issue was found during 1.6.0 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/850#note_312543)
The Grafana reports invalid authorized/unauthorized machine numbers.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/5549b98bc2c267349f897f62ed2a3868/image.png)
The metrics endpoint returns HTML instead of the data in Prometheus format.
![image](https://gitlab.isc.org/isc-projects/stork/uploads/fe3c4ff3be24de6e762ce45e49fc2f0d/image.png)
The server metrics endpoint returns an inappropriate response.1.8https://gitlab.isc.org/isc-projects/stork/-/issues/541there is no breadcrumb on events page2022-11-10T11:00:48ZMichal Nowikowskithere is no breadcrumb on events page![image](/uploads/d1c6c2d58a2143d342c71c286b21dde8/image.png)![image](/uploads/d1c6c2d58a2143d342c71c286b21dde8/image.png)1.8Andrei Pavelandrei@isc.orgAndrei Pavelandrei@isc.orghttps://gitlab.isc.org/isc-projects/stork/-/issues/860Server postinstall fails on Debian Bullseye2022-10-13T08:33:47ZSlawek FigielServer postinstall fails on Debian BullseyeThe issue was found by @kpfleming and described on the mailing list on 2022-09-10.
> During a regular update cycle my machine tried to install
> isc-stork-server 1.6.0.220906131440. This failed because the
> post-installation script enc...The issue was found by @kpfleming and described on the mailing list on 2022-09-10.
> During a regular update cycle my machine tried to install
> isc-stork-server 1.6.0.220906131440. This failed because the
> post-installation script encountered an error.
>
>
```
Setting up isc-stork-server (1.6.0.220906131440) ...
Option s is ambiguous (shell, system)
dpkg: error processing package isc-stork-server (--configure):
installed isc-stork-server package post-installation script
subprocess returned error exit status 1
```
>
> After looking at /var/lib/dpkg/info/isc-stork-server.postinst, I saw
> that if 'busybox' is available on the system then the
> post-installation script attempts to use it to create the stork-server
> group and user. Unfortunately the syntax appears to be bad as busybox
> complained, but more importantly my system is Debian Bullseye and
> busybox isn't used for managing users and groups... I just happened to
> have it installed for unrelated reasons.
>
> I think this script's logic for determining which tool to use for
> managing groups and users might need to be re-thought. I was able to
> complete the installation by de-installing busybox.1.7Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/818HA state unavailable, though working2024-02-26T14:50:32ZNicolas EHA state unavailable, though working---
Stork 1.4.0 is showing both Kea 2.1.7 dhcp4 servers in HA+MT with state unavailable.
Actually, there are both working fine, as Stork server is.
**To Reproduce**
Steps to reproduce the behaviour:
1. Run Kea 2.1.7 in High-availability...---
Stork 1.4.0 is showing both Kea 2.1.7 dhcp4 servers in HA+MT with state unavailable.
Actually, there are both working fine, as Stork server is.
**To Reproduce**
Steps to reproduce the behaviour:
1. Run Kea 2.1.7 in High-availability hot-standby + Multi Threading on two machines, Stork server running on machine 1
2. Restart both machine (to be sure to be sure)
3. Witness that after every daemon has started, and the logs are showing a correct HA state (machine 1 = primary and OK, machine 2 in hot-standby)
4. Make some tests (stop one dhcp4 service, validate that clients still get served, restart, witness a correct chat between both nodes)
5. During all this, the stork web GUI dashboard (very first page after login) is showing : "HA state unavailable"
When clicking on the "unavailable" clickable link, it leads me to a page where everything is green, OK, correct, valid as it can be.
**Expected behaviour**
The dashboard show report a situation as happy as the reality is when looking at the details pages, or in the logs, or in the currently running services.
**Environment:**
- Kea version: 2.1.7
- Stork agent + server : 1.4.0
- OS: Debian 11 bullseye
**Contacting you**
admin@sitpi.fr1.7Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/817Server creates a false disconnect event on Kea hook conflict2022-10-19T08:44:57ZSlawek FigielServer creates a false disconnect event on Kea hook conflictThe Kea daemon can be configured to use the `host_cmds` hook and RADIUS backend simultaneously. The RADIUS backend doesn't support listing host reservations. It causes the `reservation-get-page` command fails due to an unsupported except...The Kea daemon can be configured to use the `host_cmds` hook and RADIUS backend simultaneously. The RADIUS backend doesn't support listing host reservations. It causes the `reservation-get-page` command fails due to an unsupported exception. Stork's host puller uses this command to update the host reservations data.
```
2022-06-29 07:50:52.273 INFO [kea-dhcp4.commands/443501.139831042103424] COMMAND_RECEIVED Received command 'reservation-get-page'
2022-06-29 07:50:52.275 ERROR [kea-dhcp4.callouts/443501.139831042103424] HOOKS_CALLOUT_ERROR error returned by callout on hook 3 registered by library with index $reservation_get_page (callout address 0x7f2cebb0b540) (callout duration 1.420 ms)
```
Stork has multiple pullers working parallel. When any fails, the server produces a disconnect event and displays a warning message.
```json
{
"createdAt": "2022-06-29T14:30:51.561Z",
"id": 51358,
"level": 2,
"text": "Communication with <daemon id=\"2\" name=\"dhcp4\" appId=\"1\" appType=\"kea\"> of <app id=\"1\" name=\"Primary\" type=\"kea\" version=\"1.8.2\"> failed"
},
```
Any subsequent success pulling from any puller (it may be different than a puller that notified connection problems) produces a resumed connection event.
```json
{
"createdAt": "2022-06-29T14:31:11.658Z",
"id": 51360,
"level": 1,
"text": "Communication with <daemon id=\"2\" name=\"dhcp4\" appId=\"1\" appType=\"kea\"> of <app id=\"1\" name=\"Primary\" type=\"kea\" version=\"1.8.2\"> resumed"
},
```
It causes to generate tons of events and false alerts. We should gracefully handle the hook conflict and stop or mute a puller in this situation. Additionally, a config checker should report an unsupported hook combination.1.7Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/851isc-stork-agent fails to uninstall due to empty code paths in the pre-remove ...2022-09-12T09:59:12ZMarcin Siodelskiisc-stork-agent fails to uninstall due to empty code paths in the pre-remove scriptDuring our 1.6 sanity checks we found that an attempt to uninstall `isc-stork-agent` fails like described here:
https://gitlab.isc.org/isc-projects/stork/-/issues/850#note_312573
We need to add a colon (`:`) in no-op code paths to prev...During our 1.6 sanity checks we found that an attempt to uninstall `isc-stork-agent` fails like described here:
https://gitlab.isc.org/isc-projects/stork/-/issues/850#note_312573
We need to add a colon (`:`) in no-op code paths to prevent this issue.1.6Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/848Stork fails to build on MacOS2022-09-05T12:56:40ZSlawek FigielStork fails to build on MacOS@marcin wrote:
Stork no longer builds for me on macOS:
```
/Users/marcin/devel/stork/tools/golang/go/bin/go build -ldflags=-X 'github.com/go-swagger/go-swagger/cmd/swagger/commands.Version=v0.23.0'
# golang.org/x/sys/unix
../../../gopa...@marcin wrote:
Stork no longer builds for me on macOS:
```
/Users/marcin/devel/stork/tools/golang/go/bin/go build -ldflags=-X 'github.com/go-swagger/go-swagger/cmd/swagger/commands.Version=v0.23.0'
# golang.org/x/sys/unix
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/syscall_darwin.1_13.go:25:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../../gopath/pkg/mod/golang.org/x/sys@v0.0.0-20200302150141-5c8b2ff67527/unix/zsyscall_darwin_amd64.go:121:3: too many errors
rake aborted!
```
I wonder if it has anything to do with this:
```
commit 157dbd2a00b83197e3f366e73d82e69ad590d9ed
Author: Slawek Figiel <slawek@isc.org>
Date: Wed Aug 17 13:06:03 2022 +0200
[#193] Build GoSwagger from sources
```
I can confirm that this commit breaks the build on macOS
Upgrading x/sys package doesn't help1.6Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/824stork-demo.sh doesn't work on macOS2022-08-17T15:06:56ZMarcin Siodelskistork-demo.sh doesn't work on macOSI get the following error on macOS when I try to run `stork-demo.sh`:
```
./stork-demo.sh -h
getopt: illegal option -- n
```I get the following error on macOS when I try to run `stork-demo.sh`:
```
./stork-demo.sh -h
getopt: illegal option -- n
```1.6Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/822System tests fails - missing Kea dependency2022-08-09T07:45:25ZSlawek FigielSystem tests fails - missing Kea dependencyStork system tests start failing due to missing Kea dependency:
```
#7 3.451 The following packages have unmet dependencies:
#7 3.490 isc-kea-ctrl-agent : Depends: python3-isc-kea-connector (= 2.0.2-isc20220227221539) but 2.0.3-isc2022...Stork system tests start failing due to missing Kea dependency:
```
#7 3.451 The following packages have unmet dependencies:
#7 3.490 isc-kea-ctrl-agent : Depends: python3-isc-kea-connector (= 2.0.2-isc20220227221539) but 2.0.3-isc20220725151155 is to be installed
#7 3.498 E: Unable to correct problems, you have held broken packages.
```
Command:
```
wget -q -O- https://dl.cloudsmith.io/${KEA_REPO}/cfg/setup/bash.deb.sh | bash \
&& apt-get update \
&& apt-get install \
--no-install-recommends \
-y \
isc-kea-ctrl-agent=${KEA_VER} \
isc-kea-dhcp4-server=${KEA_VER} \
isc-kea-dhcp6-server=${KEA_VER} \
isc-kea-admin=${KEA_VER} \
isc-kea-common=${KEA_VER}
```
for environment variables:
```
KEA_REPO=public/isc/kea-2-0
KEA_VER=2.0.2-isc20220227221539
```1.6Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/814Invalid host updating2022-08-17T15:06:56ZSlawek FigielInvalid host updating@kpfleming wrote in Stork mailing list:
> I've had a pair of Kea DHCP servers (for both IPv4 and IPv6) running
for a few months now, with Stork setup to monitor them. The Kea
servers are in HA mode, so they have nearly identical configu...@kpfleming wrote in Stork mailing list:
> I've had a pair of Kea DHCP servers (for both IPv4 and IPv6) running
for a few months now, with Stork setup to monitor them. The Kea
servers are in HA mode, so they have nearly identical configurations.
>
> Those configurations include 20+ host reservations, and those
reservations have always shown up in the Stork 'Host Reservations'
display as they should. However the 'Hostname' column was always
empty, because I didn't have hostnames specified in the Kea
configuration files.
>
> Today I changed that, and applied hostnames to all of the
reservations, then did a 'reload' of the Kea DHCP servers. The Stork
dashboard noted that the configuration had been changed, but still
does not show the hostnames. I've waited a few hours to see if it was
just going to update later, but it has not updated.
>
> Is there something I need to do to trigger Stork to re-read this data
from the configuration files? I've included an excerpt of the config
file below just in case I've done something incorrectly there.
I confirm the bug. The host reservation data doesn't update if the host identifier or reserved IP doesn't change.1.6Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/812Manually provided DHCP option in host reservation form produces backend error2022-08-30T12:02:17ZSlawek FigielManually provided DHCP option in host reservation form produces backend errorThe issue found during the 1.5 sanity checks [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/808#note_300620)
Providing option code by hand in the host reservation form causes GO unmarshal error. Selecting the option code fr...The issue found during the 1.5 sanity checks [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/808#note_300620)
Providing option code by hand in the host reservation form causes GO unmarshal error. Selecting the option code from the dropdown works well, the option is forwarded to the Kea.
Error:
```
Cannot commit new host
The transaction adding new host failed: parsing host body from "" failed, because json: cannot unmarshal string into Go struct field DHCPOption.localHosts.options.code of type int64
```
Parameters to reproduce:
* Global reservation: true
* DHCP Servers: kea@agent-kea-premium/dhcp6
* DHCP Identifier: flex-id / text / xa<zsc
* IP Reservations: IPv6 address / 2001:db8:1::2
* DHCP options:
* Option code: 92 (manually provided)
* Payload: hex-bytes 1234451.6Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/810Deploy demo doesn't work2022-08-17T15:06:56ZSlawek FigielDeploy demo doesn't workWe changed the name of the running demo script in #761, but we forgot to update the Gitlab CI YAML. The deploy demo CI tasks fail now due to a missing file.We changed the name of the running demo script in #761, but we forgot to update the Gitlab CI YAML. The deploy demo CI tasks fail now due to a missing file.1.6Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/802System tests fail on none config reports2022-08-23T10:34:07ZSlawek FigielSystem tests fail on none config reportsRefers to: `test_get_dhcp4_config_review_reports` test case.
The Stork Server returns HTTP 204 No Content status if the config review is not performed yet for a given daemon. It is correctly described in the Swagger YAML file. The serve...Refers to: `test_get_dhcp4_config_review_reports` test case.
The Stork Server returns HTTP 204 No Content status if the config review is not performed yet for a given daemon. It is correctly described in the Swagger YAML file. The server sends only HTTP status and no data in response.
Unfortunately, it seems that the Python OpenAPI client doesn't support No Content status and always expects that the config reviews will be included in the server response.
It causes the system tests may sporadically fail on listing the reviews. Additionally, we need a function to wait for complete review for a given daemon.1.6https://gitlab.isc.org/isc-projects/stork/-/issues/745Incorrect package type recognition2022-09-02T15:00:33ZSlawek FigielIncorrect package type recognitionThe issue was found during 1.3 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/732#note_285432)
I've been playing with the new build system. Overall, looks awesome and is much cleaner. Found a ~~small~~ issue:...The issue was found during 1.3 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/732#note_285432)
I've been playing with the new build system. Overall, looks awesome and is much cleaner. Found a ~~small~~ issue:
```
$ rake utils:print_pkg_type
rpm
thomson@tycho:~/devel/stork-1.3.0$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 21.10
Release: 21.10
Codename: impish
```
I would expect DEB, not RPM.1.6https://gitlab.isc.org/isc-projects/stork/-/issues/781Freeze the Ruby dependencies2022-06-20T10:58:17ZSlawek FigielFreeze the Ruby dependenciesThe maintainers of [one of our Ruby dependencies dropped today support for the Ruby version used on our CI.](https://github.com/socketry/multipart-post/releases/tag/v2.2.2).
It caused our pipeline fails. We need to freeze our Ruby depend...The maintainers of [one of our Ruby dependencies dropped today support for the Ruby version used on our CI.](https://github.com/socketry/multipart-post/releases/tag/v2.2.2).
It caused our pipeline fails. We need to freeze our Ruby dependencies to avoid similar situations in the future.1.5Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/762Update the demo wiki page2022-07-19T16:46:37ZSlawek FigielUpdate the demo wiki pageIt is feedback after the demo presentation from Razvan:
The demo wiki page is out-of-dateIt is feedback after the demo presentation from Razvan:
The demo wiki page is out-of-date1.5Tomek MrugalskiTomek Mrugalskihttps://gitlab.isc.org/isc-projects/stork/-/issues/744Build date is unset2022-06-07T11:59:10ZSlawek FigielBuild date is unsetThe issue was found during 1.3 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/732#note_285376)
![image](https://gitlab.isc.org/isc-projects/stork/uploads/74b9f6e3c07bfd693ff407f2f8555858/image.png)
Hovering ...The issue was found during 1.3 sanity checks. [Source](https://gitlab.isc.org/isc-projects/stork/-/issues/732#note_285376)
![image](https://gitlab.isc.org/isc-projects/stork/uploads/74b9f6e3c07bfd693ff407f2f8555858/image.png)
Hovering the logo displays the "unset" build date.1.5Marcin SiodelskiMarcin Siodelski