stork issueshttps://gitlab.isc.org/isc-projects/stork/-/issues2024-03-08T18:26:47Zhttps://gitlab.isc.org/isc-projects/stork/-/issues/1282Hosts reservation filter by isGlobal and appId2024-03-08T18:26:47ZPiotrek ZadrogaHosts reservation filter by isGlobal and appIdFiltering reservations by appId only works ok (stork demo example):
![image](/uploads/b482868c6da6cc081991d266cc9db2a3/image.png)
But when one adds also `is:global` or `not:global`, suddenly results are inconsistent:
![image](/uploads/d...Filtering reservations by appId only works ok (stork demo example):
![image](/uploads/b482868c6da6cc081991d266cc9db2a3/image.png)
But when one adds also `is:global` or `not:global`, suddenly results are inconsistent:
![image](/uploads/d430d92fb197c9736acf966108d828ea/image.png)
![image](/uploads/66f7cf7e9d2b9115b7c928de490572ad/image.png)1.16Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1272Build hooks fails due to missing space2024-01-24T11:53:56ZSlawek FigielBuild hooks fails due to missing spaceIt started occurring after merge #1254.
```
Reverting remap operation...
/builds/isc-projects/stork/tools/ruby/bin_bundle/fpm -s dir -C /builds/isc-projects/stork/hooks -n isc-stork-server-hook-ldap -t apk -a amd64 -v 1.14.0.24010815450...It started occurring after merge #1254.
```
Reverting remap operation...
/builds/isc-projects/stork/tools/ruby/bin_bundle/fpm -s dir -C /builds/isc-projects/stork/hooks -n isc-stork-server-hook-ldap -t apk -a amd64 -v 1.14.0.240108154502 --license MPL 2.0 --url https://gitlab.isc.org/isc-projects/stork/ --vendor Internet Systems Consortium, Inc. stork-server-ldap.so=/var/lib/stork-server/hooks/stork-server-ldap.so --rpm-digest sha256
{:timestamp=>"2024-01-08T15:45:20.075263+0000", :message=>"All flags should be before the first argument (stray flags found: [\"--rpm-digest\"]", :level=>:warn}
{:timestamp=>"2024-01-08T15:45:20.089074+0000", :message=>"Invalid package configuration: Cannot package the path '/builds/isc-projects/stork/hooks/--rpm-digest', does it exist?", :level=>:error}
```1.15Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1267Applications list filters by text when it's not supposed to2024-02-05T12:41:51ZPiotrek ZadrogaApplications list filters by text when it's not supposed toSteps to reproduce:
- Pagination must occur in Apps list (Kea or Bind, no difference here)
- filter by something that doesn't exist => zero results returned by filter
- navigate to different view
- go back to Apps list
- issue happens: ...Steps to reproduce:
- Pagination must occur in Apps list (Kea or Bind, no difference here)
- filter by something that doesn't exist => zero results returned by filter
- navigate to different view
- go back to Apps list
- issue happens: filtering is still applied (this may happen after going to other page in pagination)
Filter text input is empty
![image](/uploads/f31a9377bd6b13070ffed208f409d005/image.png)
But in the request to API the filter is still on, hence empty apps list
![image](/uploads/1a15084a115c187268dc639575b8c40e/image.png)
Bind apps (no results AND BTW also wrong breadcrumb :disappointed: ):
![image](/uploads/c69b858a310bedea7c7dcf2c26ce7544/image.png)
![image](/uploads/6b49eff412c3e718be21a2869a555869/image.png)1.15Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1263isc-stork-server consumes all memory on Debian 122024-01-24T16:02:01ZRoman Haefeliisc-stork-server consumes all memory on Debian 12---
name: isc-stork-server suspected to leak memory
about: it consumes all available memory on Debian 12
---
When running isc-stork-server > 1.11 on Debian 12, CPU usage of the process `/usr/bin/stork-server` jumps to 100% and the memor...---
name: isc-stork-server suspected to leak memory
about: it consumes all available memory on Debian 12
---
When running isc-stork-server > 1.11 on Debian 12, CPU usage of the process `/usr/bin/stork-server` jumps to 100% and the memory consumption steadily increases after displaying the "DHCP" -> "Subnets" Page in the frontend. After 1-2 minutes, all available memory is consumed by the `/usr/bin/stork-server` process and the frontend becomes laggy and starts printing errors. This problem appears with the versions:
- 1.12
- 1.13
- 1.14
but not with:
- 1.11
**To Reproduce**
Steps to reproduce the behavior:
1. Install isc-stork-server 1.14
2. Visit the page "DHCP" -> "Subnets"
3. Observe memory usage of `/usr/bin/stork-server`
4. When it reaches maximum usage, frontend becomes unresponsive
**Expected behavior**
The `/usr/bin/stork-server` should consume a sane amount of memory and the frontend should stay responsive.
**Environment:**
- Kea version: 2.2.1
- Stork: 1.14
- OS:
- Debian 12 amd64 for Kea and stork-agent (VM)
- Debian 12 amd64 for stork-server (separate system) with 8 GB RAM and 2 CPU cores (VM)
- Database for stork-server:
- PostgreSQL 15 (Debian 12 amd64)
- Kea configuration:
- Subnets in configuration (1384 subnets)
- Host reservations in configuration
- Leases stored in memfile
- Kea hooks loaded:
- libdhcp_lease_cmds.so
- libdhcp_host_cmds.so
- libdhcp_stat_cmds.so
- libdhcp_ha.so
- Kea setup: 3 Kea instances in HA configuration with roles:
- primary
- secondary
- backup
**Additional Information**
Stork server configuration `server.env`:
```
### database settings
### the address of a PostgreSQL database
STORK_DATABASE_HOST=ddi-db-prod.example.org
### the port of a PostgreSQL database
# STORK_DATABASE_PORT=
### the name of a database
STORK_DATABASE_NAME=stork
### the username for connecting to the database
STORK_DATABASE_USER_NAME=stork
### the SSL mode for connecting to the database
### possible values: disable, require, verify-ca, or verify-full
STORK_DATABASE_SSLMODE=require
### the location of the SSL certificate used by the server to connect to the database
# STORK_DATABASE_SSLCERT=
### the location of the SSL key used by the server to connect to the database
# STORK_DATABASE_SSLKEY=
### the location of the root certificate file used to verify the database server's certificate
# STORK_DATABASE_SSLROOTCERT=
### the password for the username connecting to the database
### empty password is set to avoid prompting a user for database password
STORK_DATABASE_PASSWORD=secretpassword
### REST API settings
### the IP address on which the server listens
STORK_REST_HOST=0.0.0.0
### the port number on which the server listens
STORK_REST_PORT=8443
### the file with a certificate to use for secure connections
STORK_REST_TLS_CERTIFICATE=/etc/ssl/localcerts/dhcp-mon-prod.example.org.crt
### the file with a private key to use for secure connections
STORK_REST_TLS_PRIVATE_KEY=/etc/ssl/localcerts/dhcp-mon-prod.example.org.key
### the certificate authority file used for mutual TLS authentication
# STORK_REST_TLS_CA_CERTIFICATE=
### the directory with static files served in the UI
STORK_REST_STATIC_FILES_DIR=/usr/share/stork/www
### enable Prometheus /metrics HTTP endpoint for exporting metrics from
### the server to Prometheus. It is recommended to secure this endpoint
### (e.g. using HTTP proxy).
STORK_SERVER_ENABLE_METRICS=false
### Logging parameters
### Set logging level. Supported values are: DEBUG, INFO, WARN, ERROR
STORK_LOG_LEVEL=WARN
### disable output colorization
CLICOLOR=false
```
Kea-DHCP4 configuration `kea-dhcp4.conf` (leaving out subnets and reservations):
```
{
"Dhcp4": {
"cache-max-age": 120,
"cache-threshold": 0.5,
"control-socket": {
"socket-name": "/tmp/kea4-ctrl-socket",
"socket-type": "unix"
},
"ddns-generated-prefix": "",
"ddns-override-client-update": false,
"ddns-override-no-update": false,
"ddns-qualifying-suffix": "example.org.",
"ddns-replace-client-name": "never",
"ddns-send-updates": true,
"ddns-update-on-renew": true,
"ddns-use-conflict-resolution": true,
"decline-probation-period": 3600,
"dhcp-ddns": {
"enable-updates": true,
"max-queue-size": 1024,
"ncr-format": "JSON",
"ncr-protocol": "UDP",
"server-ip": "127.0.0.1",
"server-port": 53001
},
"hooks-libraries": [
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_lease_cmds.so"
},
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_host_cmds.so"
},
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_stat_cmds.so"
},
{
"library": "/usr/lib/x86_64-linux-gnu/kea/hooks/libdhcp_ha.so",
"parameters": {
"high-availability": [
{
"cert-file": "/etc/ssl/localcerts/dhcp-pri1-prod.example.org.crt",
"delayed-updates-limit": 100,
"heartbeat-delay": 1000,
"key-file": "/etc/ssl/localcerts/dhcp-pri1-prod.example.org.key",
"max-ack-delay": 5000,
"max-response-delay": 4000,
"max-unacked-clients": 0,
"mode": "load-balancing",
"multi-threading": {
"enable-multi-threading": true,
"http-client-threads": 0,
"http-dedicated-listener": true,
"http-listener-threads": 0
},
"peers": [
{
"auto-failover": true,
"name": "dhcp-pri1-prod.example.org",
"role": "primary",
"url": "https://10.158.0.68:8001/"
},
{
"auto-failover": true,
"name": "dhcp-sec1-prod.example.org",
"role": "secondary",
"url": "https://10.158.0.168:8001/"
},
{
"auto-failover": true,
"name": "dhcp-bac1-prod.example.org",
"role": "backup",
"url": "https://10.158.0.169:8001/"
}
],
"require-client-certs": true,
"send-lease-updates": true,
"sync-leases": true,
"this-server-name": "dhcp-pri1-prod.example.org",
"trust-anchor": "/usr/share/ca-certificates/root_ad-example.org.2018.crt"
}
]
}
}
],
"hostname-char-replacement": "",
"hostname-char-set": "",
"interfaces-config": {
"interfaces": [
"eth0"
]
},
"lease-database": {
"name": "/var/lib/kea/kea-leases4.csv",
"type": "memfile"
},
"loggers": [
{
"debuglevel": 99,
"name": "*",
"severity": "DEBUG"
},
{
"debuglevel": 99,
"name": "kea-dhcp4.commands",
"severity": "DEBUG"
}
],
"multi-threading": {
"enable-multi-threading": true,
"packet-queue-size": 64,
"thread-pool-size": 0
},
"option-data": [
{
"always-send": false,
"data": "10.158.0.153, 10.158.1.53",
"name": "domain-name-servers"
},
{
"always-send": false,
"data": "example.org",
"name": "domain-name"
},
{
"always-send": false,
"data": "example.org",
"name": "domain-search"
},
{
"always-send": false,
"data": "10.144.128.12",
"name": "cisco-autoinstall"
}
],
"option-def": [
{
"array": false,
"code": 150,
"name": "cisco-autoinstall",
"type": "ipv4-address"
}
],
"rebind-timer": 2000,
"renew-timer": 1000,
"reservations-global": true,
"reservations-in-subnet": true,
"reservations-out-of-pool": false,
"valid-lifetime": 4000
}
}
```1.15Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1260Long IPv6 address overlaps the reservation status2024-01-03T14:03:25ZSlawek FigielLong IPv6 address overlaps the reservation statusThe long IPv6 address overlaps the reservation status on the host reservation page.
![image](/uploads/53dfcad412a5fa954c4d5a851069c506/image.png)The long IPv6 address overlaps the reservation status on the host reservation page.
![image](/uploads/53dfcad412a5fa954c4d5a851069c506/image.png)1.15Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1258Apps State Puller Interval is not preserved2024-03-05T12:38:29ZSlawek FigielApps State Puller Interval is not preservedIt is impossible to set the `Apps State Puller Interval` setting on UI. It always reverts to 30 seconds.
The API return HTTP 200 OK status:
```
stork-server-1 | time="2023-12-08 17:36:14" level="info" msg="HTTP request...It is impossible to set the `Apps State Puller Interval` setting on UI. It always reverts to 30 seconds.
The API return HTTP 200 OK status:
```
stork-server-1 | time="2023-12-08 17:36:14" level="info" msg="HTTP request incoming" file=" middleware.go:79 " method="PUT" path="/api/settings" remote="172.24.0.5:34192"
stork-server-1 | time="2023-12-08 17:36:14" level="info" msg="HTTP request served" file=" middleware.go:93 " method="PUT" path="/api/settings" remote="172.24.0.5:34192" size="0" status="200" text_status="OK" took="4.958374ms"
stork-webui-1 | 172.24.0.1 - - [08/Dec/2023:17:36:14 +0000] "PUT /api/settings HTTP/1.1" 200 0 "http://127.0.0.1:8080/settings" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36 OPR/105.0.0.0" "-"
```1.16Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1257Simulator is not working due to incompatible dependency2023-12-08T16:31:05ZSlawek FigielSimulator is not working due to incompatible dependencyThe `isc-kea-common` package is not explicitly set in the `simulator.Dockerfile`.
It causes the incompatible version of this package to be installed after the recent Kea update.
```
root@simulator:/app# perfdhcp
perfdhcp: error while l...The `isc-kea-common` package is not explicitly set in the `simulator.Dockerfile`.
It causes the incompatible version of this package to be installed after the recent Kea update.
```
root@simulator:/app# perfdhcp
perfdhcp: error while loading shared libraries: libkea-dhcp++.so.73: cannot open shared object file: No such file or directory
```Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1254Ubuntu 20.04 LTS compatibility for LDAP hook2024-01-08T16:48:23ZSlawek FigielUbuntu 20.04 LTS compatibility for LDAP hookThe issue was reported on our mailing list: [Link](https://lists.isc.org/pipermail/stork-users/2023-December/000238.html).
We restored the Ubuntu 20.04 LTS support for main Stork binaries in the 1.14 release, but we forgot about the LDA...The issue was reported on our mailing list: [Link](https://lists.isc.org/pipermail/stork-users/2023-December/000238.html).
We restored the Ubuntu 20.04 LTS support for main Stork binaries in the 1.14 release, but we forgot about the LDAP hook.1.15Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1248Home breadcrumb has an undefined anchor2023-12-21T14:59:47ZSlawek FigielHome breadcrumb has an undefined anchorThe issue was found by @piotrek during [1.14 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421536).
I'm not sure if it is intended, but when breadcrumbs are displayed and you click on a Home breadcrumb, the...The issue was found by @piotrek during [1.14 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1240#note_421536).
I'm not sure if it is intended, but when breadcrumbs are displayed and you click on a Home breadcrumb, then main dashboard opens in a new tab. Anchor `target` is `undefined`:
```html
<a class="p-menuitem-link ng-star-inserted" href="/" target="undefined" tabindex="0">
```
Usually breadcrumbs anchors work with `target="_self"`.1.15Piotrek ZadrogaPiotrek Zadrogahttps://gitlab.isc.org/isc-projects/stork/-/issues/1238Redundant asterisks in Changelog after merge2023-12-04T11:10:02ZSlawek FigielRedundant asterisks in Changelog after mergeThe entry header is incorrect. It contains an unnecessary asterisk.
![image](/uploads/d5ba0ef87fcad47256ed3318026cc7ff/image.png)The entry header is incorrect. It contains an unnecessary asterisk.
![image](/uploads/d5ba0ef87fcad47256ed3318026cc7ff/image.png)https://gitlab.isc.org/isc-projects/stork/-/issues/1231Can't install stork on Openbsd2023-12-12T02:16:15ZmikygeeCan't install stork on OpenbsdHello,
Last year I participated on this topic
https://gitlab.isc.org/isc-projects/stork/-/issues/193
I'm reinstalling my DNS server on Openbsd and can't build the stork agent
```
# rake32 build:agent --trace
ERROR: Unknown/unsupported ...Hello,
Last year I participated on this topic
https://gitlab.isc.org/isc-projects/stork/-/issues/193
I'm reinstalling my DNS server on Openbsd and can't build the stork agent
```
# rake32 build:agent --trace
ERROR: Unknown/unsupported architecture: amd64
rake aborted!
/home/mikael/stork/rakelib/00_init.rake:509:in `<top (required)>'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/rake_module.rb:29:in `load'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/rake_module.rb:29:in `load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/default_loader.rb:11:in `load'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:788:in `load_imports'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:718:in `raw_load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:104:in `block in load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:103:in `load_rakefile'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:82:in `block in run'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:186:in `standard_exception_handling'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/lib/rake/application.rb:80:in `run'
/usr/local/lib/ruby/gems/3.2/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/usr/local/bin/rake32:25:in `load'
/usr/local/bin/rake32:25:in `<main>'
```
My system is like this
```
# uname -a
OpenBSD machinename.domain.org 7.4 GENERIC.MP#0 amd64
```
So I when to rakelib/00_init.rake line 501 and added a switch for "when "amd64"
```
uname_arch=`uname -m`
case uname_arch.rstrip
when "x86_64"
ARCH="amd64"
when "amd64"
ARCH="amd64"
when "aarch64_be", "aarch64", "armv8b", "armv8l"
ARCH="arm64"
else
puts "ERROR: Unknown/unsupported architecture: #{uname_arch}"
fail
end
```
Then it works
Also, why is it trying to download protoc or protobug although it's already installed on my system
```
# pkg_info | grep protobuf
protobuf-3.21.12p0 c++ protocol buffers
```
```
# rake32 build:agent
/usr/local/bin/go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.31.0
/usr/local/bin/protoc-gen-go --version
protoc-gen-go v1.31.0
/usr/local/bin/go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.3.0
go: downloading google.golang.org/grpc v1.3.0
go: downloading google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
go: downloading google.golang.org/protobuf v1.28.1
/usr/local/bin/protoc-gen-go-grpc --version
protoc-gen-go-grpc 1.3.0
/usr/local/bin/protoc --proto_path=. --go_out=. --go-grpc_out=. agent.proto
/usr/local/bin/go build -ldflags=-X 'isc.org/stork.BuildDate=2023-11-26 14:25'
go: downloading github.com/urfave/cli/v2 v2.25.7
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.2
go: downloading github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/russross/blackfriday/v2 v2.1.0
Stork Code Gen build date: 2023-11-26 14:25 (timestamp: 231126142545)
backend/cmd/stork-code-gen/stork-code-gen std-option-defs --input codegen/std_dhcpv4_option_def.json --output backend/appcfg/kea/stdoptiondef4.go --template backend/appcfg/kea/stdoptiondef4.go.template
/usr/local/bin/go fmt ./appcfg/kea/...
go: downloading muzzammil.xyz/jsonc v1.0.0
go: downloading github.com/apparentlymart/go-cidr v1.1.0
go: downloading github.com/sirupsen/logrus v1.9.3
go: downloading golang.org/x/term v0.12.0
go: downloading golang.org/x/sys v0.12.0
appcfg/kea/stdoptiondef4.go
backend/cmd/stork-code-gen/stork-code-gen std-option-defs --input codegen/std_dhcpv6_option_def.json --output backend/appcfg/kea/stdoptiondef6.go --template backend/appcfg/kea/stdoptiondef6.go.template
/usr/local/bin/go fmt ./appcfg/kea/...
appcfg/kea/stdoptiondef6.go
/usr/local/bin/go build -ldflags=-X 'isc.org/stork.BuildDate=2023-11-26 14:25'
go: downloading github.com/Showmax/go-fqdn v1.0.0
go: downloading github.com/prometheus/client_golang v1.16.0
go: downloading github.com/prometheus/common v0.44.0
go: downloading github.com/shirou/gopsutil v3.21.11+incompatible
go: downloading google.golang.org/grpc v1.58.2
go: downloading google.golang.org/grpc/security/advancedtls v0.0.0-20230925230705-147bd8591213
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/prometheus/client_model v0.4.0
go: downloading github.com/prometheus/procfs v0.12.0
go: downloading golang.org/x/net v0.15.0
go: downloading golang.org/x/crypto v0.13.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading github.com/tklauser/go-sysconf v0.3.12
go: downloading github.com/golang/protobuf v1.5.3
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20230920204549-e6e6cdab5c13
go: downloading golang.org/x/text v0.13.0
touch -c backend/cmd/stork-agent/stork-agent
Stork Agent build date: 2023-11-26 14:25 (timestamp: 231126142545)
```
Thank you1.14Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1228Stork agent cannot load environment file2023-11-24T16:26:52ZSlawek FigielStork agent cannot load environment fileThe problem was reported [on our mailing list](https://lists.isc.org/pipermail/stork-dev/2023-November/000041.html).
Loading environment variables was removed from [urfave/cli](https://github.com/urfave/cli) in the 2.16.6 version in the...The problem was reported [on our mailing list](https://lists.isc.org/pipermail/stork-dev/2023-November/000041.html).
Loading environment variables was removed from [urfave/cli](https://github.com/urfave/cli) in the 2.16.6 version in the 3005438a1f3d1b67d2751da307463ddf4a5dd95b commit ([change](https://github.com/urfave/cli/blame/v2.25.7/context.go#L54)). It causes Stork not to load the environment file when the `--use-env-file` flag is set.
Currently, the flag name passed to the `context.Set` method must be a valid flag name.
Previously, any names were accepted. We used this behavior to set the raw environment variables from the environment file before parsing the flag values. The environment variables loaded this way were properly detected as standard environment variables.https://gitlab.isc.org/isc-projects/stork/-/issues/1219stork-agent --use-env-file flag does not work2023-11-30T14:50:48ZMarcin Siodelskistork-agent --use-env-file flag does not workAn attempt to run the `stork-agent` with the switch pointing to a custom env file location fails:
```
$ ./stork-agent --env-file=../../../etc/agent.env --use-env-file
FATA[2023-11-06 13:44:31] main.go:432 the '../../../etc...An attempt to run the `stork-agent` with the switch pointing to a custom env file location fails:
```
$ ./stork-agent --env-file=../../../etc/agent.env --use-env-file
FATA[2023-11-06 13:44:31] main.go:432 the '../../../etc/agent.env' environment file is invalid: cannot set 'STORK_AGENT_HOST=localhost' environment variable: no such flag -STORK_AGENT_HOST
```
I tested it both on Ubuntu and macOS. It works fine for the `stork-server` but we use a different CLI lib there. I am not sure it ever worked properly because we don't seem to have system tests for it.1.14Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1210Stork metrics are not up-to-date2023-11-24T15:30:50ZVictor PetrescuStork metrics are not up-to-dateHi everyone,
Is there any refresh rate for the statistics exported under /metrics ?
I’m asking this because I’ve integrated Stork Server with Prometheus and Grafana. The issue is that in Stork Server the DHCP Lease usage adjusts accord...Hi everyone,
Is there any refresh rate for the statistics exported under /metrics ?
I’m asking this because I’ve integrated Stork Server with Prometheus and Grafana. The issue is that in Stork Server the DHCP Lease usage adjusts accordingly to the ISC KEA DHCP server, but when pulling the metrics the value is not the same, seems to be an old one.
The fix to get /metrics up-to-date is to restart isc-stork-server which I don't consider a permanent fix.
Thank you !1.14Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1201Stork 1.13.0 not working on Ubuntu 20.04.6. LTS2023-12-06T18:32:23ZThomas MaurerStork 1.13.0 not working on Ubuntu 20.04.6. LTS---
name: Stork 1.13.0 not working on Ubuntu 20.04.6. LTS
about: `isc-stork-server`
---
**Describe the bug**
Stork V1.13.0 requires GLIBC_2.32 or newer. But on Ubuntu 20.04.6 LTS (focal) only 2.31 is available. However in the Documenta...---
name: Stork 1.13.0 not working on Ubuntu 20.04.6. LTS
about: `isc-stork-server`
---
**Describe the bug**
Stork V1.13.0 requires GLIBC_2.32 or newer. But on Ubuntu 20.04.6 LTS (focal) only 2.31 is available. However in the Documentation (https://stork.readthedocs.io/en/v1.13.0/install.html#supported-systems) Ubuntu 18.04 and 20.04 are reportet to work.
**To Reproduce**
Steps to reproduce the behavior:
1. Update stork to V1.13.0
2. Stork does not Start
3. in var/log/syslog is see:
Oct 16 08:26:34 sbcc-dhcp-0101 stork-server[1557772]: /usr/bin/stork-server: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /usr/bin/stork-server)
Oct 16 08:26:34 sbcc-dhcp-0101 stork-server[1557772]: /usr/bin/stork-server: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /usr/bin/stork-server)
Oct
**Expected behavior**
Update the Documentation or update the dependencies for Stork to run on Ubuntu 20.04
**Environment:**
- Kea version: 2.0.3
tarball
linked with:
log4cplus 1.1.2
OpenSSL 1.1.1f 31 Mar 2020
database:
MySQL backend 12.0, library 8.0.34
PostgreSQL backend 6.2, library 120016
Memfile backend 2.1
- Stork: 1.13.0.231011103556
- OS: Ubuntu 20.04.6 LTS
**Contacting you**
Feel free to contact me via E-Mail1.14Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1198Support for output_options alias in Kea 2.5.22023-11-29T12:47:05ZMarcin SiodelskiSupport for output_options alias in Kea 2.5.2Kea 2.5.2 introduced an alias for the `output_options` parameter. Now, even when you specify the `output_options` the `config-get` command returns `output-options` (hyphened version). This confuses Stork which expects the old version wit...Kea 2.5.2 introduced an alias for the `output_options` parameter. Now, even when you specify the `output_options` the `config-get` command returns `output-options` (hyphened version). This confuses Stork which expects the old version with an underscore. We need to recognize both.1.14Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1195Subnet edit form: parameters range2023-11-29T12:47:05ZSlawek FigielSubnet edit form: parameters rangeThe issue was found during [1.13 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408796) by @marcin.
The `t1-percent` and `t2-percent` parameters in the subnet form must be between 0.0 and 1.0. Unfortunately,...The issue was found during [1.13 sanity checks](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408796) by @marcin.
The `t1-percent` and `t2-percent` parameters in the subnet form must be between 0.0 and 1.0. Unfortunately, the form configures the input box with min and max values between 0 and 100. It makes it impossible to specify correct values for these parameters.1.14Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1188Fix hook build2023-10-12T08:09:12ZSlawek FigielFix hook buildAddresses:
- [Wrong go version](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408726)
- [Missing files in tarball](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408734)
- [Incompatible hooks](https://gitlab...Addresses:
- [Wrong go version](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408726)
- [Missing files in tarball](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408734)
- [Incompatible hooks](https://gitlab.isc.org/isc-projects/stork/-/issues/1187#note_408753)1.13Marcin SiodelskiMarcin Siodelskihttps://gitlab.isc.org/isc-projects/stork/-/issues/1183LDAP hook: Minor issues in README2023-10-09T08:46:01ZSlawek FigielLDAP hook: Minor issues in README- Path to `stork-agent` hook directory instead of `stork-server`
- $ at the beginning
- Improperly commented lines (lines stated with % )- Path to `stork-agent` hook directory instead of `stork-server`
- $ at the beginning
- Improperly commented lines (lines stated with % )1.13Slawek FigielSlawek Figielhttps://gitlab.isc.org/isc-projects/stork/-/issues/1176Subnet, network, host and possibly other tabs are not shown2023-10-05T14:58:41ZMarcin SiodelskiSubnet, network, host and possibly other tabs are not shownI speculate that this is a regression after the most recent Primeng/Angular upgrade.
Open a tab with a list of subnets. Click on one of the subnets. The subnet contents are shown and the tab with the list of subnets is unselected, but t...I speculate that this is a regression after the most recent Primeng/Angular upgrade.
Open a tab with a list of subnets. Click on one of the subnets. The subnet contents are shown and the tab with the list of subnets is unselected, but the tab for the subnet is not visible. In other words, you always have only one (default) tab and no way to navigate between different tabs.
In the following picture you can see what happens after clicking on a subnet. The subnet contents are displayed but there is only one tab.
![Zrzut_ekranu_2023-10-3_o_21.28.07](/uploads/3159164320680fabd343a780fd7c8a2c/Zrzut_ekranu_2023-10-3_o_21.28.07.png)1.13Marcin SiodelskiMarcin Siodelski